{"thread":{"id":"34788","subject":"[PATCH] builtin/fetch.c: Fix a sparse warning","startedAt":"2013-08-28T18:56:17Z","lastAt":"2013-08-28T18:56:17Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"226094","messageId":"521E47D1.9060106@ramsay1.demon.co.uk","threadId":"34788","inReplyTo":null,"subject":"[PATCH] builtin/fetch.c: Fix a sparse warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2013-08-28T18:56:17Z","receivedAt":"2013-08-28T18:56:17Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSparse issues an \"'prepare_transport' was not declared. Should it\nbe static?\" warning. In order to suppress the warning, since this\nsymbol only requires file scope, we simply add the static modifier\nto it's declaration.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Junio,\n\nWhen you re-build the next branch, could you please squash this into\ncommit db5723c6 (\"fetch: refactor code that prepares a transport\",\n07-08-2013). [from the 'jc/transport-do-not-use-connect-twice-in-fetch'\nbranch]\n\nThanks!\n\nATB,\nRamsay Jones\n\n\n builtin/fetch.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/fetch.c b/builtin/fetch.c\nindex e880116..9e654ef 100644\n--- a/builtin/fetch.c\n+++ b/builtin/fetch.c\n@@ -747,7 +747,7 @@ static void set_option(struct transport *transport, const char *name, const char\n \t\t\tname, transport->url);\n }\n \n-struct transport *prepare_transport(struct remote *remote)\n+static struct transport *prepare_transport(struct remote *remote)\n {\n \tstruct transport *transport;\n \ttransport = transport_get(remote, NULL);\n-- \n1.8.4\n"}]}