{"thread":{"id":"34757","subject":"[PATCH 1/3] Make test \"using invalid commit with -C\" more strict","startedAt":"2013-08-24T03:30:29Z","lastAt":"2013-08-24T03:30:30Z","messageCount":2,"participants":["Kacper Kornet"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"225767","messageId":"1377315030-22668-1-git-send-email-draenog@pld-linux.org","threadId":"34757","inReplyTo":null,"subject":"[PATCH 0/3] Fixes for tests run without perl","fromName":"Kacper Kornet","fromEmail":"draenog@pld-linux.org","sentAt":"2013-08-24T03:30:29Z","receivedAt":"2013-08-24T03:30:29Z","isPatch":true,"sender":{"key":"draenog@pld-linux.org","avatar":"https://avatars.githubusercontent.com/u/608762?v=4"},"body":"This is a set of fixes for problems found while running\ntest suite without perl installed.\n\nKacper\n"},{"id":"225766","messageId":"1377315030-22668-2-git-send-email-draenog@pld-linux.org","threadId":"34757","inReplyTo":"1377315030-22668-1-git-send-email-draenog@pld-linux.org","subject":"[PATCH 1/3] Make test \"using invalid commit with -C\" more strict","fromName":"Kacper Kornet","fromEmail":"draenog@pld-linux.org","sentAt":"2013-08-24T03:30:30Z","receivedAt":"2013-08-24T03:30:30Z","isPatch":true,"sender":{"key":"draenog@pld-linux.org","avatar":"https://avatars.githubusercontent.com/u/608762?v=4"},"body":"In the test 'using invalid commit with -C' git-commit would have failed\neven if the -C option  had been given the correct commit, as there was\nnothing to commit. Fix it by making sure there is always something to\ncommit and git-commit fails because of the invalid commit provided to\nit.\n\nSigned-off-by: Kacper Kornet <draenog@pld-linux.org>\n---\n t/t7501-commit.sh | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\ndiff --git a/t/t7501-commit.sh b/t/t7501-commit.sh\nindex 99ce36f..699a603 100755\n--- a/t/t7501-commit.sh\n+++ b/t/t7501-commit.sh\n@@ -53,7 +53,10 @@ test_expect_success PERL 'can use paths with --interactive' '\n '\n \n test_expect_success 'using invalid commit with -C' '\n-\ttest_must_fail git commit -C bogus\n+\techo bong >file &&\n+\tgit add file &&\n+\ttest_must_fail git commit -C bogus &&\n+\tgit reset\n '\n \n test_expect_success 'nothing to commit' '\n-- \n1.8.3.4\n\n\n>From 8ad7ef374e1b05cb73d6cf445c44f10e5ec36be3 Mon Sep 17 00:00:00 2001\nFrom: Kacper Kornet <draenog@pld-linux.org>\nDate: Sat, 24 Aug 2013 03:58:05 +0100\nSubject: [PATCH 2/3] t/t3701-add-interactive.sh: Add PERL prerequisite\n\nThe test 'patch mode ignores unmerged entries' uses git-add -p, so it\ndepends on the perl code.\n\nSigned-off-by: Kacper Kornet <draenog@pld-linux.org>\n---\n t/t3701-add-interactive.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh\nindex 9fab25c..8514220 100755\n--- a/t/t3701-add-interactive.sh\n+++ b/t/t3701-add-interactive.sh\n@@ -330,7 +330,7 @@ test_expect_success PERL 'split hunk \"add -p (edit)\"' '\n \t! grep \"^+15\" actual\n '\n \n-test_expect_success 'patch mode ignores unmerged entries' '\n+test_expect_success PERL 'patch mode ignores unmerged entries' '\n \tgit reset --hard &&\n \ttest_commit conflict &&\n \ttest_commit non-conflict &&\n-- \n1.8.3.4\n\n\n>From 14f135b178bfaba67653bc3bedf65ec45e38bc76 Mon Sep 17 00:00:00 2001\nFrom: Kacper Kornet <draenog@pld-linux.org>\nDate: Sat, 24 Aug 2013 04:01:02 +0100\nSubject: [PATCH 3/3] t/t7106-reset-unborn-branch.sh: Add PERL prerequisite\n\nThe test 'reset -p' uses git-reset -p, so it depends on the perl code.\n\nSigned-off-by: Kacper Kornet <draenog@pld-linux.org>\n---\n t/t7106-reset-unborn-branch.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7106-reset-unborn-branch.sh b/t/t7106-reset-unborn-branch.sh\nindex 8062cf5..499cd88 100755\n--- a/t/t7106-reset-unborn-branch.sh\n+++ b/t/t7106-reset-unborn-branch.sh\n@@ -27,7 +27,7 @@ test_expect_success 'reset $file' '\n \ttest \"$(git ls-files)\" = \"b\"\n '\n \n-test_expect_success 'reset -p' '\n+test_expect_success PERL 'reset -p' '\n \trm .git/index &&\n \tgit add a &&\n \techo y | git reset -p &&\n-- \n1.8.3.4\n"}]}