{"thread":{"id":"34734","subject":"[PATCH v4 3/4] gitweb: omit the repository owner when it is unset","startedAt":"2013-08-20T16:59:02Z","lastAt":"2013-08-21T09:06:37Z","messageCount":8,"participants":["Tony Finch","Junio C Hamano"],"isPatch":true,"patchVersion":4,"patchTotal":4},"messages":[{"id":"225531","messageId":"724e6c13dba3ee00967b4e3f13e472357e24b6c5.1377019362.git.dot@dotat.at","threadId":"34734","inReplyTo":"cover.1377019362.git.dot@dotat.at","subject":"[PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box.","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-20T16:59:02Z","receivedAt":"2013-08-20T16:59:02Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"The rss_logo CSS style has a fixed width which is too narrow for\nthe string \"OPML\". Replace the fixed width with horizontal padding\nso the text fits with nice margins.\n\nSigned-off-by: Tony Finch \n---\n gitweb/static/gitweb.css | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\nindex cb86d2d..a869be1 100644\n--- a/gitweb/static/gitweb.css\n+++ b/gitweb/static/gitweb.css\n@@ -548,8 +548,7 @@ a.linenr {\n \n a.rss_logo {\n \tfloat: right;\n-\tpadding: 3px 0px;\n-\twidth: 35px;\n+\tpadding: 3px 5px;\n \tline-height: 10px;\n \tborder: 1px solid;\n \tborder-color: #fcc7a5 #7d3302 #3e1a01 #ff954e;\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"225530","messageId":"5c4afd189553d0f1e83b0c2b9758643deba5a671.1377019362.git.dot@dotat.at","threadId":"34734","inReplyTo":"cover.1377019362.git.dot@dotat.at","subject":"[PATCH v4 2/4] gitweb: vertically centre contents of page footer","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-20T16:59:03Z","receivedAt":"2013-08-20T16:59:03Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"Signed-off-by: Tony Finch \n---\n gitweb/static/gitweb.css | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\nindex a869be1..3b4d833 100644\n--- a/gitweb/static/gitweb.css\n+++ b/gitweb/static/gitweb.css\n@@ -68,12 +68,13 @@ div.page_path {\n }\n \n div.page_footer {\n-\theight: 17px;\n+\theight: 22px;\n \tpadding: 4px 8px;\n \tbackground-color: #d9d8d1;\n }\n \n div.page_footer_text {\n+\tline-height: 22px;\n \tfloat: left;\n \tcolor: #555555;\n \tfont-style: italic;\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"225528","messageId":"e5b90eb96919a30661bcad7ba77aba0b6bfcfa72.1377019362.git.dot@dotat.at","threadId":"34734","inReplyTo":"cover.1377019362.git.dot@dotat.at","subject":"[PATCH v4 3/4] gitweb: omit the repository owner when it is unset","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-20T16:59:44Z","receivedAt":"2013-08-20T16:59:44Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"On the repository summary page, leave the owner line out if the\nrepo does not have an owner, rather than displaying a labelled empty\nfield. This does not affect the owner column in the projects list\npage, which is present unless $omit_owner is true.\n\nSigned-off-by: Tony Finch \n---\n gitweb/gitweb.perl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 8d69ada..c029b98 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -6463,7 +6463,7 @@ sub git_summary {\n \tprint \"
 
\\n\";\n \tprint \"\\n\" .\n \t \"\\n\";\n- unless ($omit_owner) {\n+ if ($owner and not $omit_owner) {\n \t print \"\\n\";\n }\n \tif (defined $cd{'rfc2822'}) {\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"225529","messageId":"3a61bd631c264ac398271af34400809dc2fa0429.1377019362.git.dot@dotat.at","threadId":"34734","inReplyTo":"cover.1377019362.git.dot@dotat.at","subject":"[PATCH v4 4/4] gitweb: make search help link less ugly","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-20T16:59:54Z","receivedAt":"2013-08-20T16:59:54Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"The search help link was a superscript question mark right next to\na drop-down menu, which looks misaligned and is a cramped and\nawkward click target. Remove the superscript tags and add some\nspacing to fix these nits. Add a title attribute to provide an\nexplanatory mouseover.\n\nSigned-off-by: Tony Finch \n---\n gitweb/gitweb.perl | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 8d69ada..59af7de 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4030,8 +4030,8 @@ sub print_search_form {\n \t $cgi->input({-name=>\"h\", -value=>$search_hash, -type=>\"hidden\"}) . \"\\n\" .\n \t $cgi->popup_menu(-name => 'st', -default => 'commit',\n \t -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .\n-\t $cgi->sup($cgi->a({-href => href(action=>\"search_help\")}, \"?\")) .\n-\t \" search:\\n\",\n+\t \" \" . $cgi->a({-href => href(action=>\"search_help\"),\n+\t\t\t -title => \"search help\" }, \"?\") . \" search:\\n\",\n \t $cgi->textfield(-name => \"s\", -value => $searchtext, -override => 1) . \"\\n\" .\n \t \"\" .\n \t $cgi->checkbox(-name => 'sr', -value => 1, -label => 're',\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"225532","messageId":"cover.1377019362.git.dot@dotat.at","threadId":"34734","inReplyTo":"alpine.LSU.2.00.1308051220170.6019@hermes-2.csi.cam.ac.uk","subject":"[PATCH v4 0/4] Four small gitweb tweaks","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-20T17:22:42Z","receivedAt":"2013-08-20T17:22:42Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"This is mostly just a repost to un-stall this topic.\n\nI have fixed the tab damage problem spotted by Jakub in the search\nhelp link patch, and I have improved the commit message for the\nrepository owner patch. No other changes.\n\nTony Finch (4):\n gitweb: Ensure OPML text fits inside its box.\n gitweb: vertically centre contents of page footer\n gitweb: omit the repository owner when it is unset\n gitweb: make search help link less ugly\n\n gitweb/gitweb.perl | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"225553","messageId":"xmqq61v0w35x.fsf@gitster.dls.corp.google.com","threadId":"34734","inReplyTo":"724e6c13dba3ee00967b4e3f13e472357e24b6c5.1377019362.git.dot@dotat.at","subject":"Re: [PATCH v4 1/4] gitweb: Ensure OPML text fits inside its box.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-08-20T19:52:25Z","receivedAt":"2013-08-20T19:52:25Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tony Finch writes:\n\n> The rss_logo CSS style has a fixed width which is too narrow for\n> the string \"OPML\". Replace the fixed width with horizontal padding\n> so the text fits with nice margins.\n\nMakes sense to me (although I do not do css).\n\n>\n> Signed-off-by: Tony Finch \n> ---\n> gitweb/static/gitweb.css | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\n> index cb86d2d..a869be1 100644\n> --- a/gitweb/static/gitweb.css\n> +++ b/gitweb/static/gitweb.css\n> @@ -548,8 +548,7 @@ a.linenr {\n> \n> a.rss_logo {\n> \tfloat: right;\n> -\tpadding: 3px 0px;\n> -\twidth: 35px;\n> +\tpadding: 3px 5px;\n> \tline-height: 10px;\n> \tborder: 1px solid;\n> \tborder-color: #fcc7a5 #7d3302 #3e1a01 #ff954e;\n"},{"id":"225554","messageId":"xmqq1u5ow33c.fsf@gitster.dls.corp.google.com","threadId":"34734","inReplyTo":"5c4afd189553d0f1e83b0c2b9758643deba5a671.1377019362.git.dot@dotat.at","subject":"Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-08-20T19:53:59Z","receivedAt":"2013-08-20T19:53:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tony Finch writes:\n\n> Signed-off-by: Tony Finch \n> ---\n> gitweb/static/gitweb.css | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\n> index a869be1..3b4d833 100644\n> --- a/gitweb/static/gitweb.css\n> +++ b/gitweb/static/gitweb.css\n> @@ -68,12 +68,13 @@ div.page_path {\n> }\n> \n> div.page_footer {\n> -\theight: 17px;\n> +\theight: 22px;\n> \tpadding: 4px 8px;\n> \tbackground-color: #d9d8d1;\n> }\n> \n> div.page_footer_text {\n> +\tline-height: 22px;\n> \tfloat: left;\n> \tcolor: #555555;\n> \tfont-style: italic;\n\nHmmm, is it a good idea to do \"px\" here, or are they ways to do\nrelative to x-height or something to make sure the text fits?\n"},{"id":"225606","messageId":"alpine.LSU.2.00.1308211003040.6019@hermes-2.csi.cam.ac.uk","threadId":"34734","inReplyTo":"xmqq1u5ow33c.fsf@gitster.dls.corp.google.com","subject":"Re: [PATCH v4 2/4] gitweb: vertically centre contents of page footer","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-21T09:06:37Z","receivedAt":"2013-08-21T09:06:37Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"Junio C Hamano wrote:\n> Tony Finch writes:\n>\n> > div.page_footer {\n> > -\theight: 17px;\n> > +\theight: 22px;\n> > \tpadding: 4px 8px;\n> > \tbackground-color: #d9d8d1;\n> > }\n> >\n> > div.page_footer_text {\n> > +\tline-height: 22px;\n> > \tfloat: left;\n> > \tcolor: #555555;\n> > \tfont-style: italic;\n>\n> Hmmm, is it a good idea to do \"px\" here, or are they ways to do\n> relative to x-height or something to make sure the text fits?\n\nGood question. I also don't know much about css. I basically followed the\nstyle that was already there, and found out about vertical centering using\nline-height by searching the web.\n\nI think font-size relative scaling would require a bigger overhaul.\n\nTony.\n-- \nf.anthony.n.finch http://dotat.at/\nForties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.\nRough, becoming slight or moderate. Showers, rain at first. Moderate or good,\noccasionally poor at first.\n"}]}
description\" . esc_html($descr) . \"
owner\" . esc_html($owner) . \"