{"thread":{"id":"34663","subject":"[PATCH] t/t7407: fix two typos in submodule tests","startedAt":"2013-08-09T20:12:54Z","lastAt":"2013-08-09T20:12:54Z","messageCount":1,"participants":["Phil Hord"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"224947","messageId":"1376079174-7226-1-git-send-email-hordp@cisco.com","threadId":"34663","inReplyTo":null,"subject":"[PATCH] t/t7407: fix two typos in submodule tests","fromName":"Phil Hord","fromEmail":"hordp@cisco.com","sentAt":"2013-08-09T20:12:54Z","receivedAt":"2013-08-09T20:12:54Z","isPatch":true,"sender":{"key":"phil.hord@gmail.com","avatar":"https://avatars.githubusercontent.com/u/123908?v=4"},"body":"In t/t7407-submodule-foreach.sh there is a typo in one of the\npath names given for a test step.  The correct path is\nnested1/nested2/.git, but nested1/nested1/nested2/.git is\ngiven instead.  The typo is hidden because this line also\naccidentally omits the && chain operator.  The omitted chain\nalso means the return values of all the previous commands in\nthis test are also being ignored.\n\nFix the path and add the chain operator so the entire test\nsequence can be properly validated.\n\nSigned-off-by: Phil Hord <hordp@cisco.com>\n---\n t/t7407-submodule-foreach.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t7407-submodule-foreach.sh b/t/t7407-submodule-foreach.sh\nindex 91d4fd1..be93f10 100755\n--- a/t/t7407-submodule-foreach.sh\n+++ b/t/t7407-submodule-foreach.sh\n@@ -145,7 +145,7 @@ test_expect_success 'use \"submodule foreach\" to checkout 2nd level submodule' '\n \t\tgit rev-parse --resolve-git-dir nested1/.git &&\n \t\ttest_must_fail git rev-parse --resolve-git-dir nested1/nested2/.git &&\n \t\tgit submodule foreach \"git submodule update --init\" &&\n-\t\tgit rev-parse --resolve-git-dir nested1/nested1/nested2/.git\n+\t\tgit rev-parse --resolve-git-dir nested1/nested2/.git &&\n \t\ttest_must_fail git rev-parse --resolve-git-dir nested1/nested2/nested3/.git\n \t)\n '\n-- \n1.8.4.rc1.433.g415b943\n"}]}