{"thread":{"id":"34590","subject":"[PATCH] log doc: the argument to --encoding is not optional","startedAt":"2013-08-02T22:16:40Z","lastAt":"2013-08-05T15:50:15Z","messageCount":3,"participants":["Jonathan Nieder","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"224466","messageId":"20130802221640.GA7478@elie.Belkin","threadId":"34590","inReplyTo":null,"subject":"[PATCH] log doc: the argument to --encoding is not optional","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-08-02T22:16:40Z","receivedAt":"2013-08-02T22:16:40Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":" $ git log --encoding\n fatal: Option '--encoding' requires a value\n $ git rev-list --encoding\n fatal: Option '--encoding' requires a value\n\nThe argument to --encoding has always been mandatory.  Unfortunately\nmanpages like git-rev-list(1), git-log(1), and git-show(1) have\ndescribed the option's syntax as \"--encoding[=<encoding>]\" since it\nwas first documented.  Clarify by removing the extra brackets.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\n Documentation/git-rev-list.txt   | 2 +-\n Documentation/pretty-options.txt | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt\nindex 65ac27e0..045b37b8 100644\n--- a/Documentation/git-rev-list.txt\n+++ b/Documentation/git-rev-list.txt\n@@ -40,7 +40,7 @@ SYNOPSIS\n \t     [ \\--right-only ]\n \t     [ \\--cherry-mark ]\n \t     [ \\--cherry-pick ]\n-\t     [ \\--encoding[=<encoding>] ]\n+\t     [ \\--encoding=<encoding> ]\n \t     [ \\--(author|committer|grep)=<pattern> ]\n \t     [ \\--regexp-ignore-case | -i ]\n \t     [ \\--extended-regexp | -E ]\ndiff --git a/Documentation/pretty-options.txt b/Documentation/pretty-options.txt\nindex 5e499421..eea0e306 100644\n--- a/Documentation/pretty-options.txt\n+++ b/Documentation/pretty-options.txt\n@@ -28,7 +28,7 @@ people using 80-column terminals.\n \tThis is a shorthand for \"--pretty=oneline --abbrev-commit\"\n \tused together.\n \n---encoding[=<encoding>]::\n+--encoding=<encoding>::\n \tThe commit objects record the encoding used for the log message\n \tin their encoding header; this option can be used to tell the\n \tcommand to re-code the commit log message in the encoding\n-- \n1.8.4.rc1\n"},{"id":"224579","messageId":"7vob9cnp0f.fsf@alter.siamese.dyndns.org","threadId":"34590","inReplyTo":"20130802221640.GA7478@elie.Belkin","subject":"Re: [PATCH] log doc: the argument to --encoding is not optional","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-08-05T15:20:00Z","receivedAt":"2013-08-05T15:20:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n>  $ git log --encoding\n>  fatal: Option '--encoding' requires a value\n>  $ git rev-list --encoding\n>  fatal: Option '--encoding' requires a value\n>\n> The argument to --encoding has always been mandatory.  Unfortunately\n> manpages like git-rev-list(1), git-log(1), and git-show(1) have\n> described the option's syntax as \"--encoding[=<encoding>]\" since it\n> was first documented.  Clarify by removing the extra brackets.\n>\n> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>\n> ---\n\nThanks.\n\n>  Documentation/git-rev-list.txt   | 2 +-\n>  Documentation/pretty-options.txt | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-rev-list.txt b/Documentation/git-rev-list.txt\n> index 65ac27e0..045b37b8 100644\n> --- a/Documentation/git-rev-list.txt\n> +++ b/Documentation/git-rev-list.txt\n> @@ -40,7 +40,7 @@ SYNOPSIS\n>  \t     [ \\--right-only ]\n>  \t     [ \\--cherry-mark ]\n>  \t     [ \\--cherry-pick ]\n> -\t     [ \\--encoding[=<encoding>] ]\n> +\t     [ \\--encoding=<encoding> ]\n>  \t     [ \\--(author|committer|grep)=<pattern> ]\n>  \t     [ \\--regexp-ignore-case | -i ]\n>  \t     [ \\--extended-regexp | -E ]\n> diff --git a/Documentation/pretty-options.txt b/Documentation/pretty-options.txt\n> index 5e499421..eea0e306 100644\n> --- a/Documentation/pretty-options.txt\n> +++ b/Documentation/pretty-options.txt\n> @@ -28,7 +28,7 @@ people using 80-column terminals.\n>  \tThis is a shorthand for \"--pretty=oneline --abbrev-commit\"\n>  \tused together.\n>  \n> ---encoding[=<encoding>]::\n> +--encoding=<encoding>::\n>  \tThe commit objects record the encoding used for the log message\n>  \tin their encoding header; this option can be used to tell the\n>  \tcommand to re-code the commit log message in the encoding\n"},{"id":"224586","messageId":"7vzjswm91k.fsf@alter.siamese.dyndns.org","threadId":"34590","inReplyTo":"20130802221640.GA7478@elie.Belkin","subject":"Re: [PATCH] log doc: the argument to --encoding is not optional","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-08-05T15:50:15Z","receivedAt":"2013-08-05T15:50:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}