{"thread":{"id":"3457","subject":"gitview: Fix the graph display","startedAt":"2006-02-24T16:27:51Z","lastAt":"2006-02-24T16:27:51Z","messageCount":1,"participants":["Aneesh Kumar K.V"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"16682","messageId":"43FF3407.5080607@gmail.com","threadId":"3457","inReplyTo":null,"subject":"gitview: Fix the graph display","fromName":"Aneesh Kumar K.V","fromEmail":"aneesh.kumar@gmail.com","sentAt":"2006-02-24T16:27:51Z","receivedAt":"2006-02-24T16:27:51Z","isPatch":false,"sender":{"key":"aneesh.kumar@gmail.com","avatar":"https://gravatar.com/avatar/0621fc0b2f14ead1e9024382f16053a808c148596da30c1b92572fa075621f68?d=mp&s=160"},"body":"\n\nSubject: gitview: Fix the graph display .\n\nThis fix all the known issue with the graph display\nThe bug need to be explained graphically\n\n                                 |\n                                 a\nThis line need not be there ---->| \\\n                                 b  |\n                                 | /\n                                 c \n\nc is parent of a and all a,b and c are placed on the same line and b is child of c \nWith my last checkin I added  a seperate line to indicate that a is\nconnected to c. But then we had the line connecting a and b which should \nnot be ther. This changes fixes the same bug\n \n\n\nSigned-off-by: Aneesh Kumar K.V <aneesh.kumar@gmail.com>\n\n---\n\n contrib/gitview/gitview |    6 ++++--\n 1 files changed, 4 insertions(+), 2 deletions(-)\n\nd4da5f1243c47322ede9dae2a65098cbc7e9ecb5\ndiff --git a/contrib/gitview/gitview b/contrib/gitview/gitview\nindex 2cde71e..4e3847d 100755\n--- a/contrib/gitview/gitview\n+++ b/contrib/gitview/gitview\n@@ -938,8 +938,10 @@ class GitView:\n \tdef draw_incomplete_line(self, sha1, node_pos, out_line, in_line, index):\n \t\tfor idx, pos in enumerate(self.incomplete_line[sha1]):\n \t\t\tif(pos == node_pos):\n-\t\t\t\tout_line.append((pos,\n-\t\t\t\t\tpos+0.5, self.colours[sha1]))\n+\t\t\t\t#remove the straight line and add a slash\n+\t\t\t\tif ((pos, pos, self.colours[sha1]) in out_line):\n+\t\t\t\t\tout_line.remove((pos, pos, self.colours[sha1]))\n+\t\t\t\tout_line.append((pos, pos+0.5, self.colours[sha1]))\n \t\t\t\tself.incomplete_line[sha1][idx] = pos = pos+0.5\n \t\t\ttry:\n \t\t\t\tnext_commit = self.commits[index+1]\n-- \n1.2.3.g2cf3-dirty\n\n"}]}