{"thread":{"id":"34560","subject":"[PATCH] fsck: Replace deprecated OPT_BOOLEAN by OPT_BOOL","startedAt":"2013-07-29T16:45:54Z","lastAt":"2013-07-29T17:56:04Z","messageCount":2,"participants":["Stefan Beller","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"224234","messageId":"1375116354-14618-1-git-send-email-stefanbeller@googlemail.com","threadId":"34560","inReplyTo":null,"subject":"[PATCH] fsck: Replace deprecated OPT_BOOLEAN by OPT_BOOL","fromName":"Stefan Beller","fromEmail":"stefanbeller@googlemail.com","sentAt":"2013-07-29T16:45:54Z","receivedAt":"2013-07-29T16:45:54Z","isPatch":true,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"This task emerged from b04ba2bb4.\nAll occurrences of the respective variables have been reviewed and none\nof them relied on the counting up mechanism, but all of them were\nusing the variable as a true boolean.\n\nSigned-off-by: Stefan Beller <stefanbeller@googlemail.com>\n---\n builtin/fsck.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)\n\ndiff --git a/builtin/fsck.c b/builtin/fsck.c\nindex 9909b6d..39fa5e8 100644\n--- a/builtin/fsck.c\n+++ b/builtin/fsck.c\n@@ -611,15 +611,15 @@ static char const * const fsck_usage[] = {\n \n static struct option fsck_opts[] = {\n \tOPT__VERBOSE(&verbose, N_(\"be verbose\")),\n-\tOPT_BOOLEAN(0, \"unreachable\", &show_unreachable, N_(\"show unreachable objects\")),\n+\tOPT_BOOL(0, \"unreachable\", &show_unreachable, N_(\"show unreachable objects\")),\n \tOPT_BOOL(0, \"dangling\", &show_dangling, N_(\"show dangling objects\")),\n-\tOPT_BOOLEAN(0, \"tags\", &show_tags, N_(\"report tags\")),\n-\tOPT_BOOLEAN(0, \"root\", &show_root, N_(\"report root nodes\")),\n-\tOPT_BOOLEAN(0, \"cache\", &keep_cache_objects, N_(\"make index objects head nodes\")),\n-\tOPT_BOOLEAN(0, \"reflogs\", &include_reflogs, N_(\"make reflogs head nodes (default)\")),\n-\tOPT_BOOLEAN(0, \"full\", &check_full, N_(\"also consider packs and alternate objects\")),\n-\tOPT_BOOLEAN(0, \"strict\", &check_strict, N_(\"enable more strict checking\")),\n-\tOPT_BOOLEAN(0, \"lost-found\", &write_lost_and_found,\n+\tOPT_BOOL(0, \"tags\", &show_tags, N_(\"report tags\")),\n+\tOPT_BOOL(0, \"root\", &show_root, N_(\"report root nodes\")),\n+\tOPT_BOOL(0, \"cache\", &keep_cache_objects, N_(\"make index objects head nodes\")),\n+\tOPT_BOOL(0, \"reflogs\", &include_reflogs, N_(\"make reflogs head nodes (default)\")),\n+\tOPT_BOOL(0, \"full\", &check_full, N_(\"also consider packs and alternate objects\")),\n+\tOPT_BOOL(0, \"strict\", &check_strict, N_(\"enable more strict checking\")),\n+\tOPT_BOOL(0, \"lost-found\", &write_lost_and_found,\n \t\t\t\tN_(\"write dangling objects in .git/lost-found\")),\n \tOPT_BOOL(0, \"progress\", &show_progress, N_(\"show progress\")),\n \tOPT_END(),\n-- \n1.8.4.rc0.1.g8f6a3e5\n"},{"id":"224243","messageId":"7vfvux1c97.fsf@alter.siamese.dyndns.org","threadId":"34560","inReplyTo":"1375116354-14618-1-git-send-email-stefanbeller@googlemail.com","subject":"Re: [PATCH] fsck: Replace deprecated OPT_BOOLEAN by OPT_BOOL","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-07-29T17:56:04Z","receivedAt":"2013-07-29T17:56:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Stefan Beller <stefanbeller@googlemail.com> writes:\n\n> This task emerged from b04ba2bb4.\n> All occurrences of the respective variables have been reviewed and none\n> of them relied on the counting up mechanism, but all of them were\n> using the variable as a true boolean.\n>\n> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>\n> ---\n\nLooked correct; thanks.\n\n\n>  builtin/fsck.c | 16 ++++++++--------\n>  1 file changed, 8 insertions(+), 8 deletions(-)\n>\n> diff --git a/builtin/fsck.c b/builtin/fsck.c\n> index 9909b6d..39fa5e8 100644\n> --- a/builtin/fsck.c\n> +++ b/builtin/fsck.c\n> @@ -611,15 +611,15 @@ static char const * const fsck_usage[] = {\n>  \n>  static struct option fsck_opts[] = {\n>  \tOPT__VERBOSE(&verbose, N_(\"be verbose\")),\n> -\tOPT_BOOLEAN(0, \"unreachable\", &show_unreachable, N_(\"show unreachable objects\")),\n> +\tOPT_BOOL(0, \"unreachable\", &show_unreachable, N_(\"show unreachable objects\")),\n>  \tOPT_BOOL(0, \"dangling\", &show_dangling, N_(\"show dangling objects\")),\n> -\tOPT_BOOLEAN(0, \"tags\", &show_tags, N_(\"report tags\")),\n> -\tOPT_BOOLEAN(0, \"root\", &show_root, N_(\"report root nodes\")),\n> -\tOPT_BOOLEAN(0, \"cache\", &keep_cache_objects, N_(\"make index objects head nodes\")),\n> -\tOPT_BOOLEAN(0, \"reflogs\", &include_reflogs, N_(\"make reflogs head nodes (default)\")),\n> -\tOPT_BOOLEAN(0, \"full\", &check_full, N_(\"also consider packs and alternate objects\")),\n> -\tOPT_BOOLEAN(0, \"strict\", &check_strict, N_(\"enable more strict checking\")),\n> -\tOPT_BOOLEAN(0, \"lost-found\", &write_lost_and_found,\n> +\tOPT_BOOL(0, \"tags\", &show_tags, N_(\"report tags\")),\n> +\tOPT_BOOL(0, \"root\", &show_root, N_(\"report root nodes\")),\n> +\tOPT_BOOL(0, \"cache\", &keep_cache_objects, N_(\"make index objects head nodes\")),\n> +\tOPT_BOOL(0, \"reflogs\", &include_reflogs, N_(\"make reflogs head nodes (default)\")),\n> +\tOPT_BOOL(0, \"full\", &check_full, N_(\"also consider packs and alternate objects\")),\n> +\tOPT_BOOL(0, \"strict\", &check_strict, N_(\"enable more strict checking\")),\n> +\tOPT_BOOL(0, \"lost-found\", &write_lost_and_found,\n>  \t\t\t\tN_(\"write dangling objects in .git/lost-found\")),\n>  \tOPT_BOOL(0, \"progress\", &show_progress, N_(\"show progress\")),\n>  \tOPT_END(),\n"}]}