{"thread":{"id":"34501","subject":"[PATCH 1/2] Fix generic typos in comments","startedAt":"2013-07-20T19:07:07Z","lastAt":"2013-07-21T22:32:53Z","messageCount":8,"participants":["Ondřej Bílka","Ramkumar Ramachandra","brian m. carlson","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"223852","messageId":"20130720190707.GA30044@domone","threadId":"34501","inReplyTo":null,"subject":"[PATCH 1/2] Fix generic typos in comments","fromName":"Ondřej Bílka","fromEmail":"neleai@seznam.cz","sentAt":"2013-07-20T19:07:07Z","receivedAt":"2013-07-20T19:07:07Z","isPatch":true,"sender":{"key":"neleai@seznam.cz","avatar":"https://avatars.githubusercontent.com/u/48067?v=4"},"body":"Hi, I wrote a tool that effectively fixes typos in comments and only in\ncomments.\nIt can be downloaded here:\n\nhttps://github.com/neleai/stylepp\n\nFor typos you need identify them, write replacement dictionary and run\nSTYLEPP/script/stylepp_skeleton stylepp_fix_comment\n\nHere generic dictionary is used that was taken from wikipedia.\nhttps://github.com/neleai/stylepp/blob/master/maintained/dictionary_wiki\n\n---\n bisect.c                      |    2 +-\n builtin/apply.c               |    6 +++---\n builtin/clean.c               |    2 +-\n builtin/update-index.c        |    4 ++--\n compat/regex/regcomp.c        |   10 +++++-----\n compat/regex/regex_internal.c |    2 +-\n compat/regex/regexec.c        |    4 ++--\n connect.c                     |    2 +-\n daemon.c                      |    2 +-\n diff.c                        |    2 +-\n dir.c                         |    2 +-\n entry.c                       |    2 +-\n fast-import.c                 |    2 +-\n parse-options.c               |    2 +-\n read-cache.c                  |    2 +-\n refs.c                        |    2 +-\n remote.c                      |   14 +++++++-------\n revision.c                    |    2 +-\n sha1-lookup.c                 |    2 +-\n sha1_file.c                   |    2 +-\n sha1_name.c                   |    2 +-\n transport.c                   |    2 +-\n 22 files changed, 36 insertions(+), 36 deletions(-)\n\ndiff --git a/bisect.c b/bisect.c\nindex 71c1958..9c225bd 100644\n--- a/bisect.c\n+++ b/bisect.c\n@@ -845,7 +845,7 @@ static void check_good_are_ancestors_of_bad(const char *prefix, int no_checkout)\n \tif (!stat(filename, &st) && S_ISREG(st.st_mode))\n \t\tgoto done;\n \n-\t/* Bisecting with no good rev is ok. */\n+\t/* Bisecting with no good rev is OK. */\n \tif (good_revs.nr == 0)\n \t\tgoto done;\n \ndiff --git a/builtin/apply.c b/builtin/apply.c\nindex ff01ebf..4f4dd56 100644\n--- a/builtin/apply.c\n+++ b/builtin/apply.c\n@@ -3659,12 +3659,12 @@ static void build_fake_ancestor(struct patch *list, const char *filename)\n \n \t\tif (S_ISGITLINK(patch->old_mode)) {\n \t\t\tif (!preimage_sha1_in_gitlink_patch(patch, sha1))\n-\t\t\t\t; /* ok, the textual part looks sane */\n+\t\t\t\t; /* OK, the textual part looks sane */\n \t\t\telse\n \t\t\t\tdie(\"sha1 information is lacking or useless for submoule %s\",\n \t\t\t\t    name);\n \t\t} else if (!get_sha1_blob(patch->old_sha1_prefix, sha1)) {\n-\t\t\t; /* ok */\n+\t\t\t; /* OK */\n \t\t} else if (!patch->lines_added && !patch->lines_deleted) {\n \t\t\t/* mode-only change: update the current */\n \t\t\tif (get_current_sha1(patch->old_name, sha1))\n@@ -3755,7 +3755,7 @@ static void show_rename_copy(struct patch *p)\n \t\told = slash_old + 1;\n \t\tnew = slash_new + 1;\n \t}\n-\t/* p->old_name thru old is the common prefix, and old and new\n+\t/* p->old_name through old is the common prefix, and old and new\n \t * through the end of names are renames\n \t */\n \tif (old != p->old_name)\ndiff --git a/builtin/clean.c b/builtin/clean.c\nindex 04e396b..badbad3 100644\n--- a/builtin/clean.c\n+++ b/builtin/clean.c\n@@ -89,7 +89,7 @@ static int remove_dirs(struct strbuf *path, const char *prefix, int force_flag,\n \t\tstrbuf_setlen(path, len);\n \t\tstrbuf_addstr(path, e->d_name);\n \t\tif (lstat(path->buf, &st))\n-\t\t\t; /* fall thru */\n+\t\t\t; /* fall through */\n \t\telse if (S_ISDIR(st.st_mode)) {\n \t\t\tif (remove_dirs(path, prefix, force_flag, dry_run, quiet, &gone))\n \t\t\t\tret = 1;\ndiff --git a/builtin/update-index.c b/builtin/update-index.c\nindex 5c7762e..b558e09 100644\n--- a/builtin/update-index.c\n+++ b/builtin/update-index.c\n@@ -71,10 +71,10 @@ static int remove_one_path(const char *path)\n \n /*\n  * Handle a path that couldn't be lstat'ed. It's either:\n- *  - missing file (ENOENT or ENOTDIR). That's ok if we're\n+ *  - missing file (ENOENT or ENOTDIR). That's OK if we're\n  *    supposed to be removing it and the removal actually\n  *    succeeds.\n- *  - permission error. That's never ok.\n+ *  - permission error. That's never OK.\n  */\n static int process_lstat_error(const char *path, int err)\n {\ndiff --git a/compat/regex/regcomp.c b/compat/regex/regcomp.c\nindex d0025bd..8afd4ff 100644\n--- a/compat/regex/regcomp.c\n+++ b/compat/regex/regcomp.c\n@@ -2617,7 +2617,7 @@ parse_dup_op (bin_tree_t *elem, re_string_t *regexp, re_dfa_t *dfa,\n      Build the range expression which starts from START_ELEM, and ends\n      at END_ELEM.  The result are written to MBCSET and SBCSET.\n      RANGE_ALLOC is the allocated size of mbcset->range_starts, and\n-     mbcset->range_ends, is a pointer argument sinse we may\n+     mbcset->range_ends, is a pointer argument since we may\n      update it.  */\n \n static reg_errcode_t\n@@ -2896,7 +2896,7 @@ parse_bracket_exp (re_string_t *regexp, re_dfa_t *dfa, re_token_t *token,\n      Build the range expression which starts from START_ELEM, and ends\n      at END_ELEM.  The result are written to MBCSET and SBCSET.\n      RANGE_ALLOC is the allocated size of mbcset->range_starts, and\n-     mbcset->range_ends, is a pointer argument sinse we may\n+     mbcset->range_ends, is a pointer argument since we may\n      update it.  */\n \n   auto inline reg_errcode_t\n@@ -2980,7 +2980,7 @@ parse_bracket_exp (re_string_t *regexp, re_dfa_t *dfa, re_token_t *token,\n      Build the collating element which is represented by NAME.\n      The result are written to MBCSET and SBCSET.\n      COLL_SYM_ALLOC is the allocated size of mbcset->coll_sym, is a\n-     pointer argument sinse we may update it.  */\n+     pointer argument since we may update it.  */\n \n   auto inline reg_errcode_t\n   __attribute ((always_inline))\n@@ -3419,7 +3419,7 @@ parse_bracket_symbol (bracket_elem_t *elem, re_string_t *regexp,\n      Build the equivalence class which is represented by NAME.\n      The result are written to MBCSET and SBCSET.\n      EQUIV_CLASS_ALLOC is the allocated size of mbcset->equiv_classes,\n-     is a pointer argument sinse we may update it.  */\n+     is a pointer argument since we may update it.  */\n \n static reg_errcode_t\n #ifdef RE_ENABLE_I18N\n@@ -3515,7 +3515,7 @@ build_equiv_class (bitset_t sbcset, const unsigned char *name)\n      Build the character class which is represented by NAME.\n      The result are written to MBCSET and SBCSET.\n      CHAR_CLASS_ALLOC is the allocated size of mbcset->char_classes,\n-     is a pointer argument sinse we may update it.  */\n+     is a pointer argument since we may update it.  */\n \n static reg_errcode_t\n #ifdef RE_ENABLE_I18N\ndiff --git a/compat/regex/regex_internal.c b/compat/regex/regex_internal.c\nindex d4121f2..c270210 100644\n--- a/compat/regex/regex_internal.c\n+++ b/compat/regex/regex_internal.c\n@@ -973,7 +973,7 @@ re_node_set_alloc (re_node_set *set, int size)\n   /*\n    * ADR: valgrind says size can be 0, which then doesn't\n    * free the block of size 0.  Harumph. This seems\n-   * to work ok, though.\n+   * to work OK, though.\n    */\n   if (size == 0)\n     {\ndiff --git a/compat/regex/regexec.c b/compat/regex/regexec.c\nindex 0cd6e0e..ef1e410 100644\n--- a/compat/regex/regexec.c\n+++ b/compat/regex/regexec.c\n@@ -455,7 +455,7 @@ re_search_stub (struct re_pattern_buffer *bufp,\n \n   rval = 0;\n \n-  /* I hope we needn't fill ther regs with -1's when no match was found.  */\n+  /* I hope we needn't fill their regs with -1's when no match was found.  */\n   if (result != REG_NOERROR)\n     rval = -1;\n   else if (regs != NULL)\n@@ -1071,7 +1071,7 @@ acquire_init_state_context (reg_errcode_t *err, const re_match_context_t *mctx,\n    FL_LONGEST_MATCH means we want the POSIX longest matching.\n    If P_MATCH_FIRST is not NULL, and the match fails, it is set to the\n    next place where we may want to try matching.\n-   Note that the matcher assume that the maching starts from the current\n+   Note that the matcher assume that the matching starts from the current\n    index of the buffer.  */\n \n static int\ndiff --git a/connect.c b/connect.c\nindex a0783d4..078a597 100644\n--- a/connect.c\n+++ b/connect.c\n@@ -33,7 +33,7 @@ static int check_ref(const char *name, int len, unsigned int flags)\n \tif ((flags & REF_TAGS) && !memcmp(name, \"tags/\", 5))\n \t\treturn 1;\n \n-\t/* All type bits clear means that we are ok with anything */\n+\t/* All type bits clear means that we are OK with anything */\n \treturn !(flags & ~REF_NORMAL);\n }\n \ndiff --git a/daemon.c b/daemon.c\nindex 6aeddcb..d5684db 100644\n--- a/daemon.c\n+++ b/daemon.c\n@@ -339,7 +339,7 @@ static int run_service(char *dir, struct daemon_service *service)\n \t *\n \t * We want a readable HEAD, usable \"objects\" directory, and\n \t * a \"git-daemon-export-ok\" flag that says that the other side\n-\t * is ok with us doing this.\n+\t * is OK with us doing this.\n \t *\n \t * path_ok() uses enter_repo() and does whitelist checking.\n \t * We only need to make sure the repository is exported.\ndiff --git a/diff.c b/diff.c\nindex e53ddad..e73cccf 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -2043,7 +2043,7 @@ static int is_conflict_marker(const char *line, int marker_size, unsigned long l\n \tfor (cnt = 1; cnt < marker_size; cnt++)\n \t\tif (line[cnt] != firstchar)\n \t\t\treturn 0;\n-\t/* line[1] thru line[marker_size-1] are same as firstchar */\n+\t/* line[1] through line[marker_size-1] are same as firstchar */\n \tif (len < marker_size + 1 || !isspace(line[marker_size]))\n \t\treturn 0;\n \treturn 1;\ndiff --git a/dir.c b/dir.c\nindex 0480419..6586b39 100644\n--- a/dir.c\n+++ b/dir.c\n@@ -1502,7 +1502,7 @@ static int remove_dir_recurse(struct strbuf *path, int flag, int *kept_up)\n \t\tstrbuf_setlen(path, len);\n \t\tstrbuf_addstr(path, e->d_name);\n \t\tif (lstat(path->buf, &st))\n-\t\t\t; /* fall thru */\n+\t\t\t; /* fall through */\n \t\telse if (S_ISDIR(st.st_mode)) {\n \t\t\tif (!remove_dir_recurse(path, flag, &kept_down))\n \t\t\t\tcontinue; /* happy */\ndiff --git a/entry.c b/entry.c\nindex d7c131d..0e33123 100644\n--- a/entry.c\n+++ b/entry.c\n@@ -26,7 +26,7 @@ static void create_directories(const char *path, int path_len,\n \t\t * stat() function instead of the lstat() function.\n \t\t */\n \t\tif (has_dirs_only_path(buf, len, state->base_dir_len))\n-\t\t\tcontinue; /* ok, it is already a directory. */\n+\t\t\tcontinue; /* OK, it is already a directory. */\n \n \t\t/*\n \t\t * If this mkdir() would fail, it could be that there\ndiff --git a/fast-import.c b/fast-import.c\nindex 23f625f..35a1004 100644\n--- a/fast-import.c\n+++ b/fast-import.c\n@@ -2281,7 +2281,7 @@ static void file_change_m(struct branch *b)\n \tcase S_IFLNK:\n \tcase S_IFDIR:\n \tcase S_IFGITLINK:\n-\t\t/* ok */\n+\t\t/* OK */\n \t\tbreak;\n \tdefault:\n \t\tdie(\"Corrupt mode: %s\", command_buf.buf);\ndiff --git a/parse-options.c b/parse-options.c\nindex c2cbca2..17b77cf 100644\n--- a/parse-options.c\n+++ b/parse-options.c\n@@ -328,7 +328,7 @@ static void parse_options_check(const struct option *opts)\n \t\t\t    !(opts->flags & PARSE_OPT_NOARG))\n \t\t\t\terr |= optbug(opts, \"should not accept an argument\");\n \t\tdefault:\n-\t\t\t; /* ok. (usually accepts an argument) */\n+\t\t\t; /* OK. (usually accepts an argument) */\n \t\t}\n \t}\n \tif (err)\ndiff --git a/read-cache.c b/read-cache.c\nindex d5201f9..0bd0b0c 100644\n--- a/read-cache.c\n+++ b/read-cache.c\n@@ -874,7 +874,7 @@ static int has_dir_name(struct index_state *istate,\n \t\t/*\n \t\t * Trivial optimization: if we find an entry that\n \t\t * already matches the sub-directory, then we know\n-\t\t * we're ok, and we can exit.\n+\t\t * we're OK, and we can exit.\n \t\t */\n \t\twhile (pos < istate->cache_nr) {\n \t\t\tstruct cache_entry *p = istate->cache[pos];\ndiff --git a/refs.c b/refs.c\nindex 4302206..a961b3e 100644\n--- a/refs.c\n+++ b/refs.c\n@@ -3073,7 +3073,7 @@ int for_each_reflog_ent_reverse(const char *refname, each_reflog_ent_fn fn, void\n \t\t\t\tscanp = buf - 1; /* leave loop */\n \t\t\t} else {\n \t\t\t\t/*\n-\t\t\t\t * (bp + 1) thru endp is the beginning of the\n+\t\t\t\t * (bp + 1) through endp is the beginning of the\n \t\t\t\t * current line we have in sb\n \t\t\t\t */\n \t\t\t\tstrbuf_splice(&sb, 0, 0, bp + 1, endp - (bp + 1));\ndiff --git a/remote.c b/remote.c\nindex efcba93..498ee46 100644\n--- a/remote.c\n+++ b/remote.c\n@@ -566,20 +566,20 @@ static struct refspec *parse_refspec_internal(int nr_refspec, const char **refsp\n \n \t\t\t/* LHS */\n \t\t\tif (!*rs[i].src)\n-\t\t\t\t; /* empty is ok; it means \"HEAD\" */\n+\t\t\t\t; /* empty is OK; it means \"HEAD\" */\n \t\t\telse if (llen == 40 && !get_sha1_hex(rs[i].src, unused))\n-\t\t\t\trs[i].exact_sha1 = 1; /* ok */\n+\t\t\t\trs[i].exact_sha1 = 1; /* OK */\n \t\t\telse if (!check_refname_format(rs[i].src, flags))\n-\t\t\t\t; /* valid looking ref is ok */\n+\t\t\t\t; /* valid looking ref is OK */\n \t\t\telse\n \t\t\t\tgoto invalid;\n \t\t\t/* RHS */\n \t\t\tif (!rs[i].dst)\n-\t\t\t\t; /* missing is ok; it is the same as empty */\n+\t\t\t\t; /* missing is OK; it is the same as empty */\n \t\t\telse if (!*rs[i].dst)\n-\t\t\t\t; /* empty is ok; it means \"do not store\" */\n+\t\t\t\t; /* empty is OK; it means \"do not store\" */\n \t\t\telse if (!check_refname_format(rs[i].dst, flags))\n-\t\t\t\t; /* valid looking ref is ok */\n+\t\t\t\t; /* valid looking ref is OK */\n \t\t\telse\n \t\t\t\tgoto invalid;\n \t\t} else {\n@@ -591,7 +591,7 @@ static struct refspec *parse_refspec_internal(int nr_refspec, const char **refsp\n \t\t\t *   there is no existing way to validate this.\n \t\t\t */\n \t\t\tif (!*rs[i].src)\n-\t\t\t\t; /* empty is ok */\n+\t\t\t\t; /* empty is OK */\n \t\t\telse if (is_glob) {\n \t\t\t\tif (check_refname_format(rs[i].src, flags))\n \t\t\t\t\tgoto invalid;\ndiff --git a/revision.c b/revision.c\nindex 2f0142f..1fd9672 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -157,7 +157,7 @@ void mark_parents_uninteresting(struct commit *commit)\n \n \t\twhile (commit) {\n \t\t\t/*\n-\t\t\t * A missing commit is ok iff its parent is marked\n+\t\t\t * A missing commit is OK iff its parent is marked\n \t\t\t * uninteresting.\n \t\t\t *\n \t\t\t * We just mark such a thing parsed, so that when\ndiff --git a/sha1-lookup.c b/sha1-lookup.c\nindex c4dc55d..580d2b3 100644\n--- a/sha1-lookup.c\n+++ b/sha1-lookup.c\n@@ -201,7 +201,7 @@ int sha1_entry_pos(const void *table,\n \t\t\t\t\tbreak;\n \t\t\tofs_0 = ofs;\n \t\t\t/*\n-\t\t\t * byte 0 thru (ofs-1) are the same between\n+\t\t\t * byte 0 through (ofs-1) are the same between\n \t\t\t * lo and hi; ofs is the first byte that is\n \t\t\t * different.\n \t\t\t */\ndiff --git a/sha1_file.c b/sha1_file.c\nindex 4c2365f..2012620 100644\n--- a/sha1_file.c\n+++ b/sha1_file.c\n@@ -974,7 +974,7 @@ struct packed_git *add_packed_git(const char *path, int path_len, int local)\n \t\treturn NULL;\n \t}\n \n-\t/* ok, it looks sane as far as we can check without\n+\t/* OK, it looks sane as far as we can check without\n \t * actually mapping the pack file.\n \t */\n \tp->pack_size = st.st_size;\ndiff --git a/sha1_name.c b/sha1_name.c\nindex 1a75fac..61c4212 100644\n--- a/sha1_name.c\n+++ b/sha1_name.c\n@@ -1052,7 +1052,7 @@ static int reinterpret(const char *name, int namelen, int len, struct strbuf *bu\n  * If the input is not of the accepted format, it returns a negative\n  * number to signal an error.\n  *\n- * If the input was ok but there are not N branch switches in the\n+ * If the input was OK but there are not N branch switches in the\n  * reflog, it returns 0.\n  */\n int interpret_branch_name(const char *name, struct strbuf *buf)\ndiff --git a/transport.c b/transport.c\nindex e15db98..52ad18e 100644\n--- a/transport.c\n+++ b/transport.c\n@@ -1298,7 +1298,7 @@ char *transport_anonymize_url(const char *url)\n \t\t\tswitch (*cp) {\n \t\t\t\t/* RFC 1738 2.1 */\n \t\t\tcase '+': case '.': case '-':\n-\t\t\t\tbreak; /* ok */\n+\t\t\t\tbreak; /* OK */\n \t\t\tdefault:\n \t\t\t\tif (isalnum(*cp))\n \t\t\t\t\tbreak;\n-- \n1.7.10.4\n"},{"id":"223853","messageId":"20130720191311.GB30044@domone","threadId":"34501","inReplyTo":"20130720190707.GA30044@domone","subject":"Re: [PATCH 2/2] Fix typos in comments","fromName":"Ondřej Bílka","fromEmail":"neleai@seznam.cz","sentAt":"2013-07-20T19:13:12Z","receivedAt":"2013-07-20T19:13:12Z","isPatch":true,"sender":{"key":"neleai@seznam.cz","avatar":"https://avatars.githubusercontent.com/u/48067?v=4"},"body":"Hi, I wrote a tool that effectively fixes typos in comments and only in\ncomments.\nIt can be downloaded here:\n\nhttps://github.com/neleai/stylepp\n\nNow I fix specific typos. First I need to generate list of likely typos. \nThis is done by running following commands in desired directory\n\nSTYLEPP/script/stylepp_spellcheck # then\nSTYLEPP/script/stylepp_dictionary \n\nThis creates an dictionary so we can use\n\nSTYLEPP/script/stylepp_skeleton stylepp_fix_comment\n\n\nA dictionary that I generated is following, patch is below.\n\n           accreting accrediting\n             alloted allocated\n           apporiate appropriate\n              becaue because\n           behaviour behavior\n            coalesed coalesced\n           colourful colorful\n            commentz comments\n             commmit commit\n          converison conversion\n        correspoding corresponding\n          descendent descendant\n         descendents descendants\n          ententries entries\n        environement environment\n            erroring erring\n         explicitely explicitly\n             happear appear\n           identifer identifier\n          initialied initialized\n         initialised initialized\n           intialize initialize\n             matcing matching\n          programing programming\n          sastisfies satisfies\n            satisify satisfy\n           sequemces sequences\n             timming trimming\n             traling trailing\n           transiton transition\n           writeable writable\n\n\n---\n builtin/apply.c             |    2 +-\n builtin/checkout.c          |    2 +-\n builtin/fast-export.c       |    2 +-\n builtin/log.c               |    2 +-\n builtin/mktree.c            |    2 +-\n builtin/push.c              |    2 +-\n builtin/tar-tree.c          |    2 +-\n builtin/update-index.c      |    2 +-\n cache.h                     |    2 +-\n combine-diff.c              |    2 +-\n commit-slab.h               |    2 +-\n compat/nedmalloc/malloc.c.h |    8 ++++----\n compat/obstack.h            |    2 +-\n compat/poll/poll.h          |    2 +-\n compat/precompose_utf8.c    |    2 +-\n compat/regex/regcomp.c      |    8 ++++----\n compat/regex/regexec.c      |    4 ++--\n convert.c                   |    2 +-\n convert.h                   |    2 +-\n diff-no-index.c             |    2 +-\n diff.c                      |    4 ++--\n kwset.c                     |   10 +++++-----\n notes.h                     |    8 ++++----\n read-cache.c                |    2 +-\n refs.h                      |    2 +-\n revision.c                  |    2 +-\n sha1_name.c                 |    2 +-\n transport-helper.c          |    4 ++--\n write_or_die.c              |    2 +-\n xdiff/xprepare.c            |    2 +-\n 30 files changed, 46 insertions(+), 46 deletions(-)\n\ndiff --git a/builtin/apply.c b/builtin/apply.c\nindex 4f4dd56..541dc6b 100644\n--- a/builtin/apply.c\n+++ b/builtin/apply.c\n@@ -132,7 +132,7 @@ static void set_default_whitespace_mode(const char *whitespace_option)\n }\n \n /*\n- * For \"diff-stat\" like behaviour, we keep track of the biggest change\n+ * For \"diff-stat\" like behavior, we keep track of the biggest change\n  * we've seen, and the longest filename. That allows us to do simple\n  * scaling.\n  */\ndiff --git a/builtin/checkout.c b/builtin/checkout.c\nindex 7fe0bff..9f29bb2 100644\n--- a/builtin/checkout.c\n+++ b/builtin/checkout.c\n@@ -1137,7 +1137,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)\n \t *  3) git checkout <something> [<paths>]\n \t *\n \t * including \"last branch\" syntax and DWIM-ery for names of\n-\t * remote branches, erroring out for invalid or ambiguous cases.\n+\t * remote branches, erring out for invalid or ambiguous cases.\n \t */\n \tif (argc) {\n \t\tunsigned char rev[20];\ndiff --git a/builtin/fast-export.c b/builtin/fast-export.c\nindex d1d68e9..8e19058 100644\n--- a/builtin/fast-export.c\n+++ b/builtin/fast-export.c\n@@ -379,7 +379,7 @@ static void handle_tag(const char *name, struct tag *tag)\n \tint tagged_mark;\n \tstruct commit *p;\n \n-\t/* Trees have no identifer in fast-export output, thus we have no way\n+\t/* Trees have no identifier in fast-export output, thus we have no way\n \t * to output tags of trees, tags of tags of trees, etc.  Simply omit\n \t * such tags.\n \t */\ndiff --git a/builtin/log.c b/builtin/log.c\nindex 2625f98..b97f56e 100644\n--- a/builtin/log.c\n+++ b/builtin/log.c\n@@ -1348,7 +1348,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)\n \n \t\tif (rev.max_count < 0 && !rev.show_root_diff) {\n \t\t\t/*\n-\t\t\t * This is traditional behaviour of \"git format-patch\n+\t\t\t * This is traditional behavior of \"git format-patch\n \t\t\t * origin\" that prepares what the origin side still\n \t\t\t * does not have.\n \t\t\t */\ndiff --git a/builtin/mktree.c b/builtin/mktree.c\nindex f92ba40..c415a67 100644\n--- a/builtin/mktree.c\n+++ b/builtin/mktree.c\n@@ -176,7 +176,7 @@ int cmd_mktree(int ac, const char **av, const char *prefix)\n \t\t\t/*\n \t\t\t * Execution gets here if the last tree entry is terminated with a\n \t\t\t * new-line.  The final new-line has been made optional to be\n-\t\t\t * consistent with the original non-batch behaviour of mktree.\n+\t\t\t * consistent with the original non-batch behavior of mktree.\n \t\t\t */\n \t\t\t; /* skip creating an empty tree */\n \t\t} else {\ndiff --git a/builtin/push.c b/builtin/push.c\nindex 6d36c24..04f0eaf 100644\n--- a/builtin/push.c\n+++ b/builtin/push.c\n@@ -92,7 +92,7 @@ static NORETURN int die_push_simple(struct branch *branch, struct remote *remote\n \tif (!short_upstream)\n \t\tshort_upstream = branch->merge[0]->src;\n \t/*\n-\t * Don't show advice for people who explicitely set\n+\t * Don't show advice for people who explicitly set\n \t * push.default.\n \t */\n \tif (push_default == PUSH_DEFAULT_UNSPECIFIED)\ndiff --git a/builtin/tar-tree.c b/builtin/tar-tree.c\nindex 3f1e701..c7186d6 100644\n--- a/builtin/tar-tree.c\n+++ b/builtin/tar-tree.c\n@@ -42,7 +42,7 @@ int cmd_tar_tree(int argc, const char **argv, const char *prefix)\n \n \t/*\n \t * Because it's just a compatibility wrapper, tar-tree supports only\n-\t * the old behaviour of reading attributes from the work tree.\n+\t * the old behavior of reading attributes from the work tree.\n \t */\n \tnargv[nargc++] = \"--worktree-attributes\";\n \ndiff --git a/builtin/update-index.c b/builtin/update-index.c\nindex b558e09..53be19c 100644\n--- a/builtin/update-index.c\n+++ b/builtin/update-index.c\n@@ -124,7 +124,7 @@ static int add_one_path(struct cache_entry *old, const char *path, int len, stru\n  *    exist as such any more. If removal isn't allowed, it's\n  *    an error.\n  *\n- *    (NOTE! This is old and arguably fairly strange behaviour.\n+ *    (NOTE! This is old and arguably fairly strange behavior.\n  *    We might want to make this an error unconditionally, and\n  *    use \"--force-remove\" if you actually want to force removal).\n  *\ndiff --git a/cache.h b/cache.h\nindex 2d06169..67f9fae 100644\n--- a/cache.h\n+++ b/cache.h\n@@ -489,7 +489,7 @@ extern void *read_blob_data_from_index(struct index_state *, const char *, unsig\n extern int ie_match_stat(const struct index_state *, const struct cache_entry *, struct stat *, unsigned int);\n extern int ie_modified(const struct index_state *, const struct cache_entry *, struct stat *, unsigned int);\n \n-#define PATHSPEC_ONESTAR 1\t/* the pathspec pattern sastisfies GFNM_ONESTAR */\n+#define PATHSPEC_ONESTAR 1\t/* the pathspec pattern satisfies GFNM_ONESTAR */\n \n struct pathspec {\n \tconst char **raw; /* get_pathspec() result, not freed by free_pathspec() */\ndiff --git a/combine-diff.c b/combine-diff.c\nindex 6dc0609..88525b3 100644\n--- a/combine-diff.c\n+++ b/combine-diff.c\n@@ -165,7 +165,7 @@ static struct lline *coalesce_lines(struct lline *base, int *lenbase,\n \n \t/*\n \t * Coalesce new lines into base by finding the LCS\n-\t * - Create the table to run dynamic programing\n+\t * - Create the table to run dynamic programming\n \t * - Compute the LCS\n \t * - Then reverse read the direction structure:\n \t *   - If we have MATCH, assign parent to base flag, and consume\ndiff --git a/commit-slab.h b/commit-slab.h\nindex 7d48163..4f1c796 100644\n--- a/commit-slab.h\n+++ b/commit-slab.h\n@@ -22,7 +22,7 @@\n  *\n  *   Initializes the indegree slab that associates an array of integers\n  *   to each commit. 'stride' specifies how big each array is.  The slab\n- *   that id initialied by the variant without \"_with_stride\" associates\n+ *   that id initialized by the variant without \"_with_stride\" associates\n  *   each commit with an array of one integer.\n  */\n \ndiff --git a/compat/nedmalloc/malloc.c.h b/compat/nedmalloc/malloc.c.h\nindex 5a44dea..ca0d0d7 100644\n--- a/compat/nedmalloc/malloc.c.h\n+++ b/compat/nedmalloc/malloc.c.h\n@@ -1558,7 +1558,7 @@ static FORCEINLINE void* win32direct_mmap(size_t size) {\n   return (ptr != 0)? ptr: MFAIL;\n }\n \n-/* This function supports releasing coalesed segments */\n+/* This function supports releasing coalesced segments */\n static FORCEINLINE int win32munmap(void* ptr, size_t size) {\n   MEMORY_BASIC_INFORMATION minfo;\n   char* cptr = (char*)ptr;\n@@ -2478,7 +2478,7 @@ typedef struct malloc_segment* msegmentptr;\n \n   Trim support\n     Fields holding the amount of unused topmost memory that should trigger\n-    timming, and a counter to force periodic scanning to release unused\n+    trimming, and a counter to force periodic scanning to release unused\n     non-topmost segments.\n \n   Locking\n@@ -3602,8 +3602,8 @@ static void internal_malloc_stats(mstate m) {\n      and choose its bk node as its replacement.\n   2. If x was the last node of its size, but not a leaf node, it must\n      be replaced with a leaf node (not merely one with an open left or\n-     right), to make sure that lefts and rights of descendents\n-     correspond properly to bit masks.  We use the rightmost descendent\n+     right), to make sure that lefts and rights of descendants\n+     correspond properly to bit masks.  We use the rightmost descendant\n      of x.  We could use any other leaf, but this is easy to locate and\n      tends to counteract removal of leftmosts elsewhere, and so keeps\n      paths shorter than minimally guaranteed.  This doesn't loop much\ndiff --git a/compat/obstack.h b/compat/obstack.h\nindex ceb4bdb..72af819 100644\n--- a/compat/obstack.h\n+++ b/compat/obstack.h\n@@ -80,7 +80,7 @@ change its address during its lifetime.\n When the chars burst over a chunk boundary, we allocate a larger\n chunk, and then copy the partly formed object from the end of the old\n chunk to the beginning of the new larger chunk.  We then carry on\n-accreting characters to the end of the object as we normally would.\n+accrediting characters to the end of the object as we normally would.\n \n A special macro is provided to add a single char at a time to a\n growing object.  This allows the use of register variables, which\ndiff --git a/compat/poll/poll.h b/compat/poll/poll.h\nindex b7aa59d..36b2b10 100644\n--- a/compat/poll/poll.h\n+++ b/compat/poll/poll.h\n@@ -25,7 +25,7 @@\n /* fake a poll(2) environment */\n #define POLLIN      0x0001      /* any readable data available   */\n #define POLLPRI     0x0002      /* OOB/Urgent readable data      */\n-#define POLLOUT     0x0004      /* file descriptor is writeable  */\n+#define POLLOUT     0x0004      /* file descriptor is writable  */\n #define POLLERR     0x0008      /* some poll error occurred      */\n #define POLLHUP     0x0010      /* file descriptor was \"hung up\" */\n #define POLLNVAL    0x0020      /* requested events \"invalid\"    */\ndiff --git a/compat/precompose_utf8.c b/compat/precompose_utf8.c\nindex 7980abd..300d0bb 100644\n--- a/compat/precompose_utf8.c\n+++ b/compat/precompose_utf8.c\n@@ -148,7 +148,7 @@ struct dirent_prec_psx *precompose_utf8_readdir(PREC_DIR *prec_dir)\n \t\t\t\tif (errno || inleft) {\n \t\t\t\t\t/*\n \t\t\t\t\t * iconv() failed and errno could be E2BIG, EILSEQ, EINVAL, EBADF\n-\t\t\t\t\t * MacOS X avoids illegal byte sequemces.\n+\t\t\t\t\t * MacOS X avoids illegal byte sequences.\n \t\t\t\t\t * If they occur on a mounted drive (e.g. NFS) it is not worth to\n \t\t\t\t\t * die() for that, but rather let the user see the original name\n \t\t\t\t\t*/\ndiff --git a/compat/regex/regcomp.c b/compat/regex/regcomp.c\nindex 8afd4ff..9c0ac4a 100644\n--- a/compat/regex/regcomp.c\n+++ b/compat/regex/regcomp.c\n@@ -2788,7 +2788,7 @@ parse_bracket_exp (re_string_t *regexp, re_dfa_t *dfa, re_token_t *token,\n   const int32_t *symb_table;\n   const unsigned char *extra;\n \n-  /* Local function for parse_bracket_exp used in _LIBC environement.\n+  /* Local function for parse_bracket_exp used in _LIBC environment.\n      Seek the collating symbol entry correspondings to NAME.\n      Return the index of the symbol in the SYMB_TABLE.  */\n \n@@ -2892,7 +2892,7 @@ parse_bracket_exp (re_string_t *regexp, re_dfa_t *dfa, re_token_t *token,\n       return UINT_MAX;\n     }\n \n-  /* Local function for parse_bracket_exp used in _LIBC environement.\n+  /* Local function for parse_bracket_exp used in _LIBC environment.\n      Build the range expression which starts from START_ELEM, and ends\n      at END_ELEM.  The result are written to MBCSET and SBCSET.\n      RANGE_ALLOC is the allocated size of mbcset->range_starts, and\n@@ -2976,7 +2976,7 @@ parse_bracket_exp (re_string_t *regexp, re_dfa_t *dfa, re_token_t *token,\n       return REG_NOERROR;\n     }\n \n-  /* Local function for parse_bracket_exp used in _LIBC environement.\n+  /* Local function for parse_bracket_exp used in _LIBC environment.\n      Build the collating element which is represented by NAME.\n      The result are written to MBCSET and SBCSET.\n      COLL_SYM_ALLOC is the allocated size of mbcset->coll_sym, is a\n@@ -3455,7 +3455,7 @@ build_equiv_class (bitset_t sbcset, const unsigned char *name)\n \t/* This isn't a valid character.  */\n \treturn REG_ECOLLATE;\n \n-      /* Build single byte matcing table for this equivalence class.  */\n+      /* Build single byte matching table for this equivalence class.  */\n       char_buf[1] = (unsigned char) '\\0';\n       len = weights[idx1 & 0xffffff];\n       for (ch = 0; ch < SBC_MAX; ++ch)\ndiff --git a/compat/regex/regexec.c b/compat/regex/regexec.c\nindex ef1e410..7c329ad 100644\n--- a/compat/regex/regexec.c\n+++ b/compat/regex/regexec.c\n@@ -2421,7 +2421,7 @@ find_recover_state (reg_errcode_t *err, re_match_context_t *mctx)\n /* From the node set CUR_NODES, pick up the nodes whose types are\n    OP_OPEN_SUBEXP and which have corresponding back references in the regular\n    expression. And register them to use them later for evaluating the\n-   correspoding back references.  */\n+   corresponding back references.  */\n \n static reg_errcode_t\n internal_function\n@@ -3348,7 +3348,7 @@ build_trtable (const re_dfa_t *dfa, re_dfastate_t *state)\n   dests_node = dests_alloc->dests_node;\n   dests_ch = dests_alloc->dests_ch;\n \n-  /* Initialize transiton table.  */\n+  /* Initialize transition table.  */\n   state->word_trtable = state->trtable = NULL;\n \n   /* At first, group all nodes belonging to `state' into several\ndiff --git a/convert.c b/convert.c\nindex 2a2e46c..11a95fc 100644\n--- a/convert.c\n+++ b/convert.c\n@@ -835,7 +835,7 @@ int renormalize_buffer(const char *path, const char *src, size_t len, struct str\n \n /*****************************************************************\n  *\n- * Streaming converison support\n+ * Streaming conversion support\n  *\n  *****************************************************************/\n \ndiff --git a/convert.h b/convert.h\nindex ec5fd69..0c2143c 100644\n--- a/convert.h\n+++ b/convert.h\n@@ -48,7 +48,7 @@ static inline int would_convert_to_git(const char *path, const char *src,\n \n /*****************************************************************\n  *\n- * Streaming converison support\n+ * Streaming conversion support\n  *\n  *****************************************************************/\n \ndiff --git a/diff-no-index.c b/diff-no-index.c\nindex e66fdf3..81a393b 100644\n--- a/diff-no-index.c\n+++ b/diff-no-index.c\n@@ -208,7 +208,7 @@ void diff_no_index(struct rev_info *revs,\n \t\t * when a path outside the repository is given,\n \t\t * e.g. \"git diff /var/tmp/[12]\", or \"git diff\n \t\t * Makefile /var/tmp/Makefile\", allow it to be used as\n-\t\t * a colourful \"diff\" replacement.\n+\t\t * a colorful \"diff\" replacement.\n \t\t */\n \t\tif ((argc != i + 2) ||\n \t\t    (path_inside_repo(prefix, argv[i]) &&\ndiff --git a/diff.c b/diff.c\nindex e73cccf..ab247f7 100644\n--- a/diff.c\n+++ b/diff.c\n@@ -1396,7 +1396,7 @@ static int scale_linear(int it, int width, int max_change)\n \t/*\n \t * make sure that at least one '-' or '+' is printed if\n \t * there is any change to this path. The easiest way is to\n-\t * scale linearly as if the alloted width is one column shorter\n+\t * scale linearly as if the allocated width is one column shorter\n \t * than it is, and then add 1 to the result.\n \t */\n \treturn 1 + (it * (width - 1) / max_change);\n@@ -4460,7 +4460,7 @@ void diff_flush(struct diff_options *options)\n \t    DIFF_OPT_TST(options, DIFF_FROM_CONTENTS)) {\n \t\t/*\n \t\t * run diff_flush_patch for the exit status. setting\n-\t\t * options->file to /dev/null should be safe, becaue we\n+\t\t * options->file to /dev/null should be safe, because we\n \t\t * aren't supposed to produce any output anyway.\n \t\t */\n \t\tif (options->close_file)\ndiff --git a/kwset.c b/kwset.c\nindex 5800999..a0f49b3 100644\n--- a/kwset.c\n+++ b/kwset.c\n@@ -65,7 +65,7 @@ struct trie\n   struct trie *fail;\t\t/* Aho-Corasick failure function. */\n   int depth;\t\t\t/* Depth of this node from the root. */\n   int shift;\t\t\t/* Shift function for search failures. */\n-  int maxshift;\t\t\t/* Max shift of self and descendents. */\n+  int maxshift;\t\t\t/* Max shift of self and descendants. */\n };\n \n /* Structure returned opaquely to the caller, containing everything. */\n@@ -308,7 +308,7 @@ treefails (register struct tree const *tree, struct trie const *fail,\n   treefails(tree->rlink, fail, recourse);\n \n   /* Find, in the chain of fails going back to the root, the first\n-     node that has a descendent on the current label. */\n+     node that has a descendant on the current label. */\n   while (fail)\n     {\n       link = fail->links;\n@@ -426,13 +426,13 @@ kwsprep (kwset_t kws)\n \t computing the delta table, failure function, and shift function. */\n       for (curr = last = kwset->trie; curr; curr = curr->next)\n \t{\n-\t  /* Enqueue the immediate descendents in the level order queue. */\n+\t  /* Enqueue the immediate descendants in the level order queue. */\n \t  enqueue(curr->links, &last);\n \n \t  curr->shift = kwset->mind;\n \t  curr->maxshift = kwset->mind;\n \n-\t  /* Update the delta table for the descendents of this node. */\n+\t  /* Update the delta table for the descendants of this node. */\n \t  treedelta(curr->links, curr->depth, delta);\n \n \t  /* Compute the failure function for the descendants of this node. */\n@@ -450,7 +450,7 @@ kwsprep (kwset_t kws)\n \t\t  fail->shift = curr->depth - fail->depth;\n \n \t      /* If the current node is accepting then the shift at the\n-\t\t fail and its descendents should be no larger than the\n+\t\t fail and its descendants should be no larger than the\n \t\t difference of their depths. */\n \t      if (curr->accepting && fail->maxshift > curr->depth - fail->depth)\n \t\tfail->maxshift = curr->depth - fail->depth;\ndiff --git a/notes.h b/notes.h\nindex 3324c48..c78d5a8 100644\n--- a/notes.h\n+++ b/notes.h\n@@ -64,9 +64,9 @@ extern struct notes_tree {\n const char *default_notes_ref(void);\n \n /*\n- * Flags controlling behaviour of notes tree initialization\n+ * Flags controlling behavior of notes tree initialization\n  *\n- * Default behaviour is to initialize the notes tree from the tree object\n+ * Default behavior is to initialize the notes tree from the tree object\n  * specified by the given (or default) notes ref.\n  */\n #define NOTES_INIT_EMPTY 1\n@@ -152,9 +152,9 @@ int copy_note(struct notes_tree *t,\n \t      int force, combine_notes_fn combine_notes);\n \n /*\n- * Flags controlling behaviour of for_each_note()\n+ * Flags controlling behavior of for_each_note()\n  *\n- * Default behaviour of for_each_note() is to traverse every single note object\n+ * Default behavior of for_each_note() is to traverse every single note object\n  * in the given notes tree, unpacking subtree entries along the way.\n  * The following flags can be used to alter the default behaviour:\n  *\ndiff --git a/read-cache.c b/read-cache.c\nindex 0bd0b0c..0ccce3f 100644\n--- a/read-cache.c\n+++ b/read-cache.c\n@@ -489,7 +489,7 @@ int remove_index_entry_at(struct index_state *istate, int pos)\n }\n \n /*\n- * Remove all cache ententries marked for removal, that is where\n+ * Remove all cache entries marked for removal, that is where\n  * CE_REMOVE is set in ce_flags.  This is much more effective than\n  * calling remove_index_entry_at() for each entry to be removed.\n  */\ndiff --git a/refs.h b/refs.h\nindex 9e5db3a..f1f95cf 100644\n--- a/refs.h\n+++ b/refs.h\n@@ -105,7 +105,7 @@ extern int commit_packed_refs(void);\n extern void rollback_packed_refs(void);\n \n /*\n- * Flags for controlling behaviour of pack_refs()\n+ * Flags for controlling behavior of pack_refs()\n  * PACK_REFS_PRUNE: Prune loose refs after packing\n  * PACK_REFS_ALL:   Pack _all_ refs, not just tags and already packed refs\n  */\ndiff --git a/revision.c b/revision.c\nindex 1fd9672..5ba4216 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -1944,7 +1944,7 @@ static int handle_revision_pseudo_opt(const char *submodule,\n \t * NOTE!\n \t *\n \t * Commands like \"git shortlog\" will not accept the options below\n-\t * unless parse_revision_opt queues them (as opposed to erroring\n+\t * unless parse_revision_opt queues them (as opposed to erring\n \t * out).\n \t *\n \t * When implementing your new pseudo-option, remember to\ndiff --git a/sha1_name.c b/sha1_name.c\nindex 61c4212..bcc1e94 100644\n--- a/sha1_name.c\n+++ b/sha1_name.c\n@@ -52,7 +52,7 @@ static void update_candidates(struct disambiguate_state *ds, const unsigned char\n \t}\n \n \tif (!ds->candidate_ok) {\n-\t\t/* discard the candidate; we know it does not satisify fn */\n+\t\t/* discard the candidate; we know it does not satisfy fn */\n \t\thashcpy(ds->candidate, current);\n \t\tds->candidate_checked = 0;\n \t\treturn;\ndiff --git a/transport-helper.c b/transport-helper.c\nindex db9bd18..c32ae50 100644\n--- a/transport-helper.c\n+++ b/transport-helper.c\n@@ -1131,7 +1131,7 @@ static void *udt_copy_task_routine(void *udt)\n #ifndef NO_PTHREADS\n \n /*\n- * Join thread, with apporiate errors on failure. Name is name for the\n+ * Join thread, with appropriate errors on failure. Name is name for the\n  * thread (for error messages). Returns 0 on success, 1 on failure.\n  */\n static int tloop_join(pthread_t thread, const char *name)\n@@ -1197,7 +1197,7 @@ static void udt_kill_transfer(struct unidirectional_transfer *t)\n }\n \n /*\n- * Join process, with apporiate errors on failure. Name is name for the\n+ * Join process, with appropriate errors on failure. Name is name for the\n  * process (for error messages). Returns 0 on success, 1 on failure.\n  */\n static int tloop_join(pid_t pid, const char *name)\ndiff --git a/write_or_die.c b/write_or_die.c\nindex b50f99a..b97af10 100644\n--- a/write_or_die.c\n+++ b/write_or_die.c\n@@ -13,7 +13,7 @@ static void check_pipe(int err)\n /*\n  * Some cases use stdio, but want to flush after the write\n  * to get error handling (and to get better interactive\n- * behaviour - not buffering excessively).\n+ * behavior - not buffering excessively).\n  *\n  * Of course, if the flush happened within the write itself,\n  * we've already lost the error code, and cannot report it any\ndiff --git a/xdiff/xprepare.c b/xdiff/xprepare.c\nindex 63a22c6..8d3dce0 100644\n--- a/xdiff/xprepare.c\n+++ b/xdiff/xprepare.c\n@@ -379,7 +379,7 @@ static int xdl_clean_mmatch(char const *dis, long i, long s, long e) {\n /*\n  * Try to reduce the problem complexity, discard records that have no\n  * matches on the other file. Also, lines that have multiple matches\n- * might be potentially discarded if they happear in a run of discardable.\n+ * might be potentially discarded if they appear in a run of discardable.\n  */\n static int xdl_cleanup_records(xdlclassifier_t *cf, xdfile_t *xdf1, xdfile_t *xdf2) {\n \tlong i, nm, nreff, mlim;\n-- \n1.7.10.4\n"},{"id":"223858","messageId":"20130720193905.GA3904@vauxhall.crustytoothpaste.net","threadId":"34501","inReplyTo":"20130720191311.GB30044@domone","subject":"Re: [PATCH 2/2] Fix typos in comments","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2013-07-20T19:39:06Z","receivedAt":"2013-07-20T19:39:06Z","isPatch":true,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On Sat, Jul 20, 2013 at 09:13:12PM +0200, Ondřej Bílka wrote:\n> A dictionary that I generated is following, patch is below.\n> \n>              alloted allocated\n\n\"allotted\" is a valid word, and I think it would work fine in the code.\nIt's probably what was intended, anyway.\n\n>            behaviour behavior\n>            colourful colorful\n>          initialised initialized\n\nI'm not sure whether git has a standard for which dialect of English is\nto be used, but the three words on the left are considered correct in\nmost non-American dialects.  Characterizing them as \"typos\" isn't\nstrictly correct.  Perhaps \"Convert comments to American English\" is\nmore accurate?\n\n-- \nbrian m. carlson / brian with sandals: Houston, Texas, US\n+1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only\nOpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"},{"id":"223857","messageId":"CALkWK0kzsVLGXZsxWO5rYahb39LSTFvGuE3hZaCgrJ=nuaoo7w@mail.gmail.com","threadId":"34501","inReplyTo":"20130720191311.GB30044@domone","subject":"Re: [PATCH 2/2] Fix typos in comments","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-07-20T19:51:10Z","receivedAt":"2013-07-20T19:51:10Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Ondřej Bílka wrote:\n> diff --git a/builtin/checkout.c b/builtin/checkout.c\n> index 7fe0bff..9f29bb2 100644\n> --- a/builtin/checkout.c\n> +++ b/builtin/checkout.c\n> @@ -1137,7 +1137,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)\n>          *  3) git checkout <something> [<paths>]\n>          *\n>          * including \"last branch\" syntax and DWIM-ery for names of\n> -        * remote branches, erroring out for invalid or ambiguous cases.\n> +        * remote branches, erring out for invalid or ambiguous cases.\n\nDidn't look through the entire patch, but this caught me eye: what's\nwrong with \"erroring out\"?\n"},{"id":"223861","messageId":"20130720203037.GA3753@domone","threadId":"34501","inReplyTo":"CALkWK0kzsVLGXZsxWO5rYahb39LSTFvGuE3hZaCgrJ=nuaoo7w@mail.gmail.com","subject":"Re: [PATCH 2/2] Fix typos in comments","fromName":"Ondřej Bílka","fromEmail":"neleai@seznam.cz","sentAt":"2013-07-20T20:30:38Z","receivedAt":"2013-07-20T20:30:38Z","isPatch":true,"sender":{"key":"neleai@seznam.cz","avatar":"https://avatars.githubusercontent.com/u/48067?v=4"},"body":"On Sun, Jul 21, 2013 at 01:21:10AM +0530, Ramkumar Ramachandra wrote:\n> Ondřej Bílka wrote:\n> > diff --git a/builtin/checkout.c b/builtin/checkout.c\n> > index 7fe0bff..9f29bb2 100644\n> > --- a/builtin/checkout.c\n> > +++ b/builtin/checkout.c\n> > @@ -1137,7 +1137,7 @@ int cmd_checkout(int argc, const char **argv, const char *prefix)\n> >          *  3) git checkout <something> [<paths>]\n> >          *\n> >          * including \"last branch\" syntax and DWIM-ery for names of\n> > -        * remote branches, erroring out for invalid or ambiguous cases.\n> > +        * remote branches, erring out for invalid or ambiguous cases.\n> \n> Didn't look through the entire patch, but this caught me eye: what's\n> wrong with \"erroring out\"?\nWell aspell did not know it so I thought that erring is more\nappropriate. Now it looks more murky, see\nhttp://english.stackexchange.com/questions/3059/is-errored-correct-usage\n\nI am ok with removing this correction.\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"},{"id":"223862","messageId":"20130720205620.GA3825@domone","threadId":"34501","inReplyTo":"20130720193905.GA3904@vauxhall.crustytoothpaste.net","subject":"American or British English?","fromName":"Ondřej Bílka","fromEmail":"neleai@seznam.cz","sentAt":"2013-07-20T20:56:20Z","receivedAt":"2013-07-20T20:56:20Z","isPatch":false,"sender":{"key":"neleai@seznam.cz","avatar":"https://avatars.githubusercontent.com/u/48067?v=4"},"body":"On Sat, Jul 20, 2013 at 07:39:06PM +0000, brian m. carlson wrote:\n> On Sat, Jul 20, 2013 at 09:13:12PM +0200, Ondřej Bílka wrote:\n> > A dictionary that I generated is following, patch is below.\n> > \n> >              alloted allocated\n> \n> \"allotted\" is a valid word, and I think it would work fine in the code.\n> It's probably what was intended, anyway.\n> \nOK, I am not native speaker so I sometimes choose simpler variant.\n\n> >            behaviour behavior\n> >            colourful colorful\n> >          initialised initialized\n> \n> I'm not sure whether git has a standard for which dialect of English is\n> to be used, but the three words on the left are considered correct in\n> most non-American dialects.  Characterizing them as \"typos\" isn't\n> strictly correct.  Perhaps \"Convert comments to American English\" is\n> more accurate?\n>\nYeah, on most projects I seen preference for consistently using American\nversions. How you decide is matter of preference.\n> -- \n> brian m. carlson / brian with sandals: Houston, Texas, US\n> +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only\n> OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187\n"},{"id":"223893","messageId":"7vy58zr1hc.fsf@alter.siamese.dyndns.org","threadId":"34501","inReplyTo":"20130720190707.GA30044@domone","subject":"Re: [PATCH 1/2] Fix generic typos in comments","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-07-21T22:29:19Z","receivedAt":"2013-07-21T22:29:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ondřej Bílka <neleai@seznam.cz> writes:\n\n> Hi, I wrote a tool that effectively fixes typos in comments and only in\n> comments.\n> It can be downloaded here:\n>\n> https://github.com/neleai/stylepp\n>\n> For typos you need identify them, write replacement dictionary and run\n> STYLEPP/script/stylepp_skeleton stylepp_fix_comment\n>\n> Here generic dictionary is used that was taken from wikipedia.\n> https://github.com/neleai/stylepp/blob/master/maintained/dictionary_wiki\n\nThanks, but sorry we cannot use this patch as-is (even if it were\nsigned-off and came with a proper log message).\n\nThe patch touches phrases somebody may find questionable at many\ndifferent levels.\n\n - \"lowercase ok\" and \"fall thru\" are quite acceptable colloquial\n   forms; if the person who DID the real work chose to write these\n   in such a way, I do not see a reason for us to update it to a\n   different preference.\n\n - There are outright typoes that noboddy would disagree with,\n   e.g. s/sinse/since/.\n"},{"id":"223894","messageId":"7vtxjnr1be.fsf@alter.siamese.dyndns.org","threadId":"34501","inReplyTo":"20130720191311.GB30044@domone","subject":"Re: [PATCH 2/2] Fix typos in comments","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-07-21T22:32:53Z","receivedAt":"2013-07-21T22:32:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ondřej Bílka <neleai@seznam.cz> writes:\n\n> A dictionary that I generated is following, patch is below.\n\nPlease use only \"obvious and clear typo nobody would disagree with\nthe fix\" entries and drop other entries in the \"I would prefer to\nuse a different phrasing or spelling\" category.  For example, as\nalready mentioned, \"alloted\" is a proper pp of a verb, so it falls\ninto the latter.\n\nThanks.\n"}]}