{"thread":{"id":"34484","subject":"[PATCH 0/1] incremental update against 'next' branch","startedAt":"2013-07-19T00:16:15Z","lastAt":"2013-07-19T00:16:16Z","messageCount":2,"participants":["Kyle J. McKay"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"223726","messageId":"3e0c11386c2e091f09c554bf0ba091d@f74d39fa044aa309eaea14b9f57fe79","threadId":"34484","inReplyTo":null,"subject":"[PATCH 0/1] incremental update against 'next' branch","fromName":"Kyle J. McKay","fromEmail":"mackyle@gmail.com","sentAt":"2013-07-19T00:16:15Z","receivedAt":"2013-07-19T00:16:15Z","isPatch":true,"sender":{"key":"mackyle@gmail.com","avatar":"https://avatars.githubusercontent.com/u/813346?v=4"},"body":"NOTE: This patch requires:\n\n  4e63dcc Git.pm: add new temp_is_locked function\n\nwhich is currently in next.\n\nVersions v2-v3 of the \"allow git-svn fetching to work using serf\" patch\nintroduced a bug when attempting to change the Git.pm _temp_cache function\nto use the new temp_is_locked function at the suggestion of a reviewer.\n\nThis patch reverts that change as the logic in _temp_cache isn't really\nconducive to using temp_is_locked because its tests are not exactly the\nsame as the ones in temp_is_locked.\n\nKyle J. McKay (1):\n  Git.pm: revert _temp_cache use of temp_is_locked\n\n perl/Git.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n-- \n1.8.3\n"},{"id":"223727","messageId":"7c02d1e993907797fab2731677a1367@f74d39fa044aa309eaea14b9f57fe79","threadId":"34484","inReplyTo":"3e0c11386c2e091f09c554bf0ba091d@f74d39fa044aa309eaea14b9f57fe79","subject":"[PATCH 1/1] Git.pm: revert _temp_cache use of temp_is_locked","fromName":"Kyle J. McKay","fromEmail":"mackyle@gmail.com","sentAt":"2013-07-19T00:16:16Z","receivedAt":"2013-07-19T00:16:16Z","isPatch":true,"sender":{"key":"mackyle@gmail.com","avatar":"https://avatars.githubusercontent.com/u/813346?v=4"},"body":"When the temp_is_locked function was introduced, there was\na desire to make _temp_cache use it.  Unfortunately due to the\nvarious tests and logic flow involved changing the _temp_cache\nfunction to use the new temp_is_locked function is problematic\nas _temp_cache needs a slightly different test than is provided\nby the temp_is_locked function.\n\nThis change reverts use of temp_is_locked in the _temp_cache\nfunction and restores the original code that existed there\nbefore the temp_is_locked function was added.\n\nSigned-off-by: Kyle J. McKay <mackyle@gmail.com>\n---\n perl/Git.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/perl/Git.pm b/perl/Git.pm\nindex 0ba15b9..204fdc6 100644\n--- a/perl/Git.pm\n+++ b/perl/Git.pm\n@@ -1277,7 +1277,7 @@ sub _temp_cache {\n \n \tmy $temp_fd = \\$TEMP_FILEMAP{$name};\n \tif (defined $$temp_fd and $$temp_fd->opened) {\n-\t\tif (temp_is_locked($name)) {\n+\t\tif ($TEMP_FILES{$$temp_fd}{locked}) {\n \t\t\tthrow Error::Simple(\"Temp file with moniker '\" .\n \t\t\t\t$name . \"' already in use\");\n \t\t}\n-- \n1.8.3\n"}]}