{"thread":{"id":"34454","subject":"[PATCH] t6131 - skip tests if on case-insensitive file system","startedAt":"2013-07-17T13:22:16Z","lastAt":"2013-07-17T19:47:44Z","messageCount":3,"participants":["Mark Levedahl","Duy Nguyen","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"223582","messageId":"1374067336-6545-1-git-send-email-mlevedahl@gmail.com","threadId":"34454","inReplyTo":null,"subject":"[PATCH] t6131 - skip tests if on case-insensitive file system","fromName":"Mark Levedahl","fromEmail":"mlevedahl@gmail.com","sentAt":"2013-07-17T13:22:16Z","receivedAt":"2013-07-17T13:22:16Z","isPatch":true,"sender":{"key":"mdl123@verizon.net","avatar":"https://avatars.githubusercontent.com/u/5302462?v=4"},"body":"This test fails on Cygwin where the default system configuration does not \nsupport case sensitivity (only case retention), so don't run the test on \nsuch systems. \n\nSigned-off-by: Mark Levedahl \n---\n t/t6131-pathspec-icase.sh | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh\nindex 3215eef..8d4a7fc 100755\n--- a/t/t6131-pathspec-icase.sh\n+++ b/t/t6131-pathspec-icase.sh\n@@ -3,6 +3,12 @@\n test_description='test case insensitive pathspec limiting'\n . ./test-lib.sh\n \n+if test_have_prereq CASE_INSENSITIVE_FS\n+then\n+\tskip_all='skipping case sensitive tests - case insensitive file system'\n+\ttest_done\n+fi\n+\n test_expect_success 'create commits with glob characters' '\n \ttest_commit bar bar &&\n \ttest_commit bAr bAr &&\n-- \n1.8.3.2.0.63\n"},{"id":"223584","messageId":"CACsJy8Ayyb7kTydXFxoeqNQgGemdUXXzAc3ZwEbT5dCuk_tkQA@mail.gmail.com","threadId":"34454","inReplyTo":"1374067336-6545-1-git-send-email-mlevedahl@gmail.com","subject":"Re: [PATCH] t6131 - skip tests if on case-insensitive file system","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2013-07-17T13:42:48Z","receivedAt":"2013-07-17T13:42:48Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Wed, Jul 17, 2013 at 8:22 PM, Mark Levedahl wrote:\n> This test fails on Cygwin where the default system configuration does not\n> support case sensitivity (only case retention), so don't run the test on\n> such systems.\n\nYeah. I knew this when I wrote this test but forgot to put the check\nin. Thanks. We can re-enable the test later, as it does not really\nneed case-insensitive filesystems.\n\n>\n> Signed-off-by: Mark Levedahl \n> ---\n> t/t6131-pathspec-icase.sh | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh\n> index 3215eef..8d4a7fc 100755\n> --- a/t/t6131-pathspec-icase.sh\n> +++ b/t/t6131-pathspec-icase.sh\n> @@ -3,6 +3,12 @@\n> test_description='test case insensitive pathspec limiting'\n> . ./test-lib.sh\n>\n> +if test_have_prereq CASE_INSENSITIVE_FS\n> +then\n> + skip_all='skipping case sensitive tests - case insensitive file system'\n> + test_done\n> +fi\n> +\n> test_expect_success 'create commits with glob characters' '\n> test_commit bar bar &&\n> test_commit bAr bAr &&\n> --\n> 1.8.3.2.0.63\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n--\nDuy\n"},{"id":"223603","messageId":"7vppuh55pb.fsf@alter.siamese.dyndns.org","threadId":"34454","inReplyTo":"CACsJy8Ayyb7kTydXFxoeqNQgGemdUXXzAc3ZwEbT5dCuk_tkQA@mail.gmail.com","subject":"Re: [PATCH] t6131 - skip tests if on case-insensitive file system","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-07-17T19:47:44Z","receivedAt":"2013-07-17T19:47:44Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Duy Nguyen writes:\n\n> On Wed, Jul 17, 2013 at 8:22 PM, Mark Levedahl wrote:\n>> This test fails on Cygwin where the default system configuration does not\n>> support case sensitivity (only case retention), so don't run the test on\n>> such systems.\n>\n> Yeah. I knew this when I wrote this test but forgot to put the check\n> in. Thanks. We can re-enable the test later, as it does not really\n> need case-insensitive filesystems.\n\nYeah, I tend to agree. You do not need to create case-colliding paths\nfor the purpose of :(icase) tests.\n\n>\n>>\n>> Signed-off-by: Mark Levedahl \n>> ---\n>> t/t6131-pathspec-icase.sh | 6 ++++++\n>> 1 file changed, 6 insertions(+)\n>>\n>> diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh\n>> index 3215eef..8d4a7fc 100755\n>> --- a/t/t6131-pathspec-icase.sh\n>> +++ b/t/t6131-pathspec-icase.sh\n>> @@ -3,6 +3,12 @@\n>> test_description='test case insensitive pathspec limiting'\n>> . ./test-lib.sh\n>>\n>> +if test_have_prereq CASE_INSENSITIVE_FS\n>> +then\n>> + skip_all='skipping case sensitive tests - case insensitive file system'\n>> + test_done\n>> +fi\n>> +\n>> test_expect_success 'create commits with glob characters' '\n>> test_commit bar bar &&\n>> test_commit bAr bAr &&\n>> --\n>> 1.8.3.2.0.63\n>>\n>> --\n>> To unsubscribe from this list: send the line \"unsubscribe git\" in\n>> the body of a message to majordomo@vger.kernel.org\n>> More majordomo info at http://vger.kernel.org/majordomo-info.html\n> --\n> Duy\n"}]}