{"thread":{"id":"34392","subject":"[PATCH] gitweb: Ensure OPML text fits inside its box.","startedAt":"2013-07-02T16:24:24Z","lastAt":"2013-08-05T11:36:54Z","messageCount":12,"participants":["Tony Finch","Jonathan Nieder","Jakub Narębski"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"223404","messageId":"E1UyevA-0003df-Jo@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"20130714234915.GB19057@google.com","subject":"[PATCH 3/4] gitweb: omit the repository owner when it is unset","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-07-02T16:24:24Z","receivedAt":"2013-07-02T16:24:24Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"On the repository summary page, leave the whole owner line out if\nthe repo does not have an owner, rather than displaying a labelled\nempty field..\n\nSigned-off-by: Tony Finch \n---\n gitweb/gitweb.perl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 8d69ada..c029b98 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -6463,7 +6463,7 @@ sub git_summary {\n \tprint \"
 
\\n\";\n \tprint \"\\n\" .\n \t \"\\n\";\n- unless ($omit_owner) {\n+ if ($owner and not $omit_owner) {\n \t print \"\\n\";\n }\n \tif (defined $cd{'rfc2822'}) {\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"222936","messageId":"E1Uwb6x-0002XI-Ah@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":null,"subject":"[PATCH] gitweb: Ensure OPML text fits inside its box.","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-07-09T16:43:42Z","receivedAt":"2013-07-09T16:43:42Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"The rss_logo CSS style has a fixed width which is too narrow for\nthe string \"OPML\". Replace the fixed width with horizontal padding\nso the text fits with nice margins.\n---\n\nFor before/after examples, see http://dotat.at/cgi/git (overflow)\nand https://git.csx.cam.ac.uk/x/ucs/ (padded).\n\n gitweb/static/gitweb.css | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\nindex cb86d2d..a869be1 100644\n--- a/gitweb/static/gitweb.css\n+++ b/gitweb/static/gitweb.css\n@@ -548,8 +548,7 @@ a.linenr {\n \n a.rss_logo {\n \tfloat: right;\n-\tpadding: 3px 0px;\n-\twidth: 35px;\n+\tpadding: 3px 5px;\n \tline-height: 10px;\n \tborder: 1px solid;\n \tborder-color: #fcc7a5 #7d3302 #3e1a01 #ff954e;\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"223402","messageId":"E1Uyev6-0003d1-Mg@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"20130714234915.GB19057@google.com","subject":"[PATCH 1/4] gitweb: Ensure OPML text fits inside its box.","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-07-09T16:43:42Z","receivedAt":"2013-07-09T16:43:42Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"The rss_logo CSS style has a fixed width which is too narrow for\nthe string \"OPML\". Replace the fixed width with horizontal padding\nso the text fits with nice margins.\n\nSigned-off-by: Tony Finch \n---\n gitweb/static/gitweb.css | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\nindex cb86d2d..a869be1 100644\n--- a/gitweb/static/gitweb.css\n+++ b/gitweb/static/gitweb.css\n@@ -548,8 +548,7 @@ a.linenr {\n \n a.rss_logo {\n \tfloat: right;\n-\tpadding: 3px 0px;\n-\twidth: 35px;\n+\tpadding: 3px 5px;\n \tline-height: 10px;\n \tborder: 1px solid;\n \tborder-color: #fcc7a5 #7d3302 #3e1a01 #ff954e;\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"222938","messageId":"E1UwbQw-0004dI-OK@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"E1Uwb6x-0002XI-Ah@hermes-2.csi.cam.ac.uk","subject":"[PATCH] gitweb: vertically centre contents of page footer","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-07-09T17:08:37Z","receivedAt":"2013-07-09T17:08:37Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"---\n gitweb/static/gitweb.css | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\nindex a869be1..3b4d833 100644\n--- a/gitweb/static/gitweb.css\n+++ b/gitweb/static/gitweb.css\n@@ -68,12 +68,13 @@ div.page_path {\n }\n \n div.page_footer {\n-\theight: 17px;\n+\theight: 22px;\n \tpadding: 4px 8px;\n \tbackground-color: #d9d8d1;\n }\n \n div.page_footer_text {\n+\tline-height: 22px;\n \tfloat: left;\n \tcolor: #555555;\n \tfont-style: italic;\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"223403","messageId":"E1Uyev8-0003dE-LM@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"20130714234915.GB19057@google.com","subject":"[PATCH 2/4] gitweb: vertically centre contents of page footer","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-07-09T17:08:37Z","receivedAt":"2013-07-09T17:08:37Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"Signed-off-by: Tony Finch \n---\n gitweb/static/gitweb.css | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/gitweb/static/gitweb.css b/gitweb/static/gitweb.css\nindex a869be1..3b4d833 100644\n--- a/gitweb/static/gitweb.css\n+++ b/gitweb/static/gitweb.css\n@@ -68,12 +68,13 @@ div.page_path {\n }\n \n div.page_footer {\n-\theight: 17px;\n+\theight: 22px;\n \tpadding: 4px 8px;\n \tbackground-color: #d9d8d1;\n }\n \n div.page_footer_text {\n+\tline-height: 22px;\n \tfloat: left;\n \tcolor: #555555;\n \tfont-style: italic;\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"223405","messageId":"E1UyevC-0003du-K4@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"20130714234915.GB19057@google.com","subject":"[PATCH 4/4] gitweb: make search help link less ugly","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-07-09T17:15:45Z","receivedAt":"2013-07-09T17:15:45Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"The search help link was a superscript question mark right next to\na drop-down menu, which looks misaligned and is a cramped and\nawkward click target. Remove the superscript tags and add some\nspacing to fix these nits. Add a title attribute to provide an\nexplanatory mouseover.\n\nSigned-off-by: Tony Finch \n---\n gitweb/gitweb.perl | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex c029b98..874c948 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4029,9 +4029,9 @@ sub print_search_form {\n \t $cgi->input({-name=>\"a\", -value=>\"search\", -type=>\"hidden\"}) . \"\\n\" .\n \t $cgi->input({-name=>\"h\", -value=>$search_hash, -type=>\"hidden\"}) . \"\\n\" .\n \t $cgi->popup_menu(-name => 'st', -default => 'commit',\n-\t -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .\n-\t $cgi->sup($cgi->a({-href => href(action=>\"search_help\")}, \"?\")) .\n-\t \" search:\\n\",\n+\t\t\t -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .\n+\t \" \" . $cgi->a({-href => href(action=>\"search_help\"),\n+\t\t\t -title => \"search help\" }, \"?\") . \" search:\\n\",\n \t $cgi->textfield(-name => \"s\", -value => $searchtext, -override => 1) . \"\\n\" .\n \t \"\" .\n \t $cgi->checkbox(-name => 'sr', -value => 1, -label => 're',\n-- \n1.8.3.1.605.g85318f5\n"},{"id":"223362","messageId":"20130714234915.GB19057@google.com","threadId":"34392","inReplyTo":"E1Uwb6x-0002XI-Ah@hermes-2.csi.cam.ac.uk","subject":"Re: [PATCH] gitweb: Ensure OPML text fits inside its box.","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-07-14T23:49:15Z","receivedAt":"2013-07-14T23:49:15Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Tony Finch wrote:\n\n> The rss_logo CSS style has a fixed width which is too narrow for\n> the string \"OPML\". Replace the fixed width with horizontal padding\n> so the text fits with nice margins.\n\nSounds sensible. Can we have your sign-off? (Likewise for the next\npatch.)\n\nThanks,\nJonathan\n"},{"id":"223401","messageId":"alpine.LSU.2.00.1307151013460.24554@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"20130714234915.GB19057@google.com","subject":"Re: [PATCH] gitweb: Ensure OPML text fits inside its box.","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-07-15T09:15:31Z","receivedAt":"2013-07-15T09:15:31Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"Jonathan Nieder wrote:\n>\n> Sounds sensible. Can we have your sign-off? (Likewise for the next\n> patch.)\n\nDoh! Thanks for looking at the patches. I'll post revised versions, plus a\ncouple more tweaks.\n\nTony.\n-- \nf.anthony.n.finch http://dotat.at/\nForties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.\nRough, becoming slight or moderate. Showers, rain at first. Moderate or good,\noccasionally poor at first.\n"},{"id":"224542","messageId":"CANQwDwdcCUNBZH=YbSjwTZx6vau_cs89EH9FV8OUQcdNzDE5DQ@mail.gmail.com","threadId":"34392","inReplyTo":"E1Uyeth-0003TF-Kx@hermes-2.csi.cam.ac.uk","subject":"Re: [PATCH 4/4] gitweb: make search help link less ugly","fromName":"Jakub Narębski","fromEmail":"jnareb@gmail.com","sentAt":"2013-08-03T21:37:39Z","receivedAt":"2013-08-03T21:37:39Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Tue, Jul 9, 2013 at 7:15 PM, Tony Finch wrote:\n\n> The search help link was a superscript question mark right next to\n> a drop-down menu, which looks misaligned\n\nI think the idea was to simulate footnote explaining search terms\n(I think, I am not the author of this feature)...\n\n> and is a cramped and\n> awkward click target. Remove the superscript tags and add some\n> spacing to fix these nits. Add a title attribute to provide an\n> explanatory mouseover.\n\n... but I agree that it makes for poor UI.\n\n>\n> Signed-off-by: Tony Finch \n> ---\n> gitweb/gitweb.perl | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index c029b98..874c948 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -4029,9 +4029,9 @@ sub print_search_form {\n> $cgi->input({-name=>\"a\", -value=>\"search\", -type=>\"hidden\"}) . \"\\n\" .\n> $cgi->input({-name=>\"h\", -value=>$search_hash, -type=>\"hidden\"}) . \"\\n\" .\n> $cgi->popup_menu(-name => 'st', -default => 'commit',\n> - -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .\n> - $cgi->sup($cgi->a({-href => href(action=>\"search_help\")}, \"?\")) .\n> - \" search:\\n\",\n> + -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .\n\nNb. what changed here (in line above)?\n\n> + \" \" . $cgi->a({-href => href(action=>\"search_help\"),\n> + -title => \"search help\" }, \"?\") . \" search:\\n\",\n> $cgi->textfield(-name => \"s\", -value => $searchtext, -override => 1) . \"\\n\" .\n> \"\" .\n> $cgi->checkbox(-name => 'sr', -value => 1, -label => 're',\n> --\n> 1.8.3.1.605.g85318f5\n"},{"id":"224543","messageId":"CANQwDwdA5VnywJmoNpCX7s=hH7tmUDUmRuak12W7BXOQtqRoQw@mail.gmail.com","threadId":"34392","inReplyTo":"E1Uyete-0003Sv-OI@hermes-2.csi.cam.ac.uk","subject":"Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset","fromName":"Jakub Narębski","fromEmail":"jnareb@gmail.com","sentAt":"2013-08-03T21:40:11Z","receivedAt":"2013-08-03T21:40:11Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch wrote:\n\n> On the repository summary page, leave the whole owner line out if\n> the repo does not have an owner, rather than displaying a labelled\n> empty field..\n\nNote that if $omit_owner is true, whole _column_ is skipped.\n\nIs removing cell (instead of leaving it empty) and relying on browser\ntreating nonexistent cell correctly a good idea, that I do not know.\nDoes it looks better? Does it looks better in all web browsers?\n\n> Signed-off-by: Tony Finch \n> ---\n> gitweb/gitweb.perl | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index 8d69ada..c029b98 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -6463,7 +6463,7 @@ sub git_summary {\n> print \"
 
\\n\";\n> print \"
description\" . esc_html($descr) . \"
owner\" . esc_html($owner) . \"
\\n\" .\n> \"\\n\";\n> - unless ($omit_owner) {\n> + if ($owner and not $omit_owner) {\n> print \"\\n\";\n> }\n> if (defined $cd{'rfc2822'}) {\n> --\n> 1.8.3.1.605.g85318f5\n>\n\n\n\n-- \nJakub Narebski\n"},{"id":"224573","messageId":"alpine.LSU.2.00.1308051219110.6019@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"CANQwDwdcCUNBZH=YbSjwTZx6vau_cs89EH9FV8OUQcdNzDE5DQ@mail.gmail.com","subject":"Re: [PATCH 4/4] gitweb: make search help link less ugly","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-05T11:19:58Z","receivedAt":"2013-08-05T11:19:58Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"Jakub Narębski wrote:\n\n> > - -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .\n> > + -values => ['commit', 'grep', 'author', 'committer', 'pickaxe']) .\n>\n> Nb. what changed here (in line above)?\n\nWhoops, tab damage. I will re-roll. Thanks for the review.\n\nTony.\n-- \nf.anthony.n.finch http://dotat.at/\nForties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.\nRough, becoming slight or moderate. Showers, rain at first. Moderate or good,\noccasionally poor at first."},{"id":"224574","messageId":"alpine.LSU.2.00.1308051220170.6019@hermes-2.csi.cam.ac.uk","threadId":"34392","inReplyTo":"CANQwDwdA5VnywJmoNpCX7s=hH7tmUDUmRuak12W7BXOQtqRoQw@mail.gmail.com","subject":"Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset","fromName":"Tony Finch","fromEmail":"dot@dotat.at","sentAt":"2013-08-05T11:36:54Z","receivedAt":"2013-08-05T11:36:54Z","isPatch":true,"sender":{"key":"dot@dotat.at","avatar":"https://avatars.githubusercontent.com/u/68429?v=4"},"body":"Jakub Narębski wrote:\n> On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch wrote:\n>\n> > On the repository summary page, leave the whole owner line out if\n> > the repo does not have an owner, rather than displaying a labelled\n> > empty field..\n>\n> Note that if $omit_owner is true, whole _column_ is skipped.\n\nThere are two places where the owner is displayed: on the list of\nprojects, and on each project's summary page. This change affects the\nsummary page (where it removes a row, not a column) and it leaves the\nprojects list alone. I'll make that clearer in the commit message (and fix\nthe extraneous dot).\n\nTony.\n-- \nf.anthony.n.finch http://dotat.at/\nForties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first.\nRough, becoming slight or moderate. Showers, rain at first. Moderate or good,\noccasionally poor at first."}]}
description\" . esc_html($descr) . \"
owner\" . esc_html($owner) . \"