{"thread":{"id":"34350","subject":"[PATCH] documentation: add git transport security notice","startedAt":"2013-07-05T08:41:26Z","lastAt":"2013-07-07T00:50:34Z","messageCount":2,"participants":["Fraser Tweedale","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"222609","messageId":"1373013686-2137-1-git-send-email-frase@frase.id.au","threadId":"34350","inReplyTo":null,"subject":"[PATCH] documentation: add git transport security notice","fromName":"Fraser Tweedale","fromEmail":"frase@frase.id.au","sentAt":"2013-07-05T08:41:26Z","receivedAt":"2013-07-05T08:41:26Z","isPatch":true,"sender":{"key":"frase@frase.id.au","avatar":"https://avatars.githubusercontent.com/u/2331938?v=4"},"body":"The fact that the git transport does not do any authentication is\neasily overlooked.  For example, DNS poisoning may result in\nfetching from somewhere that was not intended.\n\nAdd a brief security notice to the \"GIT URLS\" section of the\ndocumentation stating that the git transport should be used with\ncaution on unsecured networks.\n\nSigned-off-by: Fraser Tweedale <frase@frase.id.au>\n---\n Documentation/urls.txt | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/Documentation/urls.txt b/Documentation/urls.txt\nindex 60ba300..9c8f524 100644\n--- a/Documentation/urls.txt\n+++ b/Documentation/urls.txt\n@@ -11,6 +11,9 @@ and ftps can be used for fetching and rsync can be used for fetching\n and pushing, but these are inefficient and deprecated; do not use\n them).\n \n+The git transport does not do any authentication and should be used\n+with caution on unsecured networks.\n+\n The following syntaxes may be used with them:\n \n - ssh://{startsb}user@{endsb}host.xz{startsb}:port{endsb}/path/to/repo.git/\n-- \n1.8.3.1\n"},{"id":"222681","messageId":"20130707005034.GH30132@google.com","threadId":"34350","inReplyTo":"1373013686-2137-1-git-send-email-frase@frase.id.au","subject":"Re: [PATCH] documentation: add git transport security notice","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-07-07T00:50:34Z","receivedAt":"2013-07-07T00:50:34Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nFraser Tweedale wrote:\n\n> --- a/Documentation/urls.txt\n> +++ b/Documentation/urls.txt\n> @@ -11,6 +11,9 @@ and ftps can be used for fetching and rsync can be used for fetching\n>  and pushing, but these are inefficient and deprecated; do not use\n>  them).\n>  \n> +The git transport does not do any authentication and should be used\n> +with caution on unsecured networks.\n\nHow about the something like the following?  I'm starting to think it\nwould make more sense to add a SECURITY section to git-clone(1),\nthough.\n\n-- >8 --\nSubject: doc: clarify git:// transport security notice\n\nThe recently added warning about the git protocol's lack of\nauthentication does not make it clear that the protocol lacks both\nclient and server authentication.  The lack of non IP-based client\nauth is obvious (when does user enter her credentials?), while the\nlack of authentication of the server is less so, so emphasize it.\n\nPut the warning in context by making an analogy to HTTP's security\nproperties as compared to HTTPS.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nThanks,\nJonathan\n\ndiff --git a/Documentation/urls.txt b/Documentation/urls.txt\nindex 9ccb246..bd0058f 100644\n--- a/Documentation/urls.txt\n+++ b/Documentation/urls.txt\n@@ -11,8 +11,8 @@ and ftps can be used for fetching and rsync can be used for fetching\n and pushing, but these are inefficient and deprecated; do not use\n them).\n \n-The native transport (i.e. git:// URL) does no authentication and\n-should be used with caution on unsecured networks.\n+Like HTTP, the native protocol (used for git:// URLs) does no server\n+authentication and should be used with caution on unsecured networks.\n \n The following syntaxes may be used with them:\n \n"}]}