{"thread":{"id":"34333","subject":"[PATCH] git-remote-mediawiki: un-brace file handles in binmode calls","startedAt":"2013-07-03T09:14:19Z","lastAt":"2013-07-03T19:10:32Z","messageCount":2,"participants":["Matthieu Moy","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"222447","messageId":"1372842859-16598-1-git-send-email-Matthieu.Moy@imag.fr","threadId":"34333","inReplyTo":null,"subject":"[PATCH] git-remote-mediawiki: un-brace file handles in binmode calls","fromName":"Matthieu Moy","fromEmail":"matthieu.moy@imag.fr","sentAt":"2013-07-03T09:14:19Z","receivedAt":"2013-07-03T09:14:19Z","isPatch":true,"sender":{"key":"git@matthieu-moy.fr","avatar":"https://avatars.githubusercontent.com/u/14709?v=4"},"body":"Commit e83d36b66fc turned \"print STDOUT\" into \"print {*STDOUT}\", as\nsuggested by perlcritic. Unfortunately, it also changed two \"binmode\nSTDOUT\" calls the same way, which does not work and yield a \"Not a GLOB\nreference\" error.\n\nSigned-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>\n---\n contrib/mw-to-git/git-remote-mediawiki.perl | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl\nindex e40c034..f8d7d2c 100755\n--- a/contrib/mw-to-git/git-remote-mediawiki.perl\n+++ b/contrib/mw-to-git/git-remote-mediawiki.perl\n@@ -576,9 +576,9 @@ sub literal_data_raw {\n \tmy ($content) = @_;\n \t# Avoid confusion between size in bytes and in characters\n \tutf8::downgrade($content);\n-\tbinmode {*STDOUT}, ':raw';\n+\tbinmode STDOUT, ':raw';\n \tprint {*STDOUT} 'data ', bytes::length($content), \"\\n\", $content;\n-\tbinmode {*STDOUT}, ':encoding(UTF-8)';\n+\tbinmode STDOUT, ':encoding(UTF-8)';\n \treturn;\n }\n \n-- \n1.8.3.1.495.g13f33cf.dirty\n"},{"id":"222484","messageId":"7v8v1nfoif.fsf@alter.siamese.dyndns.org","threadId":"34333","inReplyTo":"1372842859-16598-1-git-send-email-Matthieu.Moy@imag.fr","subject":"Re: [PATCH] git-remote-mediawiki: un-brace file handles in binmode calls","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-07-03T19:10:32Z","receivedAt":"2013-07-03T19:10:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks.\n"}]}