{"thread":{"id":"34306","subject":"[PATCH] perf-lib: fix start/stop of perf tests","startedAt":"2013-06-29T13:38:39Z","lastAt":"2013-06-30T01:46:04Z","messageCount":3,"participants":["Thomas Gummerer","Thomas Rast","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"222228","messageId":"1372513119-27384-1-git-send-email-t.gummerer@gmail.com","threadId":"34306","inReplyTo":null,"subject":"[PATCH] perf-lib: fix start/stop of perf tests","fromName":"Thomas Gummerer","fromEmail":"t.gummerer@gmail.com","sentAt":"2013-06-29T13:38:39Z","receivedAt":"2013-06-29T13:38:39Z","isPatch":true,"sender":{"key":"t.gummerer@gmail.com","avatar":"https://avatars.githubusercontent.com/u/191004?v=4"},"body":"ae75342 test-lib: rearrange start/end of test_expect_* and test_skip\nchanged the way tests are started/stopped, but did not update the perf\ntests.  They were therefore giving the wrong output, because of the\nwrong test count.  Fix this by starting and stopping the tests\ncorrectly.\n\nSigned-off-by: Thomas Gummerer <t.gummerer@gmail.com>\n---\n t/perf/perf-lib.sh | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh\nindex a816fbc..c61d535 100644\n--- a/t/perf/perf-lib.sh\n+++ b/t/perf/perf-lib.sh\n@@ -150,6 +150,7 @@ exit $ret' >&3 2>&4\n \n \n test_perf () {\n+\ttest_start_\n \ttest \"$#\" = 3 && { test_prereq=$1; shift; } || test_prereq=\n \ttest \"$#\" = 2 ||\n \terror \"bug in the test script: not 2 or 3 parameters to test-expect-success\"\n@@ -187,7 +188,7 @@ test_perf () {\n \t\tbase=\"$perf_results_dir\"/\"$perf_results_prefix$(basename \"$0\" .sh)\".\"$test_count\"\n \t\t\"$TEST_DIRECTORY\"/perf/min_time.perl test_time.* >\"$base\".times\n \tfi\n-\techo >&3 \"\"\n+\ttest_finish_\n }\n \n # We extend test_done to print timings at the end (./run disables this\n-- \n1.8.3.453.g1dfc63d\n"},{"id":"222229","messageId":"87ppv4hnbt.fsf@linux-k42r.v.cablecom.net","threadId":"34306","inReplyTo":"1372513119-27384-1-git-send-email-t.gummerer@gmail.com","subject":"Re: [PATCH] perf-lib: fix start/stop of perf tests","fromName":"Thomas Rast","fromEmail":"trast@inf.ethz.ch","sentAt":"2013-06-29T16:51:50Z","receivedAt":"2013-06-29T16:51:50Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Thomas Gummerer <t.gummerer@gmail.com> writes:\n\n> ae75342 test-lib: rearrange start/end of test_expect_* and test_skip\n> changed the way tests are started/stopped, but did not update the perf\n> tests.  They were therefore giving the wrong output, because of the\n> wrong test count.  Fix this by starting and stopping the tests\n> correctly.\n>\n> Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>\n\nDoh!  Thanks for catching this.\n\n>  t/perf/perf-lib.sh | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/t/perf/perf-lib.sh b/t/perf/perf-lib.sh\n> index a816fbc..c61d535 100644\n> --- a/t/perf/perf-lib.sh\n> +++ b/t/perf/perf-lib.sh\n> @@ -150,6 +150,7 @@ exit $ret' >&3 2>&4\n>  \n>  \n>  test_perf () {\n> +\ttest_start_\n>  \ttest \"$#\" = 3 && { test_prereq=$1; shift; } || test_prereq=\n>  \ttest \"$#\" = 2 ||\n>  \terror \"bug in the test script: not 2 or 3 parameters to test-expect-success\"\n> @@ -187,7 +188,7 @@ test_perf () {\n>  \t\tbase=\"$perf_results_dir\"/\"$perf_results_prefix$(basename \"$0\" .sh)\".\"$test_count\"\n>  \t\t\"$TEST_DIRECTORY\"/perf/min_time.perl test_time.* >\"$base\".times\n>  \tfi\n> -\techo >&3 \"\"\n> +\ttest_finish_\n>  }\n>  \n>  # We extend test_done to print timings at the end (./run disables this\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"222235","messageId":"7vbo6ol6ar.fsf@alter.siamese.dyndns.org","threadId":"34306","inReplyTo":"87ppv4hnbt.fsf@linux-k42r.v.cablecom.net","subject":"Re: [PATCH] perf-lib: fix start/stop of perf tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-06-30T01:46:04Z","receivedAt":"2013-06-30T01:46:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thanks, both.  Will queue.\n"}]}