{"thread":{"id":"34300","subject":"[PATCH] fixup-builtins: remove unused cruft","startedAt":"2013-06-28T15:46:19Z","lastAt":"2013-07-03T10:27:05Z","messageCount":5,"participants":["Ramkumar Ramachandra","Jeff King","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"222185","messageId":"1372434379-24085-1-git-send-email-artagnon@gmail.com","threadId":"34300","inReplyTo":null,"subject":"[PATCH] fixup-builtins: remove unused cruft","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-06-28T15:46:19Z","receivedAt":"2013-06-28T15:46:19Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"The fixup-builtins script is only used by an unused remove-dashes target\nin the Makefile: remove that along with the script.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n Makefile       |  3 ---\n fixup-builtins | 16 ----------------\n 2 files changed, 19 deletions(-)\n delete mode 100755 fixup-builtins\n\ndiff --git a/Makefile b/Makefile\nindex e158376..6b0ddf8 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2302,9 +2302,6 @@ check: common-cmds.h\n \t\texit 1; \\\n \tfi\n \n-remove-dashes:\n-\t./fixup-builtins $(BUILT_INS) $(PROGRAMS) $(SCRIPTS)\n-\n ### Installation rules\n \n ifneq ($(filter /%,$(firstword $(template_dir))),)\ndiff --git a/fixup-builtins b/fixup-builtins\ndeleted file mode 100755\nindex 63dfa4c..0000000\n--- a/fixup-builtins\n+++ /dev/null\n@@ -1,16 +0,0 @@\n-#!/bin/sh\n-while [ \"$1\" ]\n-do\n-\tif [ \"$1\" != \"git-sh-setup\" -a \"$1\" != \"git-parse-remote\" -a \"$1\" != \"git-svn\" ]; then\n-\t\told=\"$1\"\n-\t\tnew=$(echo \"$1\" | sed 's/git-/git /')\n-\t\techo \"Converting '$old' to '$new'\"\n-\t\tsed -i \"s/\\\\<$old\\\\>/$new/g\" $(git ls-files '*.sh')\n-\tfi\n-\tshift\n-done\n-\n-sed -i 's/git merge-one-file/git-merge-one-file/g\n-s/git rebase-todo/git-rebase-todo/g' $(git ls-files '*.sh')\n-git update-index --refresh >& /dev/null\n-exit 0\n-- \n1.8.3.1.643.gebeea52.dirty\n"},{"id":"222189","messageId":"20130628164545.GB9127@sigill.intra.peff.net","threadId":"34300","inReplyTo":"1372434379-24085-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH] fixup-builtins: remove unused cruft","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-06-28T16:45:45Z","receivedAt":"2013-06-28T16:45:45Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, Jun 28, 2013 at 09:16:19PM +0530, Ramkumar Ramachandra wrote:\n\n> The fixup-builtins script is only used by an unused remove-dashes target\n> in the Makefile: remove that along with the script.\n\nI am not sure of this justification. If you read the commit message from\n36e5e70, which introduced the target, it was meant to be run manually as\npart of migrating away from dashed forms.\n\nRunning it today does still uncover some places that could be tweaked.\nHowever, I note that it also has a lot of false positives (e.g.,\nremoving dashes from places that are not commands, like filenames or\nconfig options). It also produces crappy output for documentation (if we\ndo want to change dashed mentions, we would probably want to switch\ngit-foo to `git foo` with some kind of quoting to make it more obvious).\n\nSo I think it is probably a good idea to remove it, but the\njustification is not \"this is unused cruft\", but more like:\n\n  This script was added in 36e5e70 (Start deprecating \"git-command\" in\n  favor of \"git command\", 2007-06-30) with the intent of aiding the\n  transition away from dashed forms. However, nobody is really working\n  on that transition, and even if they did, this tool will probably lead\n  them in the wrong direction, as it produces a large number of\n  questionable changes.\n\n-Peff\n"},{"id":"222195","messageId":"CALkWK0k39d3=Z2czdwdiwXmpNNYiUHUSvZubCqbfP5QFCebqTQ@mail.gmail.com","threadId":"34300","inReplyTo":"20130628164545.GB9127@sigill.intra.peff.net","subject":"Re: [PATCH] fixup-builtins: remove unused cruft","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-06-28T17:27:17Z","receivedAt":"2013-06-28T17:27:17Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Jeff King wrote:\n>   This script was added in 36e5e70 (Start deprecating \"git-command\" in\n>   favor of \"git command\", 2007-06-30) with the intent of aiding the\n>   transition away from dashed forms. However, nobody is really working\n>   on that transition, and even if they did, this tool will probably lead\n>   them in the wrong direction, as it produces a large number of\n>   questionable changes.\n\nSure, that sounds good.\n"},{"id":"222202","messageId":"7vfvw2nk8r.fsf@alter.siamese.dyndns.org","threadId":"34300","inReplyTo":"20130628164545.GB9127@sigill.intra.peff.net","subject":"Re: [PATCH] fixup-builtins: remove unused cruft","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-06-28T18:49:40Z","receivedAt":"2013-06-28T18:49:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King <peff@peff.net> writes:\n\n> So I think it is probably a good idea to remove it, but the\n> justification is not \"this is unused cruft\", but more like:\n>\n>   This script was added in 36e5e70 (Start deprecating \"git-command\" in\n>   favor of \"git command\", 2007-06-30) with the intent of aiding the\n>   transition away from dashed forms. However, nobody is really working\n>   on that transition, and even if they did, this tool will probably lead\n>   them in the wrong direction, as it produces a large number of\n>   questionable changes.\n\nIt is not \"nobody is working on\", but \"it has already been used to\nhelp the transision and served its purpose, and is no longer is very\nuseful for follow-up work because the majority of remaining matches\nit finds are false positives.\"\n"},{"id":"222458","messageId":"CALkWK0=zwYYay7AA1mvcqKsEzs-iQhdBfnR2GeisJ6ZT8Wvrug@mail.gmail.com","threadId":"34300","inReplyTo":"7vfvw2nk8r.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] fixup-builtins: remove unused cruft","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-07-03T10:27:05Z","receivedAt":"2013-07-03T10:27:05Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Junio C Hamano wrote:\n> It is not \"nobody is working on\", but \"it has already been used to\n> help the transision and served its purpose, and is no longer is very\n> useful for follow-up work because the majority of remaining matches\n> it finds are false positives.\"\n\nPlease amend the commit message appropriately (you clearly know best) and queue.\n"}]}