{"thread":{"id":"34238","subject":"[PATCH] web--browse: support /usr/bin/cygstart on Cygwin","startedAt":"2013-06-21T07:24:32Z","lastAt":"2013-07-25T15:59:36Z","messageCount":4,"participants":["Yaakov (Cygwin/X)","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"221565","messageId":"1371799472-11564-1-git-send-email-yselkowitz@users.sourceforge.net","threadId":"34238","inReplyTo":null,"subject":"[PATCH] web--browse: support /usr/bin/cygstart on Cygwin","fromName":"Yaakov (Cygwin/X)","fromEmail":"yselkowitz@users.sourceforge.net","sentAt":"2013-06-21T07:24:32Z","receivedAt":"2013-06-21T07:24:32Z","isPatch":true,"sender":{"key":"yselkowitz@users.sourceforge.net","avatar":null},"body":"From: Yaakov Selkowitz \n\nWhile both GUI and console Cygwin browsers do exist, anecdotal evidence\nsuggests most users rely on their native Windows browser. cygstart,\nwhich is a long-standing part of the base Cygwin installation, will\ncause the page to be opened in the default Windows browser (the one\nregistered to open .html files).\n\nSigned-off-by: Yaakov Selkowitz \n---\n Documentation/git-web--browse.txt | 1 +\n git-web--browse.sh | 9 +++++++--\n 2 files changed, 8 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-web--browse.txt b/Documentation/git-web--browse.txt\nindex ba79cb4..5aec4ec 100644\n--- a/Documentation/git-web--browse.txt\n+++ b/Documentation/git-web--browse.txt\n@@ -34,6 +34,7 @@ The following browsers (or commands) are currently supported:\n * dillo\n * open (this is the default under Mac OS X GUI)\n * start (this is the default under MinGW)\n+* cygstart (this is the default under Cygwin)\n \n Custom commands may also be specified.\n \ndiff --git a/git-web--browse.sh b/git-web--browse.sh\nindex 9f44679..9fc1dba 100755\n--- a/git-web--browse.sh\n+++ b/git-web--browse.sh\n@@ -33,7 +33,8 @@ valid_tool() {\n \tcase \"$1\" in\n \tfirefox | iceweasel | seamonkey | iceape | \\\n \tchrome | google-chrome | chromium | chromium-browser |\\\n-\tkonqueror | opera | w3m | elinks | links | lynx | dillo | open | start)\n+\tkonqueror | opera | w3m | elinks | links | lynx | dillo | open |\\\n+\tstart | cygstart)\n \t\t;; # happy\n \t*)\n \t\tvalid_custom_tool \"$1\" || return 1\n@@ -127,6 +128,10 @@ if test -z \"$browser\" ; then\n \tif test -x /bin/start; then\n \t\tbrowser_candidates=\"start $browser_candidates\"\n \tfi\n+\t# /usr/bin/cygstart indicates Cygwin\n+\tif test -x /usr/bin/cygstart; then\n+\t\tbrowser_candidates=\"cygstart $browser_candidates\"\n+\tfi\n \n \tfor i in $browser_candidates; do\n \t\tinit_browser_path $i\n@@ -174,7 +179,7 @@ konqueror)\n \t\t;;\n \tesac\n \t;;\n-w3m|elinks|links|lynx|open)\n+w3m|elinks|links|lynx|open|cygstart)\n \t\"$browser_path\" \"$@\"\n \t;;\n start)\n-- \n1.8.3\n"},{"id":"221604","messageId":"7vbo6zo3d1.fsf@alter.siamese.dyndns.org","threadId":"34238","inReplyTo":"1371799472-11564-1-git-send-email-yselkowitz@users.sourceforge.net","subject":"Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-06-21T16:06:18Z","receivedAt":"2013-06-21T16:06:18Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Yaakov (Cygwin/X)\" writes:\n\n> From: Yaakov Selkowitz \n>\n> While both GUI and console Cygwin browsers do exist, anecdotal evidence\n> suggests most users rely on their native Windows browser. cygstart,\n> which is a long-standing part of the base Cygwin installation, will\n> cause the page to be opened in the default Windows browser (the one\n> registered to open .html files).\n>\n> Signed-off-by: Yaakov Selkowitz \n\nWill queue and wait for somebody from Cygwin land to comment.\n\nThanks.\n"},{"id":"224008","messageId":"51EF0391.5070502@users.sourceforge.net","threadId":"34238","inReplyTo":"7vbo6zo3d1.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin","fromName":"Yaakov (Cygwin/X)","fromEmail":"yselkowitz@users.sourceforge.net","sentAt":"2013-07-23T22:28:33Z","receivedAt":"2013-07-23T22:28:33Z","isPatch":true,"sender":{"key":"yselkowitz@users.sourceforge.net","avatar":null},"body":"On 2013-06-21 11:06, Junio C Hamano wrote:\n>> From: Yaakov Selkowitz \n>>\n>> While both GUI and console Cygwin browsers do exist, anecdotal evidence\n>> suggests most users rely on their native Windows browser. cygstart,\n>> which is a long-standing part of the base Cygwin installation, will\n>> cause the page to be opened in the default Windows browser (the one\n>> registered to open .html files).\n>>\n>> Signed-off-by: Yaakov Selkowitz \n>\n> Will queue and wait for somebody from Cygwin land to comment.\n\nPing? Is there someone in particular whose input you are looking for?\n\n\nYaakov\n"},{"id":"224083","messageId":"7vtxji4olz.fsf@alter.siamese.dyndns.org","threadId":"34238","inReplyTo":"51EF0391.5070502@users.sourceforge.net","subject":"Re: [PATCH] web--browse: support /usr/bin/cygstart on Cygwin","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-07-25T15:59:36Z","receivedAt":"2013-07-25T15:59:36Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Yaakov (Cygwin/X)\" writes:\n\n>>> Signed-off-by: Yaakov Selkowitz \n>>\n>> Will queue and wait for somebody from Cygwin land to comment.\n>\n> Ping? Is there someone in particular whose input you are looking for?\n\nNobody in particular. Nobody complained nor reported breakages, so\nwe are good to go ;-)\n\nThanks.\n"}]}