{"thread":{"id":"34225","subject":"[PATCH] send-email: Fix documentation of --signed-off-by-cc option","startedAt":"2013-06-20T08:26:51Z","lastAt":"2013-06-20T16:45:53Z","messageCount":2,"participants":["Namhyung Kim","Ramkumar Ramachandra"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"221433","messageId":"1371716811-12043-1-git-send-email-namhyung@gmail.com","threadId":"34225","inReplyTo":null,"subject":"[PATCH] send-email: Fix documentation of --signed-off-by-cc option","fromName":"Namhyung Kim","fromEmail":"namhyung@gmail.com","sentAt":"2013-06-20T08:26:51Z","receivedAt":"2013-06-20T08:26:51Z","isPatch":true,"sender":{"key":"namhyung@gmail.com","avatar":"https://avatars.githubusercontent.com/u/48503?v=4"},"body":"From: Namhyung Kim <namhyung.kim@lge.com>\n\nThe man page says it'll control the Cc: lines being added also,\nbut this is not true.\n\nReported-by: Minchan Kim <minchan@kernel.org>\nSigned-off-by: Namhyung Kim <namhyung.kim@lge.com>\n---\n Documentation/git-send-email.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\nindex 40a9a9a..5694d98 100644\n--- a/Documentation/git-send-email.txt\n+++ b/Documentation/git-send-email.txt\n@@ -238,7 +238,7 @@ Automating\n \tthe value of 'sendemail.identity'.\n \n --[no-]signed-off-by-cc::\n-\tIf this is set, add emails found in Signed-off-by: or Cc: lines to the\n+\tIf this is set, add emails found in Signed-off-by: lines to the\n \tcc list. Default is the value of 'sendemail.signedoffbycc' configuration\n \tvalue; if that is unspecified, default to --signed-off-by-cc.\n \n-- \n1.7.11.7\n"},{"id":"221494","messageId":"CALkWK0n+CMV64VxLMV6AqVxwpC2nyk=vh=0F+ESvKG2Mn9G7oA@mail.gmail.com","threadId":"34225","inReplyTo":"1371716811-12043-1-git-send-email-namhyung@gmail.com","subject":"Re: [PATCH] send-email: Fix documentation of --signed-off-by-cc option","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-06-20T16:45:53Z","receivedAt":"2013-06-20T16:45:53Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Namhyung Kim wrote:\n> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt\n> index 40a9a9a..5694d98 100644\n> --- a/Documentation/git-send-email.txt\n> +++ b/Documentation/git-send-email.txt\n> @@ -238,7 +238,7 @@ Automating\n>         the value of 'sendemail.identity'.\n>\n>  --[no-]signed-off-by-cc::\n> -       If this is set, add emails found in Signed-off-by: or Cc: lines to the\n> +       If this is set, add emails found in Signed-off-by: lines to the\n>         cc list. Default is the value of 'sendemail.signedoffbycc' configuration\n>         value; if that is unspecified, default to --signed-off-by-cc.\n\nCorrect, but I'd urge you to step back and look at all the options.\nCc lines in the body (called bodycc) are parsed: see\ngit-send-email.perl:1361.  By default, everyone (cc, author, self,\nsob, bodycc) is cc'ed by default.  You can turn off each of these\nindividually using --supress-cc which can take values\n(all|cccmd|cc|author|self|sob|body|bodycc).  As you can see from\ngit-send-email.perl:400, the real purpose of --signed-off-by-cc is to\noverride a sendemail.suppresscc=sob; however, it can't override any\nstronger values of suppresscc (body, all).  So, it's mostly a\nno-option, and there is no corresponding --[no-]bodycc-cc.  Overall,\nthe way out of this horrible mess of options is to deprecate\n--[no-]signed-off-by-cc, and modify --supress-cc to have a\n--no-suppress-cc counterpart, just like --[no-]suppress-from.\n\nThanks.\n"}]}