{"thread":{"id":"34181","subject":"[PATCH] Remove pdf target from Makefiles","startedAt":"2013-06-17T18:16:12Z","lastAt":"2013-06-18T04:34:56Z","messageCount":2,"participants":["Thomas Ackermann","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"221084","messageId":"1370125851.738272.1371492972525.JavaMail.ngmail@webmail23.arcor-online.net","threadId":"34181","inReplyTo":null,"subject":"[PATCH] Remove pdf target from Makefiles","fromName":"Thomas Ackermann","fromEmail":"th.acker@arcor.de","sentAt":"2013-06-17T18:16:12Z","receivedAt":"2013-06-17T18:16:12Z","isPatch":true,"sender":{"key":"th.acker@arcor.de","avatar":"https://avatars.githubusercontent.com/u/1358536?v=4"},"body":"\nThis target was only used to create user-manual.pdf with dblatex\nusing a separate style definition than was used for user-manual.html.\nThese two style definitions had to be maintained separately and\nso made improvements to user-manual.html unnecessarily hard.\n\nSigned-off-by: Thomas Ackermann <th.acker@arcor.de>\n---\n\nImproving anything on the formatting of user-manual.pdf would necessitate\nto create customized versions of public dblatex style files from\n/etc/asciidoc/dblatex/. Instead of trying to expand on creating more and better\npdfs from the git documentation I suggest to drop the pdf target altogether\nand thus also get rid of the dependency on dblatex.\n\n Documentation/Makefile | 15 ---------------\n Makefile               |  6 ------\n 2 files changed, 21 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 62dbd9a..c42aa07 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -81,7 +81,6 @@ DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))\n prefix?=$(HOME)\n bindir?=$(prefix)/bin\n htmldir?=$(prefix)/share/doc/git-doc\n-pdfdir?=$(prefix)/share/doc/git-doc\n mandir?=$(prefix)/share/man\n man1dir=$(mandir)/man1\n man5dir=$(mandir)/man5\n@@ -102,7 +101,6 @@ infodir?=$(prefix)/share/info\n MAKEINFO=makeinfo\n INSTALL_INFO=install-info\n DOCBOOK2X_TEXI=docbook2x-texi\n-DBLATEX=dblatex\n ifndef PERL_PATH\n \tPERL_PATH = /usr/bin/perl\n endif\n@@ -185,7 +183,6 @@ ifndef V\n \tQUIET_XMLTO\t= @echo '   ' XMLTO $@;\n \tQUIET_DB2TEXI\t= @echo '   ' DB2TEXI $@;\n \tQUIET_MAKEINFO\t= @echo '   ' MAKEINFO $@;\n-\tQUIET_DBLATEX\t= @echo '   ' DBLATEX $@;\n \tQUIET_XSLTPROC\t= @echo '   ' XSLTPROC $@;\n \tQUIET_GEN\t= @echo '   ' GEN $@;\n \tQUIET_STDERR\t= 2> /dev/null\n@@ -207,8 +204,6 @@ man7: $(DOC_MAN7)\n \n info: git.info gitman.info\n \n-pdf: user-manual.pdf\n-\n install: install-man\n \n install-man: man\n@@ -229,10 +224,6 @@ install-info: info\n \t  echo \"No directory found in $(DESTDIR)$(infodir)\" >&2 ; \\\n \tfi\n \n-install-pdf: pdf\n-\t$(INSTALL) -d -m 755 $(DESTDIR)$(pdfdir)\n-\t$(INSTALL) -m 644 user-manual.pdf $(DESTDIR)$(pdfdir)\n-\n install-html: html\n \t'$(SHELL_PATH_SQ)' ./install-webdoc.sh $(DESTDIR)$(htmldir)\n \n@@ -289,7 +280,6 @@ mergetools-list.made: ../git-mergetool--lib.sh $(wildcard ../mergetools/*)\n clean:\n \t$(RM) *.xml *.xml+ *.html *.html+ *.1 *.5 *.7\n \t$(RM) *.texi *.texi+ *.texi++ git.info gitman.info\n-\t$(RM) *.pdf\n \t$(RM) howto-index.txt howto/*.html doc.dep\n \t$(RM) technical/*.html technical/api-index.txt\n \t$(RM) $(cmds_txt) $(mergetools_txt) *.made\n@@ -352,11 +342,6 @@ user-manual.texi: user-manual.xml\n \trm $@++ && \\\n \tmv $@+ $@\n \n-user-manual.pdf: user-manual.xml\n-\t$(QUIET_DBLATEX)$(RM) $@+ $@ && \\\n-\t$(DBLATEX) -o $@+ -p /etc/asciidoc/dblatex/asciidoc-dblatex.xsl -s /etc/asciidoc/dblatex/asciidoc-dblatex.sty $< && \\\n-\tmv $@+ $@\n-\n gitman.texi: $(MAN_XML) cat-texi.perl\n \t$(QUIET_DB2TEXI)$(RM) $@+ $@ && \\\n \t($(foreach xml,$(MAN_XML),$(DOCBOOK2X_TEXI) --encoding=UTF-8 \\\ndiff --git a/Makefile b/Makefile\nindex 03524d0..ab8fb15 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -2089,9 +2089,6 @@ html:\n info:\n \t$(MAKE) -C Documentation info\n \n-pdf:\n-\t$(MAKE) -C Documentation pdf\n-\n XGETTEXT_FLAGS = \\\n \t--force-po \\\n \t--add-comments \\\n@@ -2404,9 +2401,6 @@ install-html:\n install-info:\n \t$(MAKE) -C Documentation install-info\n \n-install-pdf:\n-\t$(MAKE) -C Documentation install-pdf\n-\n quick-install-doc:\n \t$(MAKE) -C Documentation quick-install\n \n-- \n1.8.3.msysgit.0\n\n\n\n---\nThomas\n"},{"id":"221141","messageId":"20130618043455.GB2896@elie.Belkin","threadId":"34181","inReplyTo":"1370125851.738272.1371492972525.JavaMail.ngmail@webmail23.arcor-online.net","subject":"Re: [PATCH] Remove pdf target from Makefiles","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-06-18T04:34:56Z","receivedAt":"2013-06-18T04:34:56Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi Thomas,\n\nThomas Ackermann wrote:\n\n> This target was only used to create user-manual.pdf with dblatex\n> using a separate style definition than was used for user-manual.html.\n> These two style definitions had to be maintained separately and\n> so made improvements to user-manual.html unnecessarily hard.\n\nI don't understand.  Do you mean that you want to change the rules\nthat generate user-manual.xml?  Would generating different XML files\nfor the PDF and for other purposes (with different names) work as a\nway to achieve that without losing the printable manual?\n\nThanks,\nJonathan\n"}]}