{"thread":{"id":"34165","subject":"[PATCH 1/2] Documentation/Makefile: fix spaces around assignments","startedAt":"2013-06-16T17:13:00Z","lastAt":"2013-06-18T04:32:41Z","messageCount":4,"participants":["John Keeping","Junio C Hamano","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"221006","messageId":"4857ab4f4097c582063f064f657a8e5dfbfee232.1371402684.git.john@keeping.me.uk","threadId":"34165","inReplyTo":null,"subject":"[PATCH 1/2] Documentation/Makefile: fix spaces around assignments","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-06-16T17:13:00Z","receivedAt":"2013-06-16T17:13:00Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"A simple style fix; no functional change.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\nNothing in maint..pu is touching this at the moment, so hopefully this\nis a good time to fix the whitespace here.\n\n Documentation/Makefile | 42 +++++++++++++++++++++---------------------\n 1 file changed, 21 insertions(+), 21 deletions(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex 62dbd9a..af3d8a4 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -31,11 +31,11 @@ MAN7_TXT += gittutorial.txt\n MAN7_TXT += gitworkflows.txt\n \n MAN_TXT = $(MAN1_TXT) $(MAN5_TXT) $(MAN7_TXT)\n-MAN_XML=$(patsubst %.txt,%.xml,$(MAN_TXT))\n-MAN_HTML=$(patsubst %.txt,%.html,$(MAN_TXT))\n+MAN_XML = $(patsubst %.txt,%.xml,$(MAN_TXT))\n+MAN_HTML = $(patsubst %.txt,%.html,$(MAN_TXT))\n \n OBSOLETE_HTML = git-remote-helpers.html\n-DOC_HTML=$(MAN_HTML) $(OBSOLETE_HTML)\n+DOC_HTML = $(MAN_HTML) $(OBSOLETE_HTML)\n \n ARTICLES = howto-index\n ARTICLES += everyday\n@@ -74,35 +74,35 @@ SP_ARTICLES += technical/api-index\n \n DOC_HTML += $(patsubst %,%.html,$(ARTICLES) $(SP_ARTICLES))\n \n-DOC_MAN1=$(patsubst %.txt,%.1,$(MAN1_TXT))\n-DOC_MAN5=$(patsubst %.txt,%.5,$(MAN5_TXT))\n-DOC_MAN7=$(patsubst %.txt,%.7,$(MAN7_TXT))\n+DOC_MAN1 = $(patsubst %.txt,%.1,$(MAN1_TXT))\n+DOC_MAN5 = $(patsubst %.txt,%.5,$(MAN5_TXT))\n+DOC_MAN7 = $(patsubst %.txt,%.7,$(MAN7_TXT))\n \n-prefix?=$(HOME)\n-bindir?=$(prefix)/bin\n-htmldir?=$(prefix)/share/doc/git-doc\n-pdfdir?=$(prefix)/share/doc/git-doc\n-mandir?=$(prefix)/share/man\n-man1dir=$(mandir)/man1\n-man5dir=$(mandir)/man5\n-man7dir=$(mandir)/man7\n-# DESTDIR=\n+prefix ?= $(HOME)\n+bindir ?= $(prefix)/bin\n+htmldir ?= $(prefix)/share/doc/git-doc\n+pdfdir ?= $(prefix)/share/doc/git-doc\n+mandir ?= $(prefix)/share/man\n+man1dir = $(mandir)/man1\n+man5dir = $(mandir)/man5\n+man7dir = $(mandir)/man7\n+# DESTDIR =\n \n ASCIIDOC = asciidoc\n ASCIIDOC_EXTRA =\n MANPAGE_XSL = manpage-normal.xsl\n XMLTO = xmlto\n XMLTO_EXTRA =\n-INSTALL?=install\n+INSTALL ?= install\n RM ?= rm -f\n MAN_REPO = ../../git-manpages\n HTML_REPO = ../../git-htmldocs\n \n-infodir?=$(prefix)/share/info\n-MAKEINFO=makeinfo\n-INSTALL_INFO=install-info\n-DOCBOOK2X_TEXI=docbook2x-texi\n-DBLATEX=dblatex\n+infodir ?= $(prefix)/share/info\n+MAKEINFO = makeinfo\n+INSTALL_INFO = install-info\n+DOCBOOK2X_TEXI = docbook2x-texi\n+DBLATEX = dblatex\n ifndef PERL_PATH\n \tPERL_PATH = /usr/bin/perl\n endif\n-- \n1.8.3.779.g691e267\n"},{"id":"221007","messageId":"ffea107da7b3b7d5e390d27397d3a72155e942b4.1371402684.git.john@keeping.me.uk","threadId":"34165","inReplyTo":"4857ab4f4097c582063f064f657a8e5dfbfee232.1371402684.git.john@keeping.me.uk","subject":"[PATCH 2/2] Documentation/Makefile: move infodir to be with other '*dir's","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-06-16T17:13:01Z","receivedAt":"2013-06-16T17:13:01Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"Signed-off-by: John Keeping <john@keeping.me.uk>\n---\n Documentation/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/Makefile b/Documentation/Makefile\nindex af3d8a4..0cfdc36 100644\n--- a/Documentation/Makefile\n+++ b/Documentation/Makefile\n@@ -81,6 +81,7 @@ DOC_MAN7 = $(patsubst %.txt,%.7,$(MAN7_TXT))\n prefix ?= $(HOME)\n bindir ?= $(prefix)/bin\n htmldir ?= $(prefix)/share/doc/git-doc\n+infodir ?= $(prefix)/share/info\n pdfdir ?= $(prefix)/share/doc/git-doc\n mandir ?= $(prefix)/share/man\n man1dir = $(mandir)/man1\n@@ -98,7 +99,6 @@ RM ?= rm -f\n MAN_REPO = ../../git-manpages\n HTML_REPO = ../../git-htmldocs\n \n-infodir ?= $(prefix)/share/info\n MAKEINFO = makeinfo\n INSTALL_INFO = install-info\n DOCBOOK2X_TEXI = docbook2x-texi\n-- \n1.8.3.779.g691e267\n"},{"id":"221099","messageId":"7vppvkbikk.fsf@alter.siamese.dyndns.org","threadId":"34165","inReplyTo":"ffea107da7b3b7d5e390d27397d3a72155e942b4.1371402684.git.john@keeping.me.uk","subject":"Re: [PATCH 2/2] Documentation/Makefile: move infodir to be with other '*dir's","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-06-17T20:14:51Z","receivedAt":"2013-06-17T20:14:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"John Keeping <john@keeping.me.uk> writes:\n\n> Signed-off-by: John Keeping <john@keeping.me.uk>\n> ---\n\nThanks; will directly apply 1/2 on maint.  I am not absolutely sure\nabout this one, where variables related to an optional \"info\"\nsupport used to be in one place but with the patch only \"infodir\" is\nseparated away.  Maybe it is not a big deal, though.\n\n>  Documentation/Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/Makefile b/Documentation/Makefile\n> index af3d8a4..0cfdc36 100644\n> --- a/Documentation/Makefile\n> +++ b/Documentation/Makefile\n> @@ -81,6 +81,7 @@ DOC_MAN7 = $(patsubst %.txt,%.7,$(MAN7_TXT))\n>  prefix ?= $(HOME)\n>  bindir ?= $(prefix)/bin\n>  htmldir ?= $(prefix)/share/doc/git-doc\n> +infodir ?= $(prefix)/share/info\n>  pdfdir ?= $(prefix)/share/doc/git-doc\n>  mandir ?= $(prefix)/share/man\n>  man1dir = $(mandir)/man1\n> @@ -98,7 +99,6 @@ RM ?= rm -f\n>  MAN_REPO = ../../git-manpages\n>  HTML_REPO = ../../git-htmldocs\n>  \n> -infodir ?= $(prefix)/share/info\n>  MAKEINFO = makeinfo\n>  INSTALL_INFO = install-info\n>  DOCBOOK2X_TEXI = docbook2x-texi\n"},{"id":"221140","messageId":"20130618043240.GA2896@elie.Belkin","threadId":"34165","inReplyTo":"7vppvkbikk.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 2/2] Documentation/Makefile: move infodir to be with other '*dir's","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-06-18T04:32:41Z","receivedAt":"2013-06-18T04:32:41Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Jun 17, 2013 at 01:14:51PM -0700, Junio C Hamano wrote:\n> John Keeping <john@keeping.me.uk> writes:\n\n>> Signed-off-by: John Keeping <john@keeping.me.uk>\n>> ---\n>\n> Thanks; will directly apply 1/2 on maint.  I am not absolutely sure\n> about this one, where variables related to an optional \"info\"\n> support used to be in one place but with the patch only \"infodir\" is\n> separated away.  Maybe it is not a big deal, though.\n\nIn practice, I think keeping the variables that specify the filesystem\nhierarchy together is more useful (or in other words, this looks like a\ngood patch).\n\nThanks,\nJonathan\n"}]}