{"thread":{"id":"34074","subject":"[PATCH] submodule: remove redundant check for the_index.initialized","startedAt":"2013-06-09T16:33:45Z","lastAt":"2013-06-09T17:41:03Z","messageCount":3,"participants":["René Scharfe","Felipe Contreras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"219969","messageId":"1370795625-10506-1-git-send-email-rene.scharfe@lsrfire.ath.cx","threadId":"34074","inReplyTo":null,"subject":"[PATCH] submodule: remove redundant check for the_index.initialized","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2013-06-09T16:33:45Z","receivedAt":"2013-06-09T16:33:45Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"read_cache already performs the same check and returns immediately if\nthe cache has already been loaded.\n\nSigned-off-by: René Scharfe <rene.scharfe@lsrfire.ath.cx>\n---\n submodule.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/submodule.c b/submodule.c\nindex e728025..1821a5b 100644\n--- a/submodule.c\n+++ b/submodule.c\n@@ -603,9 +603,8 @@ int fetch_populated_submodules(const struct argv_array *options,\n \tif (!work_tree)\n \t\tgoto out;\n \n-\tif (!the_index.initialized)\n-\t\tif (read_cache() < 0)\n-\t\t\tdie(\"index file corrupt\");\n+\tif (read_cache() < 0)\n+\t\tdie(\"index file corrupt\");\n \n \targv_array_push(&argv, \"fetch\");\n \tfor (i = 0; i < options->argc; i++)\n-- \n1.8.3\n"},{"id":"219999","messageId":"CAMP44s2cidZt6YWx-f5VMO3uhcTbV-SA-ze6xojHn2y_Pi1=NA@mail.gmail.com","threadId":"34074","inReplyTo":"1370795625-10506-1-git-send-email-rene.scharfe@lsrfire.ath.cx","subject":"Re: [PATCH] submodule: remove redundant check for the_index.initialized","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-06-09T16:44:15Z","receivedAt":"2013-06-09T16:44:15Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Jun 9, 2013 at 11:33 AM, René Scharfe\n<rene.scharfe@lsrfire.ath.cx> wrote:\n> read_cache already performs the same check and returns immediately if\n> the cache has already been loaded.\n\nThis time I beat you to it first ;)\nhttp://article.gmane.org/gmane.comp.version-control.git/226701\n\n-- \nFelipe Contreras\n"},{"id":"220048","messageId":"51B4BE2F.6060700@lsrfire.ath.cx","threadId":"34074","inReplyTo":"CAMP44s2cidZt6YWx-f5VMO3uhcTbV-SA-ze6xojHn2y_Pi1=NA@mail.gmail.com","subject":"Re: [PATCH] submodule: remove redundant check for the_index.initialized","fromName":"René Scharfe","fromEmail":"rene.scharfe@lsrfire.ath.cx","sentAt":"2013-06-09T17:41:03Z","receivedAt":"2013-06-09T17:41:03Z","isPatch":true,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Am 09.06.2013 18:44, schrieb Felipe Contreras:\n> On Sun, Jun 9, 2013 at 11:33 AM, René Scharfe\n> <rene.scharfe@lsrfire.ath.cx> wrote:\n>> read_cache already performs the same check and returns immediately if\n>> the cache has already been loaded.\n>\n> This time I beat you to it first ;)\n> http://article.gmane.org/gmane.comp.version-control.git/226701\n\nGood to see we're agreeing on something for once. ;)\n\nRené\n"}]}