{"thread":{"id":"34009","subject":"[PATCH] object.c: Fix a sparse warning","startedAt":"2013-06-01T17:46:11Z","lastAt":"2013-06-02T06:12:42Z","messageCount":2,"participants":["Ramsay Jones","Michael Haggerty"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"219152","messageId":"51AA3363.8030705@ramsay1.demon.co.uk","threadId":"34009","inReplyTo":null,"subject":"[PATCH] object.c: Fix a sparse warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2013-06-01T17:46:11Z","receivedAt":"2013-06-01T17:46:11Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSparse issues an \"'object_array_slopbuf' not declared. Should it be\nstatic?\" warning. In order to suppress the warning, since this\nsymbol does not need more than file visibility, we simply add the\nstatic modifier to its declaration.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Michael,\n\nIf you need to re-roll the patches in your 'mh/reflife' branch,\ncould you please squash this into the patch corresponding to\ncommit cbdeb23e (\"object_array_entry: fix memory handling of\nthe name field\", 25-05-2013).\n\nThanks!\n\nATB,\nRamsay Jones\n\n object.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/object.c b/object.c\nindex 2976b2e..0de4c91 100644\n--- a/object.c\n+++ b/object.c\n@@ -269,7 +269,7 @@ int object_list_contains(struct object_list *list, struct object *obj)\n  * A zero-length string to which object_array_entry::name can be\n  * initialized without requiring a malloc/free.\n  */\n-char object_array_slopbuf[1];\n+static char object_array_slopbuf[1];\n \n static void add_object_array_with_mode_context(struct object *obj, const char *name,\n \t\t\t\t\t       struct object_array *array,\n-- \n1.8.3\n"},{"id":"219158","messageId":"51AAE25A.6080009@alum.mit.edu","threadId":"34009","inReplyTo":"51AA3363.8030705@ramsay1.demon.co.uk","subject":"Re: [PATCH] object.c: Fix a sparse warning","fromName":"Michael Haggerty","fromEmail":"mhagger@alum.mit.edu","sentAt":"2013-06-02T06:12:42Z","receivedAt":"2013-06-02T06:12:42Z","isPatch":true,"sender":{"key":"mhagger@alum.mit.edu","avatar":"https://avatars.githubusercontent.com/u/119718?v=4"},"body":"On 06/01/2013 07:46 PM, Ramsay Jones wrote:\n> \n> Sparse issues an \"'object_array_slopbuf' not declared. Should it be\n> static?\" warning. In order to suppress the warning, since this\n> symbol does not need more than file visibility, we simply add the\n> static modifier to its declaration.\n> \n> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n> ---\n> \n> Hi Michael,\n> \n> If you need to re-roll the patches in your 'mh/reflife' branch,\n> could you please squash this into the patch corresponding to\n> commit cbdeb23e (\"object_array_entry: fix memory handling of\n> the name field\", 25-05-2013).\n\nRamsay, thanks for fixing this.\n\nJunio, it doesn't seem worth spamming the list with a re-roll for this\nand the other 1-line fixup commit that I already sent.  Would you mind\neither pulling the re-rolled version that I published here:\n\n    git://github.com/mhagger/git.git\n    branch reflife-v3, 50f7a18ee9ad537a7bf7992d6eb145299a4884b9\n\nor squashing them onto the patch series yourself?  Let me know if this\nis inconvenient.\n\nThanks,\nMichael\n\n-- \nMichael Haggerty\nmhagger@alum.mit.edu\nhttp://softwareswirl.blogspot.com/\n"}]}