{"thread":{"id":"34000","subject":"[PATCH] submodule: remove unnecessary check","startedAt":"2013-05-31T08:27:36Z","lastAt":"2013-05-31T08:27:36Z","messageCount":1,"participants":["Felipe Contreras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"219089","messageId":"1369988856-4304-1-git-send-email-felipe.contreras@gmail.com","threadId":"34000","inReplyTo":null,"subject":"[PATCH] submodule: remove unnecessary check","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-31T08:27:36Z","receivedAt":"2013-05-31T08:27:36Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"read_cache() already does that check.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n submodule.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/submodule.c b/submodule.c\nindex e728025..1821a5b 100644\n--- a/submodule.c\n+++ b/submodule.c\n@@ -603,9 +603,8 @@ int fetch_populated_submodules(const struct argv_array *options,\n \tif (!work_tree)\n \t\tgoto out;\n \n-\tif (!the_index.initialized)\n-\t\tif (read_cache() < 0)\n-\t\t\tdie(\"index file corrupt\");\n+\tif (read_cache() < 0)\n+\t\tdie(\"index file corrupt\");\n \n \targv_array_push(&argv, \"fetch\");\n \tfor (i = 0; i < options->argc; i++)\n-- \n1.8.3.358.g5a91d05\n"}]}