{"thread":{"id":"33929","subject":"[PATCH] send-email: remove warning about unset chainreplyto","startedAt":"2013-05-25T03:44:52Z","lastAt":"2013-05-25T03:44:52Z","messageCount":1,"participants":["Felipe Contreras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"218501","messageId":"1369453492-20972-1-git-send-email-felipe.contreras@gmail.com","threadId":"33929","inReplyTo":null,"subject":"[PATCH] send-email: remove warning about unset chainreplyto","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-25T03:44:52Z","receivedAt":"2013-05-25T03:44:52Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Three years and a half is probably more than enough time to give users\nthe opportunity to configure Git to do what they want. If they haven't\nchanged the configuration by now, this warning message is not going to\ndo anything for them anyway.\n\nThis effectively reverts commit 528fb08 (prepare send-email for smoother\nchange of --chain-reply-to default).\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n git-send-email.perl   | 19 ++-----------------\n t/t9001-send-email.sh | 49 -------------------------------------------------\n 2 files changed, 2 insertions(+), 66 deletions(-)\n\ndiff --git a/git-send-email.perl b/git-send-email.perl\nindex bd13cc8..ec1d6ce 100755\n--- a/git-send-email.perl\n+++ b/git-send-email.perl\n@@ -203,11 +203,9 @@ my ($compose_encoding);\n \n my ($debug_net_smtp) = 0;\t\t# Net::SMTP, see send_message()\n \n-my $not_set_by_user = \"true but not set by the user\";\n-\n my %config_bool_settings = (\n     \"thread\" => [\\$thread, 1],\n-    \"chainreplyto\" => [\\$chain_reply_to, $not_set_by_user],\n+    \"chainreplyto\" => [\\$chain_reply_to, 0],\n     \"suppressfrom\" => [\\$suppress_from, undef],\n     \"signedoffbycc\" => [\\$signed_off_by_cc, undef],\n     \"signedoffcc\" => [\\$signed_off_by_cc, undef],      # Deprecated\n@@ -241,19 +239,6 @@ my %config_path_settings = (\n     \"aliasesfile\" => \\@alias_files,\n );\n \n-# Help users prepare for 1.7.0\n-sub chain_reply_to {\n-\tif (defined $chain_reply_to &&\n-\t    $chain_reply_to eq $not_set_by_user) {\n-\t\tprint STDERR\n-\t\t    \"In git 1.7.0, the default has changed to --no-chain-reply-to\\n\" .\n-\t\t    \"Set sendemail.chainreplyto configuration variable to true if\\n\" .\n-\t\t    \"you want to keep --chain-reply-to as your default.\\n\";\n-\t\t$chain_reply_to = 0;\n-\t}\n-\treturn $chain_reply_to;\n-}\n-\n # Handle Uncouth Termination\n sub signal_handler {\n \n@@ -1437,7 +1422,7 @@ foreach my $t (@files) {\n \n \t# set up for the next message\n \tif ($thread && $message_was_sent &&\n-\t\t(chain_reply_to() || !defined $reply_to || length($reply_to) == 0 ||\n+\t\t($chain_reply_to || !defined $reply_to || length($reply_to) == 0 ||\n \t\t$message_num == 1)) {\n \t\t$reply_to = $message_id;\n \t\tif (length $references > 0) {\ndiff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh\nindex ebd5c5d..5d2dbe9 100755\n--- a/t/t9001-send-email.sh\n+++ b/t/t9001-send-email.sh\n@@ -1003,55 +1003,6 @@ test_expect_success $PREREQ 'threading but no chain-reply-to' '\n \tgrep \"In-Reply-To: \" stdout\n '\n \n-test_expect_success $PREREQ 'warning with an implicit --chain-reply-to' '\n-\tgit send-email \\\n-\t--dry-run \\\n-\t--from=\"Example <nobody@example.com>\" \\\n-\t--to=nobody@example.com \\\n-\toutdir/000?-*.patch 2>errors >out &&\n-\tgrep \"no-chain-reply-to\" errors\n-'\n-\n-test_expect_success $PREREQ 'no warning with an explicit --chain-reply-to' '\n-\tgit send-email \\\n-\t--dry-run \\\n-\t--from=\"Example <nobody@example.com>\" \\\n-\t--to=nobody@example.com \\\n-\t--chain-reply-to \\\n-\toutdir/000?-*.patch 2>errors >out &&\n-\t! grep \"no-chain-reply-to\" errors\n-'\n-\n-test_expect_success $PREREQ 'no warning with an explicit --no-chain-reply-to' '\n-\tgit send-email \\\n-\t--dry-run \\\n-\t--from=\"Example <nobody@example.com>\" \\\n-\t--to=nobody@example.com \\\n-\t--nochain-reply-to \\\n-\toutdir/000?-*.patch 2>errors >out &&\n-\t! grep \"no-chain-reply-to\" errors\n-'\n-\n-test_expect_success $PREREQ 'no warning with sendemail.chainreplyto = false' '\n-\tgit config sendemail.chainreplyto false &&\n-\tgit send-email \\\n-\t--dry-run \\\n-\t--from=\"Example <nobody@example.com>\" \\\n-\t--to=nobody@example.com \\\n-\toutdir/000?-*.patch 2>errors >out &&\n-\t! grep \"no-chain-reply-to\" errors\n-'\n-\n-test_expect_success $PREREQ 'no warning with sendemail.chainreplyto = true' '\n-\tgit config sendemail.chainreplyto true &&\n-\tgit send-email \\\n-\t--dry-run \\\n-\t--from=\"Example <nobody@example.com>\" \\\n-\t--to=nobody@example.com \\\n-\toutdir/000?-*.patch 2>errors >out &&\n-\t! grep \"no-chain-reply-to\" errors\n-'\n-\n test_expect_success $PREREQ 'sendemail.to works' '\n \tgit config --replace-all sendemail.to \"Somebody <somebody@ex.com>\" &&\n \tgit send-email \\\n-- \n1.8.3.rc3.312.g47657de\n"}]}