{"thread":{"id":"33925","subject":"[PATCH 0/4] remote-helpers: test reorganization","startedAt":"2013-05-25T02:38:23Z","lastAt":"2013-05-29T19:32:59Z","messageCount":12,"participants":["Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":4},"messages":[{"id":"218478","messageId":"1369449507-18269-1-git-send-email-felipe.contreras@gmail.com","threadId":"33925","inReplyTo":null,"subject":"[PATCH 0/4] remote-helpers: test reorganization","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-25T02:38:23Z","receivedAt":"2013-05-25T02:38:23Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Now we use PYTHON_PATH properly, and also we are able to do:\n\n make -C contrib/remote-helpers install\n\nFelipe Contreras (4):\n remote-helpers: generate scripts\n remote-helpers: rename tests\n remote-helpers: allow direct test execution\n remote-helpers: add exec-path links\n\n .gitignore | 2 ++\n contrib/remote-helpers/.gitignore | 2 ++\n contrib/remote-helpers/Makefile | 25 +++++++++++++++++-----\n .../{git-remote-bzr => git-remote-bzr.py} | 0\n .../{git-remote-hg => git-remote-hg.py} | 0\n contrib/remote-helpers/{test-bzr.sh => test-bzr.t} | 3 ++-\n .../{test-hg-bidi.sh => test-hg-bidi.t} | 3 ++-\n .../{test-hg-hg-git.sh => test-hg-hg-git.t} | 3 ++-\n contrib/remote-helpers/{test-hg.sh => test-hg.t} | 3 ++-\n 9 files changed, 32 insertions(+), 9 deletions(-)\n create mode 100644 contrib/remote-helpers/.gitignore\n rename contrib/remote-helpers/{git-remote-bzr => git-remote-bzr.py} (100%)\n rename contrib/remote-helpers/{git-remote-hg => git-remote-hg.py} (100%)\n rename contrib/remote-helpers/{test-bzr.sh => test-bzr.t} (98%)\n rename contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} (98%)\n rename contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} (99%)\n rename contrib/remote-helpers/{test-hg.sh => test-hg.t} (97%)\n\n-- \n1.8.3.rc3.312.g47657de\n"},{"id":"218479","messageId":"1369449507-18269-2-git-send-email-felipe.contreras@gmail.com","threadId":"33925","inReplyTo":"1369449507-18269-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 1/4] remote-helpers: generate scripts","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-25T02:38:24Z","receivedAt":"2013-05-25T02:38:24Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"The same way other python scripts are generated, so the shebang is\nreplaced by PYTHON_PATH.\n\nAlso, cleanup the Makefile.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/.gitignore | 2 ++\n contrib/remote-helpers/Makefile | 15 ++++++++++++---\n .../remote-helpers/{git-remote-bzr => git-remote-bzr.py} | 0\n .../remote-helpers/{git-remote-hg => git-remote-hg.py} | 0\n 4 files changed, 14 insertions(+), 3 deletions(-)\n create mode 100644 contrib/remote-helpers/.gitignore\n rename contrib/remote-helpers/{git-remote-bzr => git-remote-bzr.py} (100%)\n rename contrib/remote-helpers/{git-remote-hg => git-remote-hg.py} (100%)\n\ndiff --git a/contrib/remote-helpers/.gitignore b/contrib/remote-helpers/.gitignore\nnew file mode 100644\nindex 0000000..9bf692b\n--- /dev/null\n+++ b/contrib/remote-helpers/.gitignore\n@@ -0,0 +1,2 @@\n+git-remote-bzr\n+git-remote-hg\ndiff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile\nindex 239161d..d9b3515 100644\n--- a/contrib/remote-helpers/Makefile\n+++ b/contrib/remote-helpers/Makefile\n@@ -1,14 +1,23 @@\n TESTS := $(wildcard test*.sh)\n+SCRIPTS := $(wildcard git-remote-*.py)\n \n export T := $(addprefix $(CURDIR)/,$(TESTS))\n export MAKE := $(MAKE) -e\n export PATH := $(CURDIR):$(PATH)\n export TEST_LINT := test-lint-executable test-lint-shell-syntax\n \n-test:\n+export SCRIPT_PYTHON := $(addprefix $(CURDIR)/,$(SCRIPTS))\n+\n+all: $(SCRIPTS)\n+\t$(MAKE) -C ../.. build-python-script\n+\n+install:\n+\t$(MAKE) -C ../.. install-python-script\n+\n+test: all\n \t$(MAKE) -C ../../t $@\n \n-$(TESTS):\n+$(TESTS): all\n \t$(MAKE) -C ../../t $(CURDIR)/$@\n \n-.PHONY: $(TESTS)\n+.PHONY: all install test $(TESTS)\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr.py\nsimilarity index 100%\nrename from contrib/remote-helpers/git-remote-bzr\nrename to contrib/remote-helpers/git-remote-bzr.py\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg.py\nsimilarity index 100%\nrename from contrib/remote-helpers/git-remote-hg\nrename to contrib/remote-helpers/git-remote-hg.py\n-- \n1.8.3.rc3.312.g47657de\n"},{"id":"218482","messageId":"1369449507-18269-3-git-send-email-felipe.contreras@gmail.com","threadId":"33925","inReplyTo":"1369449507-18269-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 2/4] remote-helpers: rename tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-25T02:38:25Z","receivedAt":"2013-05-25T02:38:25Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"The .t extension is more standard for sharness tests.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/Makefile | 2 +-\n contrib/remote-helpers/{test-bzr.sh => test-bzr.t} | 0\n contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} | 0\n contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} | 0\n contrib/remote-helpers/{test-hg.sh => test-hg.t} | 0\n 5 files changed, 1 insertion(+), 1 deletion(-)\n rename contrib/remote-helpers/{test-bzr.sh => test-bzr.t} (100%)\n rename contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} (100%)\n rename contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} (100%)\n rename contrib/remote-helpers/{test-hg.sh => test-hg.t} (100%)\n\ndiff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile\nindex d9b3515..2c91ec6 100644\n--- a/contrib/remote-helpers/Makefile\n+++ b/contrib/remote-helpers/Makefile\n@@ -1,4 +1,4 @@\n-TESTS := $(wildcard test*.sh)\n+TESTS := $(wildcard test-*.t)\n SCRIPTS := $(wildcard git-remote-*.py)\n \n export T := $(addprefix $(CURDIR)/,$(TESTS))\ndiff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.t\nsimilarity index 100%\nrename from contrib/remote-helpers/test-bzr.sh\nrename to contrib/remote-helpers/test-bzr.t\ndiff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.t\nsimilarity index 100%\nrename from contrib/remote-helpers/test-hg-bidi.sh\nrename to contrib/remote-helpers/test-hg-bidi.t\ndiff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.t\nsimilarity index 100%\nrename from contrib/remote-helpers/test-hg-hg-git.sh\nrename to contrib/remote-helpers/test-hg-hg-git.t\ndiff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.t\nsimilarity index 100%\nrename from contrib/remote-helpers/test-hg.sh\nrename to contrib/remote-helpers/test-hg.t\n-- \n1.8.3.rc3.312.g47657de\n"},{"id":"218480","messageId":"1369449507-18269-4-git-send-email-felipe.contreras@gmail.com","threadId":"33925","inReplyTo":"1369449507-18269-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 3/4] remote-helpers: allow direct test execution","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-25T02:38:26Z","receivedAt":"2013-05-25T02:38:26Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Previously 'make' was the only option, or manually specifying the\n'TEST_DIRECTORY'.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/Makefile | 1 +\n contrib/remote-helpers/test-bzr.t | 3 ++-\n contrib/remote-helpers/test-hg-bidi.t | 3 ++-\n contrib/remote-helpers/test-hg-hg-git.t | 3 ++-\n contrib/remote-helpers/test-hg.t | 3 ++-\n 5 files changed, 9 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile\nindex 2c91ec6..55abf0b 100644\n--- a/contrib/remote-helpers/Makefile\n+++ b/contrib/remote-helpers/Makefile\n@@ -5,6 +5,7 @@ export T := $(addprefix $(CURDIR)/,$(TESTS))\n export MAKE := $(MAKE) -e\n export PATH := $(CURDIR):$(PATH)\n export TEST_LINT := test-lint-executable test-lint-shell-syntax\n+export TEST_DIRECTORY := $(CURDIR)/../../t\n \n export SCRIPT_PYTHON := $(addprefix $(CURDIR)/,$(SCRIPTS))\n \ndiff --git a/contrib/remote-helpers/test-bzr.t b/contrib/remote-helpers/test-bzr.t\nindex 5dfa070..0f24c48 100755\n--- a/contrib/remote-helpers/test-bzr.t\n+++ b/contrib/remote-helpers/test-bzr.t\n@@ -5,7 +5,8 @@\n \n test_description='Test remote-bzr'\n \n-. ./test-lib.sh\n+test -z \"$TEST_DIRECTORY\" && TEST_DIRECTORY=\"$PWD/../../t\"\n+. \"$TEST_DIRECTORY\"/test-lib.sh\n \n if ! test_have_prereq PYTHON; then\n \tskip_all='skipping remote-bzr tests; python not available'\ndiff --git a/contrib/remote-helpers/test-hg-bidi.t b/contrib/remote-helpers/test-hg-bidi.t\nindex f569697..8707eb9 100755\n--- a/contrib/remote-helpers/test-hg-bidi.t\n+++ b/contrib/remote-helpers/test-hg-bidi.t\n@@ -8,7 +8,8 @@\n \n test_description='Test bidirectionality of remote-hg'\n \n-. ./test-lib.sh\n+test -z \"$TEST_DIRECTORY\" && TEST_DIRECTORY=\"$PWD/../../t\"\n+. \"$TEST_DIRECTORY\"/test-lib.sh\n \n if ! test_have_prereq PYTHON; then\n \tskip_all='skipping remote-hg tests; python not available'\ndiff --git a/contrib/remote-helpers/test-hg-hg-git.t b/contrib/remote-helpers/test-hg-hg-git.t\nindex 7f579c8..ac1de96 100755\n--- a/contrib/remote-helpers/test-hg-hg-git.t\n+++ b/contrib/remote-helpers/test-hg-hg-git.t\n@@ -8,7 +8,8 @@\n \n test_description='Test remote-hg output compared to hg-git'\n \n-. ./test-lib.sh\n+test -z \"$TEST_DIRECTORY\" && TEST_DIRECTORY=\"$PWD/../../t\"\n+. \"$TEST_DIRECTORY\"/test-lib.sh\n \n if ! test_have_prereq PYTHON; then\n \tskip_all='skipping remote-hg tests; python not available'\ndiff --git a/contrib/remote-helpers/test-hg.t b/contrib/remote-helpers/test-hg.t\nindex 8de2aa7..a362867 100755\n--- a/contrib/remote-helpers/test-hg.t\n+++ b/contrib/remote-helpers/test-hg.t\n@@ -8,7 +8,8 @@\n \n test_description='Test remote-hg'\n \n-. ./test-lib.sh\n+test -z \"$TEST_DIRECTORY\" && TEST_DIRECTORY=\"$PWD/../../t\"\n+. \"$TEST_DIRECTORY\"/test-lib.sh\n \n if ! test_have_prereq PYTHON; then\n \tskip_all='skipping remote-hg tests; python not available'\n-- \n1.8.3.rc3.312.g47657de\n"},{"id":"218481","messageId":"1369449507-18269-5-git-send-email-felipe.contreras@gmail.com","threadId":"33925","inReplyTo":"1369449507-18269-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 4/4] remote-helpers: add exec-path links","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-25T02:38:27Z","receivedAt":"2013-05-25T02:38:27Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"This way we don't have to modify the PATH ourselves and it's easier to\ntest without 'make'.\n\nSigned-off-by: Felipe Contreras \n---\n .gitignore | 2 ++\n contrib/remote-helpers/Makefile | 13 +++++++++----\n 2 files changed, 11 insertions(+), 4 deletions(-)\n\ndiff --git a/.gitignore b/.gitignore\nindex 10aee94..a79b412 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -119,11 +119,13 @@\n /git-reflog\n /git-relink\n /git-remote\n+/git-remote-bzr\n /git-remote-http\n /git-remote-https\n /git-remote-ftp\n /git-remote-ftps\n /git-remote-fd\n+/git-remote-hg\n /git-remote-ext\n /git-remote-testgit\n /git-remote-testpy\ndiff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile\nindex 55abf0b..98150b4 100644\n--- a/contrib/remote-helpers/Makefile\n+++ b/contrib/remote-helpers/Makefile\n@@ -1,9 +1,9 @@\n TESTS := $(wildcard test-*.t)\n SCRIPTS := $(wildcard git-remote-*.py)\n+LINKS := $(addprefix ../../,$(patsubst %.py,%,$(SCRIPTS)))\n \n export T := $(addprefix $(CURDIR)/,$(TESTS))\n export MAKE := $(MAKE) -e\n-export PATH := $(CURDIR):$(PATH)\n export TEST_LINT := test-lint-executable test-lint-shell-syntax\n export TEST_DIRECTORY := $(CURDIR)/../../t\n \n@@ -15,10 +15,15 @@ all: $(SCRIPTS)\n install:\n \t$(MAKE) -C ../.. install-python-script\n \n-test: all\n+links: all $(LINKS)\n+\n+test: links\n \t$(MAKE) -C ../../t $@\n \n-$(TESTS): all\n+$(LINKS):\n+\tln -sf contrib/remote-helpers/$(notdir $@) ../..\n+\n+$(TESTS): links\n \t$(MAKE) -C ../../t $(CURDIR)/$@\n \n-.PHONY: all install test $(TESTS)\n+.PHONY: all install test links $(TESTS)\n-- \n1.8.3.rc3.312.g47657de\n"},{"id":"218696","messageId":"7vmwrezx7n.fsf@alter.siamese.dyndns.org","threadId":"33925","inReplyTo":"1369449507-18269-3-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH 2/4] remote-helpers: rename tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-28T20:05:48Z","receivedAt":"2013-05-28T20:05:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> The .t extension is more standard for sharness tests.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n\nIs that \"sharness\" test the sh script testsuite forked from our\ntestsuite?\n\nI do not see how it makes sense to copy how they deviate from us\nback to our codebase, especially if we plan to eventually move some\nof these tests out of contrib/ area, but even without such a plan in\nthe future.\n\n\n\n> contrib/remote-helpers/Makefile | 2 +-\n> contrib/remote-helpers/{test-bzr.sh => test-bzr.t} | 0\n> contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} | 0\n> contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} | 0\n> contrib/remote-helpers/{test-hg.sh => test-hg.t} | 0\n> 5 files changed, 1 insertion(+), 1 deletion(-)\n> rename contrib/remote-helpers/{test-bzr.sh => test-bzr.t} (100%)\n> rename contrib/remote-helpers/{test-hg-bidi.sh => test-hg-bidi.t} (100%)\n> rename contrib/remote-helpers/{test-hg-hg-git.sh => test-hg-hg-git.t} (100%)\n> rename contrib/remote-helpers/{test-hg.sh => test-hg.t} (100%)\n>\n> diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile\n> index d9b3515..2c91ec6 100644\n> --- a/contrib/remote-helpers/Makefile\n> +++ b/contrib/remote-helpers/Makefile\n> @@ -1,4 +1,4 @@\n> -TESTS := $(wildcard test*.sh)\n> +TESTS := $(wildcard test-*.t)\n> SCRIPTS := $(wildcard git-remote-*.py)\n> \n> export T := $(addprefix $(CURDIR)/,$(TESTS))\n> diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.t\n> similarity index 100%\n> rename from contrib/remote-helpers/test-bzr.sh\n> rename to contrib/remote-helpers/test-bzr.t\n> diff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.t\n> similarity index 100%\n> rename from contrib/remote-helpers/test-hg-bidi.sh\n> rename to contrib/remote-helpers/test-hg-bidi.t\n> diff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.t\n> similarity index 100%\n> rename from contrib/remote-helpers/test-hg-hg-git.sh\n> rename to contrib/remote-helpers/test-hg-hg-git.t\n> diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.t\n> similarity index 100%\n> rename from contrib/remote-helpers/test-hg.sh\n> rename to contrib/remote-helpers/test-hg.t\n"},{"id":"218697","messageId":"7vfvx6zx79.fsf@alter.siamese.dyndns.org","threadId":"33925","inReplyTo":"1369449507-18269-5-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH 4/4] remote-helpers: add exec-path links","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-28T20:06:02Z","receivedAt":"2013-05-28T20:06:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> This way we don't have to modify the PATH ourselves and it's easier to\n> test without 'make'.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n> .gitignore | 2 ++\n> contrib/remote-helpers/Makefile | 13 +++++++++----\n> 2 files changed, 11 insertions(+), 4 deletions(-)\n\nIf we teach the top-level .gitignore that some contrib/ stuff might\ncontaminate the top-level directory (which is a good idea), we\nshould also teach the top-level Makefile how to get rid of the built\ncruft upon \"make clean\", no?\n\n> diff --git a/.gitignore b/.gitignore\n> index 10aee94..a79b412 100644\n> --- a/.gitignore\n> +++ b/.gitignore\n> @@ -119,11 +119,13 @@\n> /git-reflog\n> /git-relink\n> /git-remote\n> +/git-remote-bzr\n> /git-remote-http\n> /git-remote-https\n> /git-remote-ftp\n> /git-remote-ftps\n> /git-remote-fd\n> +/git-remote-hg\n> /git-remote-ext\n> /git-remote-testgit\n> /git-remote-testpy\n> diff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile\n> index 55abf0b..98150b4 100644\n> --- a/contrib/remote-helpers/Makefile\n> +++ b/contrib/remote-helpers/Makefile\n> @@ -1,9 +1,9 @@\n> TESTS := $(wildcard test-*.t)\n> SCRIPTS := $(wildcard git-remote-*.py)\n> +LINKS := $(addprefix ../../,$(patsubst %.py,%,$(SCRIPTS)))\n> \n> export T := $(addprefix $(CURDIR)/,$(TESTS))\n> export MAKE := $(MAKE) -e\n> -export PATH := $(CURDIR):$(PATH)\n> export TEST_LINT := test-lint-executable test-lint-shell-syntax\n> export TEST_DIRECTORY := $(CURDIR)/../../t\n> \n> @@ -15,10 +15,15 @@ all: $(SCRIPTS)\n> install:\n> \t$(MAKE) -C ../.. install-python-script\n> \n> -test: all\n> +links: all $(LINKS)\n> +\n> +test: links\n> \t$(MAKE) -C ../../t $@\n> \n> -$(TESTS): all\n> +$(LINKS):\n> +\tln -sf contrib/remote-helpers/$(notdir $@) ../..\n> +\n> +$(TESTS): links\n> \t$(MAKE) -C ../../t $(CURDIR)/$@\n> \n> -.PHONY: all install test $(TESTS)\n> +.PHONY: all install test links $(TESTS)\n"},{"id":"218716","messageId":"51a56ce142986_807b33e18100084@nysa.mail","threadId":"33925","inReplyTo":"7vmwrezx7n.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 2/4] remote-helpers: rename tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-29T02:50:09Z","receivedAt":"2013-05-29T02:50:09Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Junio C Hamano wrote:\n> Felipe Contreras writes:\n> \n> > The .t extension is more standard for sharness tests.\n> >\n> > Signed-off-by: Felipe Contreras \n> > ---\n> \n> Is that \"sharness\" test the sh script testsuite forked from our\n> testsuite?\n> \n> I do not see how it makes sense to copy how they deviate from us\n> back to our codebase, especially if we plan to eventually move some\n> of these tests out of contrib/ area, but even without such a plan in\n> the future.\n\nThey deviate from us, we deviate from them, whatever. We are a single project,\nwhat more than one project does is more standard.\n\n% man prove\n\n--ext Set the extension for tests (default '.t')\n\n-- \nFelipe Contreras\n"},{"id":"218857","messageId":"7v8v2xvhbu.fsf@alter.siamese.dyndns.org","threadId":"33925","inReplyTo":"51a56ce142986_807b33e18100084@nysa.mail","subject":"Re: [PATCH 2/4] remote-helpers: rename tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-29T17:14:45Z","receivedAt":"2013-05-29T17:14:45Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n>> I do not see how it makes sense to copy how they deviate from us\n>> back to our codebase, especially if we plan to eventually move some\n>> of these tests out of contrib/ area, but even without such a plan in\n>> the future.\n>\n> They deviate from us, we deviate from them, whatever. We are a single project,\n> what more than one project does is more standard.\n\nWe are a single project, so it is better to consistently follow the\nlocal convention established here.\n\nIf your proposal were to\n\n - Convert t/*.sh to end with .t intead, to change the project\n convention, and\n\n - Make contrib/ things also conform to that new convention.\n\nit may make some sense to discuss the pros and cons of such a move,\nbut changing only contrib/ has no effect other than making it even\nless consistent with the rest of the project.\n"},{"id":"218865","messageId":"CAMP44s2-Of=AS9Jg7YAXnZ2346ozWPS4gL5irh0devwpkdBKmQ@mail.gmail.com","threadId":"33925","inReplyTo":"7v8v2xvhbu.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 2/4] remote-helpers: rename tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-29T17:56:36Z","receivedAt":"2013-05-29T17:56:36Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>>> I do not see how it makes sense to copy how they deviate from us\n>>> back to our codebase, especially if we plan to eventually move some\n>>> of these tests out of contrib/ area, but even without such a plan in\n>>> the future.\n>>\n>> They deviate from us, we deviate from them, whatever. We are a single project,\n>> what more than one project does is more standard.\n>\n> We are a single project, so it is better to consistently follow the\n> local convention established here.\n>\n> If your proposal were to\n>\n> - Convert t/*.sh to end with .t intead, to change the project\n> convention, and\n>\n> - Make contrib/ things also conform to that new convention.\n>\n> it may make some sense to discuss the pros and cons of such a move,\n> but changing only contrib/ has no effect other than making it even\n> less consistent with the rest of the project.\n\nIt's already inconsistent with the rest of the project, as they are\nnot named tNNNN-foo.sh.\n\nIf you want I can give it a try at renaming all the tests in the whole\nproject to *.t, but I don't think you are truly interested in finding\na better extension for our tests.\n\n-- \nFelipe Contreras\n"},{"id":"218875","messageId":"7v61y1tymh.fsf@alter.siamese.dyndns.org","threadId":"33925","inReplyTo":"CAMP44s2-Of=AS9Jg7YAXnZ2346ozWPS4gL5irh0devwpkdBKmQ@mail.gmail.com","subject":"Re: [PATCH 2/4] remote-helpers: rename tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-29T18:44:06Z","receivedAt":"2013-05-29T18:44:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano wrote:\n>> Felipe Contreras writes:\n>>\n>>>> I do not see how it makes sense to copy how they deviate from us\n>>>> back to our codebase, especially if we plan to eventually move some\n>>>> of these tests out of contrib/ area, but even without such a plan in\n>>>> the future.\n>>>\n>>> They deviate from us, we deviate from them, whatever. We are a single project,\n>>> what more than one project does is more standard.\n>>\n>> We are a single project, so it is better to consistently follow the\n>> local convention established here.\n>>\n>> If your proposal were to\n>>\n>> - Convert t/*.sh to end with .t intead, to change the project\n>> convention, and\n>>\n>> - Make contrib/ things also conform to that new convention.\n>>\n>> it may make some sense to discuss the pros and cons of such a move,\n>> but changing only contrib/ has no effect other than making it even\n>> less consistent with the rest of the project.\n>\n> It's already inconsistent with the rest of the project, as they are\n> not named tNNNN-foo.sh.\n\nCorrect; that is why I said \"even less consistent\".\n\n> If you want I can give it a try at renaming all the tests in the whole\n> project to *.t, but I don't think you are truly interested in finding\n> a better extension for our tests.\n\nAgain, correct. I do not think it is worth the trouble to renaming\nthem to *.t at this moment.\n\nHaving said that, I suspect that in the very longer term it might\nturn out to be a good thing to do (if we want to make our test suite\nrunnable under other people's tools that expect .t suffix, for\nexample). But I do not think that is the topic of this patch under\ndiscussion.\n"},{"id":"218885","messageId":"CAMP44s1ig9FvkPNBAmmBOKaH9iWoEYN5kfom_t0wpqPGrqpqVw@mail.gmail.com","threadId":"33925","inReplyTo":"7v61y1tymh.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 2/4] remote-helpers: rename tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-29T19:32:59Z","receivedAt":"2013-05-29T19:32:59Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Wed, May 29, 2013 at 1:44 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>> On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano wrote:\n>>> Felipe Contreras writes:\n>>>\n>>>>> I do not see how it makes sense to copy how they deviate from us\n>>>>> back to our codebase, especially if we plan to eventually move some\n>>>>> of these tests out of contrib/ area, but even without such a plan in\n>>>>> the future.\n>>>>\n>>>> They deviate from us, we deviate from them, whatever. We are a single project,\n>>>> what more than one project does is more standard.\n>>>\n>>> We are a single project, so it is better to consistently follow the\n>>> local convention established here.\n>>>\n>>> If your proposal were to\n>>>\n>>> - Convert t/*.sh to end with .t intead, to change the project\n>>> convention, and\n>>>\n>>> - Make contrib/ things also conform to that new convention.\n>>>\n>>> it may make some sense to discuss the pros and cons of such a move,\n>>> but changing only contrib/ has no effect other than making it even\n>>> less consistent with the rest of the project.\n>>\n>> It's already inconsistent with the rest of the project, as they are\n>> not named tNNNN-foo.sh.\n>\n> Correct; that is why I said \"even less consistent\".\n>\n>> If you want I can give it a try at renaming all the tests in the whole\n>> project to *.t, but I don't think you are truly interested in finding\n>> a better extension for our tests.\n>\n> Again, correct. I do not think it is worth the trouble to renaming\n> them to *.t at this moment.\n>\n> Having said that, I suspect that in the very longer term it might\n> turn out to be a good thing to do (if we want to make our test suite\n> runnable under other people's tools that expect .t suffix, for\n> example). But I do not think that is the topic of this patch under\n> discussion.\n\nThat's right. I just think if we didn't have the burden of so many\nexisting tests, and had the chance to pick the test extension from\nscratch, it should be .t.\n\n-- \nFelipe Contreras\n"}]}