{"thread":{"id":"33894","subject":"[PATCH] guilt: fix date parsing","startedAt":"2013-05-22T03:13:31Z","lastAt":"2013-05-22T13:31:20Z","messageCount":4,"participants":["Theodore Ts'o","Josef 'Jeff' Sipek"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"218142","messageId":"1369192411-8842-1-git-send-email-tytso@mit.edu","threadId":"33894","inReplyTo":null,"subject":"[PATCH] guilt: fix date parsing","fromName":"Theodore Ts'o","fromEmail":"tytso@mit.edu","sentAt":"2013-05-22T03:13:31Z","receivedAt":"2013-05-22T03:13:31Z","isPatch":true,"sender":{"key":"tytso@mit.edu","avatar":"https://avatars.githubusercontent.com/u/51416?v=4"},"body":"If the date field has a space in it, such as:\n\n   Date: Tue, 14 May 2013 18:37:15 +0200\n\npreviously guilt would go belly up:\n\n   + export GIT_AUTHOR_DATE=Tue, 14 May 2013 18:37:15 +0200\n   /usr/local/bin/guilt: 571: export: 14: bad variable name\n\nFix this.\n\nSigned-off-by: \"Theodore Ts'o\" <tytso@mit.edu>\n---\n guilt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/guilt b/guilt\nindex 9953bdf..6e8d542 100755\n--- a/guilt\n+++ b/guilt\n@@ -568,7 +568,7 @@ commit()\n \t\t\t\tauthor_date_str=`sed -n -e '/^Date:/ { s/^Date: //; p; q; }; /^(diff |---$|--- )/ q' \"$p\"`\n \t\t\tfi\n \t\t\tif [ ! -z \"$author_date_str\" ]; then\n-\t\t\t\texport GIT_AUTHOR_DATE=`echo $author_date_str`\n+\t\t\t\texport GIT_AUTHOR_DATE=\"$author_date_str\"\n \t\t\tfi\n \t\tfi\n \n-- \n1.7.12.rc0.22.gcdd159b\n"},{"id":"218144","messageId":"20130522033921.GB101217@meili.valhalla.31bits.net","threadId":"33894","inReplyTo":"1369192411-8842-1-git-send-email-tytso@mit.edu","subject":"Re: [PATCH] guilt: fix date parsing","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2013-05-22T03:39:21Z","receivedAt":"2013-05-22T03:39:21Z","isPatch":true,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"I applied this one and the \"guilt: skip empty line after...\" patch.\n\nJeff.\n\nOn Tue, May 21, 2013 at 11:13:31PM -0400, Theodore Ts'o wrote:\n> If the date field has a space in it, such as:\n> \n>    Date: Tue, 14 May 2013 18:37:15 +0200\n> \n> previously guilt would go belly up:\n> \n>    + export GIT_AUTHOR_DATE=Tue, 14 May 2013 18:37:15 +0200\n>    /usr/local/bin/guilt: 571: export: 14: bad variable name\n> \n> Fix this.\n> \n> Signed-off-by: \"Theodore Ts'o\" <tytso@mit.edu>\n> ---\n>  guilt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/guilt b/guilt\n> index 9953bdf..6e8d542 100755\n> --- a/guilt\n> +++ b/guilt\n> @@ -568,7 +568,7 @@ commit()\n>  \t\t\t\tauthor_date_str=`sed -n -e '/^Date:/ { s/^Date: //; p; q; }; /^(diff |---$|--- )/ q' \"$p\"`\n>  \t\t\tfi\n>  \t\t\tif [ ! -z \"$author_date_str\" ]; then\n> -\t\t\t\texport GIT_AUTHOR_DATE=`echo $author_date_str`\n> +\t\t\t\texport GIT_AUTHOR_DATE=\"$author_date_str\"\n>  \t\t\tfi\n>  \t\tfi\n>  \n> -- \n> 1.7.12.rc0.22.gcdd159b\n> \n\n-- \nThe obvious mathematical breakthrough would be development of an easy way to\nfactor large prime numbers.\n\t\t- Bill Gates, The Road Ahead, pg. 265\n"},{"id":"218164","messageId":"20130522121010.GA2777@thunk.org","threadId":"33894","inReplyTo":"20130522033921.GB101217@meili.valhalla.31bits.net","subject":"Re: [PATCH] guilt: fix date parsing","fromName":"Theodore Ts'o","fromEmail":"tytso@mit.edu","sentAt":"2013-05-22T12:10:10Z","receivedAt":"2013-05-22T12:10:10Z","isPatch":true,"sender":{"key":"tytso@mit.edu","avatar":"https://avatars.githubusercontent.com/u/51416?v=4"},"body":"On Tue, May 21, 2013 at 11:39:21PM -0400, Josef 'Jeff' Sipek wrote:\n> I applied this one and the \"guilt: skip empty line after...\" patch.\n\nThanks!  BTW, it looks like you are not using \"git am -s\" to apply\nthese patches?  The reason why I ask is that whatever you're using\nisn't removing the [XXX] subject prefix (e.g., [PATCH] or [PATCH -v2]\nwhich is useful for mailing lists, but less useful in the git commit\ndescriptions.\n\nIf you're using guilt, do you have some script that preformats a Unix\nmbox into guilt-friendly files?  If so, maybe it would be good to\nmodify it to strip out the [PATCH] annotations.  If not, let me know,\nsince I've been thinking about writing a script to take a Unix mbox,\nand bursts it into a separate patch-per-file with a series file\nsuitable for use by guilt, removing mail headers and doing other\nappropriate pre-parsing --- basically, a \"guilt am\" which works much\nlike \"git am\".  But if someone else has done this already, no point\nduplicating effort.  :-)\n\n\t\t\t\t\t\t- Ted\n"},{"id":"218173","messageId":"20130522133120.GA13731@poseidon.cudanet.local","threadId":"33894","inReplyTo":"20130522121010.GA2777@thunk.org","subject":"Re: [PATCH] guilt: fix date parsing","fromName":"Josef 'Jeff' Sipek","fromEmail":"jeffpc@josefsipek.net","sentAt":"2013-05-22T13:31:20Z","receivedAt":"2013-05-22T13:31:20Z","isPatch":true,"sender":{"key":"jeffpc@josefsipek.net","avatar":null},"body":"On Wed, May 22, 2013 at 08:10:10AM -0400, Theodore Ts'o wrote:\n> On Tue, May 21, 2013 at 11:39:21PM -0400, Josef 'Jeff' Sipek wrote:\n> > I applied this one and the \"guilt: skip empty line after...\" patch.\n> \n> Thanks!  BTW, it looks like you are not using \"git am -s\" to apply\n> these patches?  The reason why I ask is that whatever you're using\n> isn't removing the [XXX] subject prefix (e.g., [PATCH] or [PATCH -v2]\n> which is useful for mailing lists, but less useful in the git commit\n> descriptions.\n> \n> If you're using guilt, do you have some script that preformats a Unix\n> mbox into guilt-friendly files?  If so, maybe it would be good to\n> modify it to strip out the [PATCH] annotations.  If not, let me know,\n> since I've been thinking about writing a script to take a Unix mbox,\n> and bursts it into a separate patch-per-file with a series file\n> suitable for use by guilt, removing mail headers and doing other\n> appropriate pre-parsing --- basically, a \"guilt am\" which works much\n> like \"git am\".  But if someone else has done this already, no point\n> duplicating effort.  :-)\n\nYou are correct.  I just `guilt import -P blah /tmp/mdir/cur/X` and then\nhand-edit the patch to remove headers.  Last night I was thinking about\nmaking a `guilt import-mbox` that'd import a mbox or maildir.  I don't know\noff the top of my head how much `git am` would help in this instance.\n\nFeel free to make the import-mbox or whatever command :)\n\nJeff.\n\n-- \nOnly two things are infinite, the universe and human stupidity, and I'm not\nsure about the former.\n\t\t- Albert Einstein\n"}]}