{"thread":{"id":"33892","subject":"[PATCH] guilt: skip empty line after from: line in patch descriptoin","startedAt":"2013-05-22T02:43:13Z","lastAt":"2013-05-22T02:43:13Z","messageCount":1,"participants":["Theodore Ts'o"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"218137","messageId":"1369190593-6363-1-git-send-email-tytso@mit.edu","threadId":"33892","inReplyTo":null,"subject":"[PATCH] guilt: skip empty line after from: line in patch descriptoin","fromName":"Theodore Ts'o","fromEmail":"tytso@mit.edu","sentAt":"2013-05-22T02:43:13Z","receivedAt":"2013-05-22T02:43:13Z","isPatch":true,"sender":{"key":"tytso@mit.edu","avatar":"https://avatars.githubusercontent.com/u/51416?v=4"},"body":"Commit 2cc8d353d7ecb broke manually written patch descriptions of the\nform:\n\n    > Frobnozzle: this is a patch subject\n    >\n    > From: Fred McNurk <fred@mcnurt.foo>\n    >\n    > This is the patch description\n\nCommit 8f88f953580a0 partially fixed things by filtering out the From:\nfield, but it did not filter out the empty line (if present) after the\nFrom: field, so it resulted in commit bodies which looked like this:\n\n    > Frobnozzle: this is a patch subject\n    >\n    >\n    > This is the patch description\n\ninstead of\n\n    > Frobnozzle: this is a patch subject\n    >\n    > This is the patch description\n\nThe ext4 patch queue has used this format for years, and this change\nshould not break other patches which look like mail headers and\nbodies.\n\nSigned-off-by: \"Theodore Ts'o\" <tytso@mit.edu>\n---\n guilt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/guilt b/guilt\nindex 4edd1ad..309437a 100755\n--- a/guilt\n+++ b/guilt\n@@ -365,7 +365,7 @@ do_get_header()\n BEGIN{body=0; subj=0}\n /^Subject:/ && (body == 0 && subj == 0){subj=1; print substr($0, 10) \"\\n\"; next}\n /^(Subject:|Author:|Date:|commit)/ && (body == 0){next}\n-/^From:/ {next}\n+/^From:/ {body=0; next}\n /^(Commit-ID:|Gitweb:|AuthorDate:|Committer:CommitDate:)/ && (body == 0){next}\n /^[ \\t\\f\\n\\r\\v]*$/ && (body==0){next}\n /^.*$/ && (body==0){body=1}\n-- \n1.7.12.rc0.22.gcdd159b\n"}]}