{"thread":{"id":"33871","subject":"[PATCH] remote-hg: set stdout to binary mode on win32","startedAt":"2013-05-19T11:53:48Z","lastAt":"2013-05-20T18:18:32Z","messageCount":3,"participants":["Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"217895","messageId":"1368964428-1059-1-git-send-email-felipe.contreras@gmail.com","threadId":"33871","inReplyTo":null,"subject":"[PATCH] remote-hg: set stdout to binary mode on win32","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-19T11:53:48Z","receivedAt":"2013-05-19T11:53:48Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"From: Amit Bakshi <ambakshi@gmail.com>\n\ngit clone hangs on windows, and file.write would return errno 22 inside\nof mercurial's windows.winstdout wrapper class. This patch sets stdout's\nmode to binary, fixing both issues.\n\nSigned-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n contrib/remote-helpers/git-remote-hg | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg\nindex beb864b..01555dc 100755\n--- a/contrib/remote-helpers/git-remote-hg\n+++ b/contrib/remote-helpers/git-remote-hg\n@@ -954,6 +954,10 @@ def main(args):\n     marks_path = os.path.join(dirname, 'marks-hg')\n     marks = Marks(marks_path)\n \n+    if sys.platform == 'win32':\n+        import msvcrt\n+        msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)\n+\n     parser = Parser(repo)\n     for line in parser:\n         if parser.check('capabilities'):\n-- \n1.8.3.rc3.286.g3d43083\n"},{"id":"217898","messageId":"CAMP44s32tF01P5=Go+cdh8x8m9c0c5e=SR4jpx_Zi38yQrGk7w@mail.gmail.com","threadId":"33871","inReplyTo":"1368964428-1059-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] remote-hg: set stdout to binary mode on win32","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-19T12:00:43Z","receivedAt":"2013-05-19T12:00:43Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, May 19, 2013 at 6:53 AM, Felipe Contreras\n<felipe.contreras@gmail.com> wrote:\n> From: Amit Bakshi <ambakshi@gmail.com>\n>\n> git clone hangs on windows, and file.write would return errno 22 inside\n> of mercurial's windows.winstdout wrapper class. This patch sets stdout's\n> mode to binary, fixing both issues.\n\nForgot:\n[fc: cleaned up]\n\n> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n\n-- \nFelipe Contreras\n"},{"id":"217991","messageId":"7vehd1v7k7.fsf@alter.siamese.dyndns.org","threadId":"33871","inReplyTo":"CAMP44s32tF01P5=Go+cdh8x8m9c0c5e=SR4jpx_Zi38yQrGk7w@mail.gmail.com","subject":"Re: [PATCH] remote-hg: set stdout to binary mode on win32","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-20T18:18:32Z","receivedAt":"2013-05-20T18:18:32Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras <felipe.contreras@gmail.com> writes:\n\n> On Sun, May 19, 2013 at 6:53 AM, Felipe Contreras\n> <felipe.contreras@gmail.com> wrote:\n>> From: Amit Bakshi <ambakshi@gmail.com>\n>>\n>> git clone hangs on windows, and file.write would return errno 22 inside\n>> of mercurial's windows.winstdout wrapper class. This patch sets stdout's\n>> mode to binary, fixing both issues.\n>\n> Forgot:\n> [fc: cleaned up]\n>\n>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n\nThanks, sounds like this is meant for 'master'?\n"}]}