{"thread":{"id":"3387","subject":"gitk patch display corner-case bug","startedAt":"2006-02-18T23:36:18Z","lastAt":"2006-02-19T14:38:57Z","messageCount":3,"participants":["Karl Hasselström","Paul Mackerras"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"16394","messageId":"20060218233618.GA29025@diana.vm.bytemark.co.uk","threadId":"3387","inReplyTo":null,"subject":"gitk patch display corner-case bug","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2006-02-18T23:36:18Z","receivedAt":"2006-02-18T23:36:18Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"In a recently updated stgit tree,\n\n  $ git-diff 51cb39db\\^ 51cb39db\n  diff --git a/templates/covermail.tmpl b/templates/covermail.tmpl\n  index 9789c9c..44cd19e 100644\n  --- a/templates/covermail.tmpl\n  +++ b/templates/covermail.tmpl\n  @@ -4,5 +4,5 @@ Date: %(date)s\n   %(endofheaders)s\n   The following series implements...\n   \n  ---\n  +-- \n   Signature\n\nThat is, a trailing whitespace was added after the two dashes.\nHowever, gitk displays this as\n\n  index 9789c9c..44cd19e 100644\n  @@ -2,7 +2,7 @@ From: %(maintainer)s\n   Subject: [PATCH%(version)s%(number)s] Series short description\n   Date: %(date)s\n   %(endofheaders)s\n   The following series implements...\n   \n  +-- \n   Signature\n\nTotally correct except that it omitted the line consisting of only\nthree dashes.\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"},{"id":"16405","messageId":"17400.20764.131417.903578@cargo.ozlabs.ibm.com","threadId":"3387","inReplyTo":"20060218233618.GA29025@diana.vm.bytemark.co.uk","subject":"Re: gitk patch display corner-case bug","fromName":"Paul Mackerras","fromEmail":"paulus@samba.org","sentAt":"2006-02-19T11:06:04Z","receivedAt":"2006-02-19T11:06:04Z","isPatch":false,"sender":{"key":"paulus@samba.org","avatar":"https://avatars.githubusercontent.com/u/1606439?v=4"},"body":"Karl Hasselström writes:\n\n> Totally correct except that it omitted the line consisting of only\n> three dashes.\n\nCould you check that the missing line is present in the output from\ngit-rev-list --header --parents --topo-order please?\n\nPaul.\n"},{"id":"16410","messageId":"20060219143857.GA5268@diana.vm.bytemark.co.uk","threadId":"3387","inReplyTo":"17400.20764.131417.903578@cargo.ozlabs.ibm.com","subject":"Re: gitk patch display corner-case bug","fromName":"Karl Hasselström","fromEmail":"kha@treskal.com","sentAt":"2006-02-19T14:38:57Z","receivedAt":"2006-02-19T14:38:57Z","isPatch":false,"sender":{"key":"kha@treskal.com","avatar":"https://gravatar.com/avatar/f0120c734b5279b345075a28521e1ac66acb20c9913ffe9bf6ae97e53f7f3f13?d=mp&s=160"},"body":"On 2006-02-19 22:06:04 +1100, Paul Mackerras wrote:\n\n> Karl Hasselström writes:\n>\n> > Totally correct except that it omitted the line consisting of only\n> > three dashes.\n>\n> Could you check that the missing line is present in the output from\n> git-rev-list --header --parents --topo-order please?\n\nI'm not sure I follow you. The affected commit is listed first by\n\"git-rev-list --header --parents --topo-order 51cb39db\", but that\ncommad doesn't show diffs, so the missing line is not there.\n\n-- \nKarl Hasselström, kha@treskal.com\n      www.treskal.com/kalle\n"}]}