{"thread":{"id":"33858","subject":"[PATCH 0/2] remote-helpers: test fixes","startedAt":"2013-05-17T21:10:06Z","lastAt":"2013-05-20T23:22:31Z","messageCount":12,"participants":["Felipe Contreras","Junio C Hamano","David Aguilar"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"217761","messageId":"1368825008-2815-1-git-send-email-felipe.contreras@gmail.com","threadId":"33858","inReplyTo":null,"subject":"[PATCH 0/2] remote-helpers: test fixes","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-17T21:10:06Z","receivedAt":"2013-05-17T21:10:06Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Hi,\n\nI've setup a project in Travis CI for continuous integration with very good\nresults, however, I had to apply a couple of fixes.\n\nI'm not sure if this is v1.8.3 material, but here they are.\n\nhttps://travis-ci.org/felipec/git/builds/7262886\n\nFelipe Contreras (2):\n remote-helpers: tests: use python directly\n remote-hg: tests: fix hg merge\n\n contrib/remote-helpers/test-bzr.sh | 2 +-\n contrib/remote-helpers/test-hg-bidi.sh | 2 +-\n contrib/remote-helpers/test-hg-hg-git.sh | 11 ++++++-----\n contrib/remote-helpers/test-hg.sh | 2 +-\n 4 files changed, 9 insertions(+), 8 deletions(-)\n\n-- \n1.8.3.rc2.542.g24820ba\n"},{"id":"217762","messageId":"1368825008-2815-2-git-send-email-felipe.contreras@gmail.com","threadId":"33858","inReplyTo":"1368825008-2815-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 1/2] remote-helpers: tests: use python directly","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-17T21:10:07Z","receivedAt":"2013-05-17T21:10:07Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"These remote helpers use 'env python', not PYTHON_PATH, so that's where\nwe should check for the extensions. Otherwise, if 'python' is not\nPYTHON_PATH (e.g. /usr/bin/python: Makefile's default), there will be a\nmismatch between the python libraries actually accessible to the remote\nhelpers.\n\nSuggested by: Torsten Bögershausen \nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/test-bzr.sh | 2 +-\n contrib/remote-helpers/test-hg-bidi.sh | 2 +-\n contrib/remote-helpers/test-hg-hg-git.sh | 4 ++--\n contrib/remote-helpers/test-hg.sh | 2 +-\n 4 files changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh\nindex 5dfa070..2c89caa 100755\n--- a/contrib/remote-helpers/test-bzr.sh\n+++ b/contrib/remote-helpers/test-bzr.sh\n@@ -12,7 +12,7 @@ if ! test_have_prereq PYTHON; then\n \ttest_done\n fi\n \n-if ! \"$PYTHON_PATH\" -c 'import bzrlib'; then\n+if ! python -c 'import bzrlib'; then\n \tskip_all='skipping remote-bzr tests; bzr not available'\n \ttest_done\n fi\ndiff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.sh\nindex f569697..2c693d0 100755\n--- a/contrib/remote-helpers/test-hg-bidi.sh\n+++ b/contrib/remote-helpers/test-hg-bidi.sh\n@@ -15,7 +15,7 @@ if ! test_have_prereq PYTHON; then\n \ttest_done\n fi\n \n-if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n+if ! python -c 'import mercurial'; then\n \tskip_all='skipping remote-hg tests; mercurial not available'\n \ttest_done\n fi\ndiff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.sh\nindex 8440341..fbad2b9 100755\n--- a/contrib/remote-helpers/test-hg-hg-git.sh\n+++ b/contrib/remote-helpers/test-hg-hg-git.sh\n@@ -15,12 +15,12 @@ if ! test_have_prereq PYTHON; then\n \ttest_done\n fi\n \n-if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n+if ! python -c 'import mercurial'; then\n \tskip_all='skipping remote-hg tests; mercurial not available'\n \ttest_done\n fi\n \n-if ! \"$PYTHON_PATH\" -c 'import hggit'; then\n+if ! python -c 'import hggit'; then\n \tskip_all='skipping remote-hg tests; hg-git not available'\n \ttest_done\n fi\ndiff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh\nindex 8de2aa7..ce03fa3 100755\n--- a/contrib/remote-helpers/test-hg.sh\n+++ b/contrib/remote-helpers/test-hg.sh\n@@ -15,7 +15,7 @@ if ! test_have_prereq PYTHON; then\n \ttest_done\n fi\n \n-if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n+if ! python -c 'import mercurial'; then\n \tskip_all='skipping remote-hg tests; mercurial not available'\n \ttest_done\n fi\n-- \n1.8.3.rc2.542.g24820ba\n"},{"id":"217763","messageId":"1368825008-2815-3-git-send-email-felipe.contreras@gmail.com","threadId":"33858","inReplyTo":"1368825008-2815-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 2/2] remote-hg: tests: fix hg merge","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-17T21:10:08Z","receivedAt":"2013-05-17T21:10:08Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Let's specify a merge tool, otherwise mercurial might open one and hang\nour tests waiting for user input.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/test-hg-hg-git.sh | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.sh\nindex fbad2b9..f18e26f 100755\n--- a/contrib/remote-helpers/test-hg-hg-git.sh\n+++ b/contrib/remote-helpers/test-hg-hg-git.sh\n@@ -103,11 +103,12 @@ setup () {\n \tgit config --global receive.denycurrentbranch warn\n \tgit config --global remote-hg.hg-git-compat true\n \n-\tHGEDITOR=/usr/bin/true\n+\tHGEDITOR=true\n+\tHGMERGE=true\n \n \tGIT_AUTHOR_DATE=\"2007-01-01 00:00:00 +0230\"\n \tGIT_COMMITTER_DATE=\"$GIT_AUTHOR_DATE\"\n-\texport HGEDITOR GIT_AUTHOR_DATE GIT_COMMITTER_DATE\n+\texport HGEDITOR HGMERGE GIT_AUTHOR_DATE GIT_COMMITTER_DATE\n }\n \n setup\n@@ -197,7 +198,7 @@ test_expect_success 'merge conflict 1' '\n \techo C > afile &&\n \thg ci -m \"A->C\" &&\n \n-\thg merge -r1 || true &&\n+\thg merge -r1 &&\n \techo C > afile &&\n \thg resolve -m afile &&\n \thg ci -m \"merge to C\"\n-- \n1.8.3.rc2.542.g24820ba\n"},{"id":"217774","messageId":"7vwqqxujby.fsf@alter.siamese.dyndns.org","threadId":"33858","inReplyTo":"1368825008-2815-2-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH 1/2] remote-helpers: tests: use python directly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-18T02:12:49Z","receivedAt":"2013-05-18T02:12:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> These remote helpers use 'env python', not PYTHON_PATH, so that's where\n> we should check for the extensions. Otherwise, if 'python' is not\n> PYTHON_PATH (e.g. /usr/bin/python: Makefile's default), there will be a\n> mismatch between the python libraries actually accessible to the remote\n> helpers.\n\nWhat I am reading here is that what the \"helper\" uses and what the\n\"test\" checks to see if it can use the \"helper\" were different; and\nthis patch fixes that misalignment by testing what the \"helper\"\nactually uses.\n\nSo it is a right thing to do in that sense.\n\nI however am having this nagging feeling that I may be missing\nsomething subtle here. Comments from others are very much welcome.\n\nWill queue but the result will be on tomorrow's pushout.\n\nThanks.\n\n> Suggested by: Torsten Bögershausen \n> Signed-off-by: Felipe Contreras \n> ---\n> contrib/remote-helpers/test-bzr.sh | 2 +-\n> contrib/remote-helpers/test-hg-bidi.sh | 2 +-\n> contrib/remote-helpers/test-hg-hg-git.sh | 4 ++--\n> contrib/remote-helpers/test-hg.sh | 2 +-\n> 4 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh\n> index 5dfa070..2c89caa 100755\n> --- a/contrib/remote-helpers/test-bzr.sh\n> +++ b/contrib/remote-helpers/test-bzr.sh\n> @@ -12,7 +12,7 @@ if ! test_have_prereq PYTHON; then\n> \ttest_done\n> fi\n> \n> -if ! \"$PYTHON_PATH\" -c 'import bzrlib'; then\n> +if ! python -c 'import bzrlib'; then\n> \tskip_all='skipping remote-bzr tests; bzr not available'\n> \ttest_done\n> fi\n> diff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.sh\n> index f569697..2c693d0 100755\n> --- a/contrib/remote-helpers/test-hg-bidi.sh\n> +++ b/contrib/remote-helpers/test-hg-bidi.sh\n> @@ -15,7 +15,7 @@ if ! test_have_prereq PYTHON; then\n> \ttest_done\n> fi\n> \n> -if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n> +if ! python -c 'import mercurial'; then\n> \tskip_all='skipping remote-hg tests; mercurial not available'\n> \ttest_done\n> fi\n> diff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.sh\n> index 8440341..fbad2b9 100755\n> --- a/contrib/remote-helpers/test-hg-hg-git.sh\n> +++ b/contrib/remote-helpers/test-hg-hg-git.sh\n> @@ -15,12 +15,12 @@ if ! test_have_prereq PYTHON; then\n> \ttest_done\n> fi\n> \n> -if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n> +if ! python -c 'import mercurial'; then\n> \tskip_all='skipping remote-hg tests; mercurial not available'\n> \ttest_done\n> fi\n> \n> -if ! \"$PYTHON_PATH\" -c 'import hggit'; then\n> +if ! python -c 'import hggit'; then\n> \tskip_all='skipping remote-hg tests; hg-git not available'\n> \ttest_done\n> fi\n> diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh\n> index 8de2aa7..ce03fa3 100755\n> --- a/contrib/remote-helpers/test-hg.sh\n> +++ b/contrib/remote-helpers/test-hg.sh\n> @@ -15,7 +15,7 @@ if ! test_have_prereq PYTHON; then\n> \ttest_done\n> fi\n> \n> -if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n> +if ! python -c 'import mercurial'; then\n> \tskip_all='skipping remote-hg tests; mercurial not available'\n> \ttest_done\n> fi\n"},{"id":"217776","messageId":"CAJDDKr6Qnx5ddBn=6reNOY44CxaDgD254H7M3K2mb8bbd8jpmA@mail.gmail.com","threadId":"33858","inReplyTo":"7vwqqxujby.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 1/2] remote-helpers: tests: use python directly","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2013-05-18T02:51:18Z","receivedAt":"2013-05-18T02:51:18Z","isPatch":true,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>> These remote helpers use 'env python', not PYTHON_PATH, so that's where\n>> we should check for the extensions. Otherwise, if 'python' is not\n>> PYTHON_PATH (e.g. /usr/bin/python: Makefile's default), there will be a\n>> mismatch between the python libraries actually accessible to the remote\n>> helpers.\n>\n> What I am reading here is that what the \"helper\" uses and what the\n> \"test\" checks to see if it can use the \"helper\" were different; and\n> this patch fixes that misalignment by testing what the \"helper\"\n> actually uses.\n>\n> So it is a right thing to do in that sense.\n>\n> I however am having this nagging feeling that I may be missing\n> something subtle here. Comments from others are very much welcome.\n\nYes, this is correct. Another way to skin this cat would be to do\nsearch/replace in a Makefile to burn in the PYTHON_PATH similar to how\nwe do for the .sh scripts and other .py files in the main Makefile.\nThe remote helpers are in contrib/ so they do not go through the main\nMakefile, which is the root cause.\n\nLonger-term, it would be good to treat these uniformly, but this is no\nworse for now.\n\n> Will queue but the result will be on tomorrow's pushout.\n>\n> Thanks.\n>\n>> Suggested by: Torsten Bögershausen \n>> Signed-off-by: Felipe Contreras \n>> ---\n>> contrib/remote-helpers/test-bzr.sh | 2 +-\n>> contrib/remote-helpers/test-hg-bidi.sh | 2 +-\n>> contrib/remote-helpers/test-hg-hg-git.sh | 4 ++--\n>> contrib/remote-helpers/test-hg.sh | 2 +-\n>> 4 files changed, 5 insertions(+), 5 deletions(-)\n>>\n>> diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh\n>> index 5dfa070..2c89caa 100755\n>> --- a/contrib/remote-helpers/test-bzr.sh\n>> +++ b/contrib/remote-helpers/test-bzr.sh\n>> @@ -12,7 +12,7 @@ if ! test_have_prereq PYTHON; then\n>> test_done\n>> fi\n>>\n>> -if ! \"$PYTHON_PATH\" -c 'import bzrlib'; then\n>> +if ! python -c 'import bzrlib'; then\n>> skip_all='skipping remote-bzr tests; bzr not available'\n>> test_done\n>> fi\n>> diff --git a/contrib/remote-helpers/test-hg-bidi.sh b/contrib/remote-helpers/test-hg-bidi.sh\n>> index f569697..2c693d0 100755\n>> --- a/contrib/remote-helpers/test-hg-bidi.sh\n>> +++ b/contrib/remote-helpers/test-hg-bidi.sh\n>> @@ -15,7 +15,7 @@ if ! test_have_prereq PYTHON; then\n>> test_done\n>> fi\n>>\n>> -if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n>> +if ! python -c 'import mercurial'; then\n>> skip_all='skipping remote-hg tests; mercurial not available'\n>> test_done\n>> fi\n>> diff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.sh\n>> index 8440341..fbad2b9 100755\n>> --- a/contrib/remote-helpers/test-hg-hg-git.sh\n>> +++ b/contrib/remote-helpers/test-hg-hg-git.sh\n>> @@ -15,12 +15,12 @@ if ! test_have_prereq PYTHON; then\n>> test_done\n>> fi\n>>\n>> -if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n>> +if ! python -c 'import mercurial'; then\n>> skip_all='skipping remote-hg tests; mercurial not available'\n>> test_done\n>> fi\n>>\n>> -if ! \"$PYTHON_PATH\" -c 'import hggit'; then\n>> +if ! python -c 'import hggit'; then\n>> skip_all='skipping remote-hg tests; hg-git not available'\n>> test_done\n>> fi\n>> diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh\n>> index 8de2aa7..ce03fa3 100755\n>> --- a/contrib/remote-helpers/test-hg.sh\n>> +++ b/contrib/remote-helpers/test-hg.sh\n>> @@ -15,7 +15,7 @@ if ! test_have_prereq PYTHON; then\n>> test_done\n>> fi\n>>\n>> -if ! \"$PYTHON_PATH\" -c 'import mercurial'; then\n>> +if ! python -c 'import mercurial'; then\n>> skip_all='skipping remote-hg tests; mercurial not available'\n>> test_done\n>> fi\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n\n\n\n--\nDavid\n"},{"id":"217777","messageId":"CAMP44s1w98hDbJx10PFDnS3YeYhFAHDyw=O2LdwCendLG6DVQQ@mail.gmail.com","threadId":"33858","inReplyTo":"CAJDDKr6Qnx5ddBn=6reNOY44CxaDgD254H7M3K2mb8bbd8jpmA@mail.gmail.com","subject":"Re: [PATCH 1/2] remote-helpers: tests: use python directly","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-18T03:04:49Z","receivedAt":"2013-05-18T03:04:49Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, May 17, 2013 at 9:51 PM, David Aguilar wrote:\n> On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote:\n>> Felipe Contreras writes:\n>>\n>>> These remote helpers use 'env python', not PYTHON_PATH, so that's where\n>>> we should check for the extensions. Otherwise, if 'python' is not\n>>> PYTHON_PATH (e.g. /usr/bin/python: Makefile's default), there will be a\n>>> mismatch between the python libraries actually accessible to the remote\n>>> helpers.\n>>\n>> What I am reading here is that what the \"helper\" uses and what the\n>> \"test\" checks to see if it can use the \"helper\" were different; and\n>> this patch fixes that misalignment by testing what the \"helper\"\n>> actually uses.\n>>\n>> So it is a right thing to do in that sense.\n>>\n>> I however am having this nagging feeling that I may be missing\n>> something subtle here. Comments from others are very much welcome.\n>\n> Yes, this is correct. Another way to skin this cat would be to do\n> search/replace in a Makefile to burn in the PYTHON_PATH similar to how\n> we do for the .sh scripts and other .py files in the main Makefile.\n> The remote helpers are in contrib/ so they do not go through the main\n> Makefile, which is the root cause.\n>\n> Longer-term, it would be good to treat these uniformly, but this is no\n> worse for now.\n\nYeap, I initially thought it would be tricky to implement in the\nrather minimal Makefile, but it seems it wouldn't. Whoever, I still\nfind it useful that I don't have to run 'make' to test these, and I\nthink it's nice that people can download directly as the final name\n('git-remote-hg'), and don't have to rename. And since these aren't\ninstalled with 'make install' anyway, I don't see any big hurry.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"217843","messageId":"7v4ndz1o8q.fsf@alter.siamese.dyndns.org","threadId":"33858","inReplyTo":"CAJDDKr6Qnx5ddBn=6reNOY44CxaDgD254H7M3K2mb8bbd8jpmA@mail.gmail.com","subject":"Re: [PATCH 1/2] remote-helpers: tests: use python directly","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-19T06:24:05Z","receivedAt":"2013-05-19T06:24:05Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"David Aguilar writes:\n\n> On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote:\n>\n>> So it is a right thing to do in that sense.\n>>\n>> I however am having this nagging feeling that I may be missing\n>> something subtle here. Comments from others are very much welcome.\n>\n> Yes, this is correct. Another way to skin this cat would be to do\n> search/replace in a Makefile to burn in the PYTHON_PATH similar to how\n> we do for the .sh scripts and other .py files in the main Makefile.\n> The remote helpers are in contrib/ so they do not go through the main\n> Makefile, which is the root cause.\n>\n> Longer-term, it would be good to treat these uniformly, but this is no\n> worse for now.\n\nAhh, so my \"nagging feeling\" was that remote-helpers could in theory\nbe updated to follow the PYTHON_PATH like the rest of the system and\nmatching these two in that direction is the better longer-term fix?\n\nOk, with that in mind, I still think the patch under discussion is\nan immediate solution that is fine as-is.\n\nI somehow thought that there were valid reasons that we could not do\nso for some technical reason (e.g. the instalation of python used to\nrun hg and/or bzr via these remote helpers and the installation of\npython we use may need to be different?). As long as the right\nlonger-term direction is not \"we cannot fundamentally unify them\",\nthen I am very happy.\n\nI was worried that we might end up having to define random fine\ngained knobs like PYTHON_FOR_HG_PATH to allow tuning these.\n\nThanks for a clarification.\n"},{"id":"217853","messageId":"51988c5e6cefb_76e0f31e20808a6@nysa.mail","threadId":"33858","inReplyTo":"7v4ndz1o8q.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 1/2] remote-helpers: tests: use python directly","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-19T08:25:02Z","receivedAt":"2013-05-19T08:25:02Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Junio C Hamano wrote:\n> David Aguilar writes:\n> \n> > On Fri, May 17, 2013 at 7:12 PM, Junio C Hamano wrote:\n> >\n> >> So it is a right thing to do in that sense.\n> >>\n> >> I however am having this nagging feeling that I may be missing\n> >> something subtle here. Comments from others are very much welcome.\n> >\n> > Yes, this is correct. Another way to skin this cat would be to do\n> > search/replace in a Makefile to burn in the PYTHON_PATH similar to how\n> > we do for the .sh scripts and other .py files in the main Makefile.\n> > The remote helpers are in contrib/ so they do not go through the main\n> > Makefile, which is the root cause.\n> >\n> > Longer-term, it would be good to treat these uniformly, but this is no\n> > worse for now.\n> \n> Ahh, so my \"nagging feeling\" was that remote-helpers could in theory\n> be updated to follow the PYTHON_PATH like the rest of the system and\n> matching these two in that direction is the better longer-term fix?\n\nIndeed, and I already have patches for that. FTR, the Makefile does loop\nthrough the main Makefile, which is what made implementing this so easy.\n\n> I somehow thought that there were valid reasons that we could not do\n> so for some technical reason (e.g. the instalation of python used to\n> run hg and/or bzr via these remote helpers and the installation of\n> python we use may need to be different?). As long as the right\n> longer-term direction is not \"we cannot fundamentally unify them\",\n> then I am very happy.\n\nI didn't think of that, and it might actually be a problem: I don't think\nMercurial works with python 3, and Bazaar probably never will.\n\nBut I don't think the current situation of always using 'python' helps either\nway.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"218012","messageId":"7vd2sltgj4.fsf@alter.siamese.dyndns.org","threadId":"33858","inReplyTo":"1368825008-2815-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH 0/2] remote-helpers: test fixes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-20T22:47:43Z","receivedAt":"2013-05-20T22:47:43Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> Hi,\n>\n> I've setup a project in Travis CI for continuous integration with very good\n> results, however, I had to apply a couple of fixes.\n>\n> I'm not sure if this is v1.8.3 material, but here they are.\n\nThanks; I'll queue them at the tip of fc/remote-hg to graduate soon\nafter 1.8.3, then.\n\n>\n> https://travis-ci.org/felipec/git/builds/7262886\n>\n> Felipe Contreras (2):\n> remote-helpers: tests: use python directly\n> remote-hg: tests: fix hg merge\n>\n> contrib/remote-helpers/test-bzr.sh | 2 +-\n> contrib/remote-helpers/test-hg-bidi.sh | 2 +-\n> contrib/remote-helpers/test-hg-hg-git.sh | 11 ++++++-----\n> contrib/remote-helpers/test-hg.sh | 2 +-\n> 4 files changed, 9 insertions(+), 8 deletions(-)\n"},{"id":"218018","messageId":"CAMP44s0gK5EgD-pJb1NVrpJvYeyXmN_nS6MT7renFHhne1cZJg@mail.gmail.com","threadId":"33858","inReplyTo":"7vd2sltgj4.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 0/2] remote-helpers: test fixes","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-20T22:53:34Z","receivedAt":"2013-05-20T22:53:34Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Mon, May 20, 2013 at 5:47 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>> Hi,\n>>\n>> I've setup a project in Travis CI for continuous integration with very good\n>> results, however, I had to apply a couple of fixes.\n>>\n>> I'm not sure if this is v1.8.3 material, but here they are.\n>\n> Thanks; I'll queue them at the tip of fc/remote-hg to graduate soon\n> after 1.8.3, then.\n\nNo, they should be graduated first. The tip of fc/remote-hg is in pu,\nno? I have rebased that branch and squashed some fixes so every commit\nworks on all versions of Mercurial. I will resend all the patches, the\nonly reason I haven't done so is that I didn't want to create more\nnoise before v1.8.3, and you said I was the one taking the decision\nwhen to merge remote-helper stuff to master.\n\nSo this should go to master, the rest of fc/remote-hg should be\ndropped, I can resend any time, and I suppose after v1.8.3 is the best\ntime.\n\n-- \nFelipe Contreras\n"},{"id":"218020","messageId":"7v7gits0r9.fsf@alter.siamese.dyndns.org","threadId":"33858","inReplyTo":"CAMP44s0gK5EgD-pJb1NVrpJvYeyXmN_nS6MT7renFHhne1cZJg@mail.gmail.com","subject":"Re: [PATCH 0/2] remote-helpers: test fixes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-20T23:13:46Z","receivedAt":"2013-05-20T23:13:46Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> On Mon, May 20, 2013 at 5:47 PM, Junio C Hamano wrote:\n>> Felipe Contreras writes:\n>>\n>>> Hi,\n>>>\n>>> I've setup a project in Travis CI for continuous integration with very good\n>>> results, however, I had to apply a couple of fixes.\n>>>\n>>> I'm not sure if this is v1.8.3 material, but here they are.\n>>\n>> Thanks; I'll queue them at the tip of fc/remote-hg to graduate soon\n>> after 1.8.3, then.\n>\n> No, they should be graduated first. The tip of fc/remote-hg is in pu,\n> no? I have rebased that branch and squashed some fixes so every commit\n> works on all versions of Mercurial. I will resend all the patches, the\n> only reason I haven't done so is that I didn't want to create more\n> noise before v1.8.3, and you said I was the one taking the decision\n> when to merge remote-helper stuff to master.\n\nThen is this v1.8.3 material? Please do not stay \"I'm not sure\" for\nvery long. I do not think we want -rc4 only for a contrib/ stuff.\n\nFor today's integration run I didn't want to wait so tentatively\nthey are queued at the tip of fc/remote-hg, and it is too late to\nredo everything I did today, but I can requeue them for 'master' in\nthe tomorrow's cycle if you want.\n"},{"id":"218021","messageId":"CAMP44s13hjYzqHuBHKjGXRbf6PTyOiX=_EeuwAdLdZ9wSo-oQQ@mail.gmail.com","threadId":"33858","inReplyTo":"7v7gits0r9.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 0/2] remote-helpers: test fixes","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-20T23:22:31Z","receivedAt":"2013-05-20T23:22:31Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Mon, May 20, 2013 at 6:13 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>> On Mon, May 20, 2013 at 5:47 PM, Junio C Hamano wrote:\n>>> Felipe Contreras writes:\n>>>\n>>>> Hi,\n>>>>\n>>>> I've setup a project in Travis CI for continuous integration with very good\n>>>> results, however, I had to apply a couple of fixes.\n>>>>\n>>>> I'm not sure if this is v1.8.3 material, but here they are.\n>>>\n>>> Thanks; I'll queue them at the tip of fc/remote-hg to graduate soon\n>>> after 1.8.3, then.\n>>\n>> No, they should be graduated first. The tip of fc/remote-hg is in pu,\n>> no? I have rebased that branch and squashed some fixes so every commit\n>> works on all versions of Mercurial. I will resend all the patches, the\n>> only reason I haven't done so is that I didn't want to create more\n>> noise before v1.8.3, and you said I was the one taking the decision\n>> when to merge remote-helper stuff to master.\n>\n> Then is this v1.8.3 material? Please do not stay \"I'm not sure\" for\n> very long. I do not think we want -rc4 only for a contrib/ stuff.\n\nI think this could very well fit into v1.8.3, but there's no rush, it\ncan wait until after.\n\n> For today's integration run I didn't want to wait so tentatively\n> they are queued at the tip of fc/remote-hg, and it is too late to\n> redo everything I did today, but I can requeue them for 'master' in\n> the tomorrow's cycle if you want.\n\nI think 'next' is fine, they could go into 'master' to improve the\ntesting of what's already there, but it probably won't matter much.\nMoreover, it's not fixing test regressions; the issues have been there\npretty much since day one, and if nobody has found them by now it\nprobably won't change anything for v1.8.3.\n\nMy main motivation is that with these patches I could test a pristine\n'master' branch directly into travis-ci.\n\n-- \nFelipe Contreras\n"}]}