{"thread":{"id":"33853","subject":"[PATCH] remote-bzr: fixes for older versions of bzr","startedAt":"2013-05-17T17:10:19Z","lastAt":"2013-05-17T18:45:12Z","messageCount":5,"participants":["Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"217733","messageId":"1368810619-18419-1-git-send-email-felipe.contreras@gmail.com","threadId":"33853","inReplyTo":null,"subject":"[PATCH] remote-bzr: fixes for older versions of bzr","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-17T17:10:19Z","receivedAt":"2013-05-17T17:10:19Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Up to v2.0.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex ad42317..51b4a29 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -31,6 +31,7 @@ import bzrlib.transport\n import bzrlib.errors\n import bzrlib.ui\n import bzrlib.urlutils\n+import bzrlib.branch\n \n import sys\n import os\n@@ -788,7 +789,7 @@ def get_remote_branch(origin, remote_branch, name):\n return branch\n \n def find_branches(repo, wanted):\n- transport = repo.user_transport\n+ transport = repo.bzrdir.root_transport\n \n for fn in transport.iter_files_recursive():\n if not fn.endswith('.bzr/branch-format'):\n@@ -922,7 +923,8 @@ def main(args):\n if not os.path.exists(dirname):\n os.makedirs(dirname)\n \n- bzrlib.ui.ui_factory.be_quiet(True)\n+ if hasattr(bzrlib.ui.ui_factory, 'be_quiet'):\n+ bzrlib.ui.ui_factory.be_quiet(True)\n \n repo = get_repo(url, alias)\n \n-- \n1.8.3.rc2.542.g24820ba\n"},{"id":"217740","messageId":"CAMP44s1-RdmM9vs=XSvN1KNOh92Zr=nJWHGR0MZZV9BFXG_3JQ@mail.gmail.com","threadId":"33853","inReplyTo":"1368810619-18419-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] remote-bzr: fixes for older versions of bzr","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-17T17:25:39Z","receivedAt":"2013-05-17T17:25:39Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, May 17, 2013 at 12:10 PM, Felipe Contreras\n wrote:\n> Up to v2.0.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n> contrib/remote-helpers/git-remote-bzr | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n\nWe want this for v1.8.3, otherwise it wouldn't work in older versions of bzr.\n\n-- \nFelipe Contreras\n"},{"id":"217747","messageId":"7v7gixzdsj.fsf@alter.siamese.dyndns.org","threadId":"33853","inReplyTo":"CAMP44s1-RdmM9vs=XSvN1KNOh92Zr=nJWHGR0MZZV9BFXG_3JQ@mail.gmail.com","subject":"Re: [PATCH] remote-bzr: fixes for older versions of bzr","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-17T18:01:16Z","receivedAt":"2013-05-17T18:01:16Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> On Fri, May 17, 2013 at 12:10 PM, Felipe Contreras\n> wrote:\n>> Up to v2.0.\n\nIs that \"down to v2.0\"?\n\n>>\n>> Signed-off-by: Felipe Contreras \n>> ---\n>> contrib/remote-helpers/git-remote-bzr | 6 ++++--\n>> 1 file changed, 4 insertions(+), 2 deletions(-)\n>\n> We want this for v1.8.3, otherwise it wouldn't work in older versions of bzr.\n\nI take it that somebody tested this with both new and old versions\nso that the old way you rewrote the code with is still supported by\nthe more recent ones.\n\nWill apply before 1.8.3-rc3; thanks.\n"},{"id":"217750","messageId":"CAMP44s0WbkaWsU+VOCsd2THEQJkTU-67_z5Kb37j=gS9U1MV2Q@mail.gmail.com","threadId":"33853","inReplyTo":"7v7gixzdsj.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] remote-bzr: fixes for older versions of bzr","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-05-17T18:20:17Z","receivedAt":"2013-05-17T18:20:17Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, May 17, 2013 at 1:01 PM, Junio C Hamano wrote:\n> Felipe Contreras writes:\n>\n>> On Fri, May 17, 2013 at 12:10 PM, Felipe Contreras\n>> wrote:\n>>> Up to v2.0.\n>\n> Is that \"down to v2.0\"?\n>\n>>>\n>>> Signed-off-by: Felipe Contreras \n>>> ---\n>>> contrib/remote-helpers/git-remote-bzr | 6 ++++--\n>>> 1 file changed, 4 insertions(+), 2 deletions(-)\n>>\n>> We want this for v1.8.3, otherwise it wouldn't work in older versions of bzr.\n>\n> I take it that somebody tested this with both new and old versions\n> so that the old way you rewrote the code with is still supported by\n> the more recent ones.\n\nYeah. I wrote a script that tests in a bunch of versions.\n\nAlso, I'm fiddling with travis-ci:\nhttps://travis-ci.org/felipec/git/builds/7258332\n\n-- \nFelipe Contreras\n"},{"id":"217753","messageId":"7vli7dxx6v.fsf@alter.siamese.dyndns.org","threadId":"33853","inReplyTo":"CAMP44s0WbkaWsU+VOCsd2THEQJkTU-67_z5Kb37j=gS9U1MV2Q@mail.gmail.com","subject":"Re: [PATCH] remote-bzr: fixes for older versions of bzr","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-17T18:45:12Z","receivedAt":"2013-05-17T18:45:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> On Fri, May 17, 2013 at 1:01 PM, Junio C Hamano wrote:\n>> Felipe Contreras writes:\n>>\n>>> On Fri, May 17, 2013 at 12:10 PM, Felipe Contreras\n>>> wrote:\n>>>> Up to v2.0.\n>>\n>> Is that \"down to v2.0\"?\n\n\n\nIs that 'down to v2.0'?\n\n\n\n>>\n>>>>\n>>>> Signed-off-by: Felipe Contreras \n>>>> ---\n>>>> contrib/remote-helpers/git-remote-bzr | 6 ++++--\n>>>> 1 file changed, 4 insertions(+), 2 deletions(-)\n>>>\n>>> We want this for v1.8.3, otherwise it wouldn't work in older versions of bzr.\n>>\n>> I take it that somebody tested this with both new and old versions\n>> so that the old way you rewrote the code with is still supported by\n>> the more recent ones.\n>\n> Yeah. I wrote a script that tests in a bunch of versions.\n\nNice to know ;-)\n\n>\n> Also, I'm fiddling with travis-ci:\n> https://travis-ci.org/felipec/git/builds/7258332\n"}]}