{"thread":{"id":"33800","subject":"[PATCH] teach the user to be nice to git and let him say please sometimes","startedAt":"2013-05-11T20:20:16Z","lastAt":"2013-05-13T20:47:38Z","messageCount":9,"participants":["Heiko Voigt","Ramkumar Ramachandra","Duy Nguyen","Junio C Hamano","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"217058","messageId":"20130511201928.GA22938@book.hvoigt.net","threadId":"33800","inReplyTo":null,"subject":"[PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2013-05-11T20:20:16Z","receivedAt":"2013-05-11T20:20:16Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"Since ages we do not care about our program enough. Lets not treat them\nas slaves anymore and say please.\n\nSigned-off-by: Heiko Voigt \nSigned-off-by: Jonathan Nieder \nSigned-off-by: Jens Lehmann \nSigned-off-by: Thomas Rast \nSigned-off-by: Johan Herland \n---\n .gitignore | 1 +\n Makefile | 1 +\n builtin.h | 1 +\n builtin/config.c | 23 ++-----------------\n builtin/please.c | 9 ++++++++\n cache.h | 1 +\n config.c | 23 +++++++++++++++++++\n contrib/completion/git-prompt.sh | 5 +++-\n git.c | 49 +++++++++++++++++++++++++++++++++++++++-\n 9 files changed, 90 insertions(+), 23 deletions(-)\n create mode 100644 builtin/please.c\n\ndiff --git a/.gitignore b/.gitignore\nindex 6669bf0..28dd4cf 100644\n--- a/.gitignore\n+++ b/.gitignore\n@@ -105,6 +105,7 @@\n /git-parse-remote\n /git-patch-id\n /git-peek-remote\n+/git-please\n /git-prune\n /git-prune-packed\n /git-pull\ndiff --git a/Makefile b/Makefile\nindex 0f931a2..7e22cc0 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -943,6 +943,7 @@ BUILTIN_OBJS += builtin/pack-objects.o\n BUILTIN_OBJS += builtin/pack-redundant.o\n BUILTIN_OBJS += builtin/pack-refs.o\n BUILTIN_OBJS += builtin/patch-id.o\n+BUILTIN_OBJS += builtin/please.o\n BUILTIN_OBJS += builtin/prune-packed.o\n BUILTIN_OBJS += builtin/prune.o\n BUILTIN_OBJS += builtin/push.o\ndiff --git a/builtin.h b/builtin.h\nindex faef559..6fe1d5f 100644\n--- a/builtin.h\n+++ b/builtin.h\n@@ -105,6 +105,7 @@ extern int cmd_notes(int argc, const char **argv, const char *prefix);\n extern int cmd_pack_objects(int argc, const char **argv, const char *prefix);\n extern int cmd_pack_redundant(int argc, const char **argv, const char *prefix);\n extern int cmd_patch_id(int argc, const char **argv, const char *prefix);\n+extern int cmd_please(int argc, const char **argv, const char *prefix);\n extern int cmd_prune(int argc, const char **argv, const char *prefix);\n extern int cmd_prune_packed(int argc, const char **argv, const char *prefix);\n extern int cmd_push(int argc, const char **argv, const char *prefix);\ndiff --git a/builtin/config.c b/builtin/config.c\nindex 33c9bf9..16b5152 100644\n--- a/builtin/config.c\n+++ b/builtin/config.c\n@@ -364,27 +364,8 @@ int cmd_config(int argc, const char **argv, const char *prefix)\n \t\tusage_with_options(builtin_config_usage, builtin_config_options);\n \t}\n \n-\tif (use_global_config) {\n-\t\tchar *user_config = NULL;\n-\t\tchar *xdg_config = NULL;\n-\n-\t\thome_config_paths(&user_config, &xdg_config, \"config\");\n-\n-\t\tif (!user_config)\n-\t\t\t/*\n-\t\t\t * It is unknown if HOME/.gitconfig exists, so\n-\t\t\t * we do not know if we should write to XDG\n-\t\t\t * location; error out even if XDG_CONFIG_HOME\n-\t\t\t * is set and points at a sane location.\n-\t\t\t */\n-\t\t\tdie(\"$HOME not set\");\n-\n-\t\tif (access_or_warn(user_config, R_OK) &&\n-\t\t xdg_config && !access_or_warn(xdg_config, R_OK))\n-\t\t\tgiven_config_file = xdg_config;\n-\t\telse\n-\t\t\tgiven_config_file = user_config;\n-\t}\n+\tif (use_global_config)\n+\t\tgiven_config_file = git_user_config();\n \telse if (use_system_config)\n \t\tgiven_config_file = git_etc_gitconfig();\n \telse if (use_local_config)\ndiff --git a/builtin/please.c b/builtin/please.c\nnew file mode 100644\nindex 0000000..aea8424\n--- /dev/null\n+++ b/builtin/please.c\n@@ -0,0 +1,9 @@\n+#include \"builtin.h\"\n+#include \"run-command.h\"\n+\n+int cmd_please(int argc, const char **argv, const char *prefix)\n+{\n+\tif (!strcmp(argv[1], \"-h\"))\n+\t\tusage(\"Sometimes\");\n+\treturn run_command_v_opt(argv+1, RUN_GIT_CMD);\n+}\ndiff --git a/cache.h b/cache.h\nindex 94ca1ac..73a9caf 100644\n--- a/cache.h\n+++ b/cache.h\n@@ -1164,6 +1164,7 @@ extern int git_config_set_multivar_in_file(const char *, const char *, const cha\n extern int git_config_rename_section(const char *, const char *);\n extern int git_config_rename_section_in_file(const char *, const char *, const char *);\n extern const char *git_etc_gitconfig(void);\n+extern const char *git_user_config(void);\n extern int check_repository_format_version(const char *var, const char *value, void *cb);\n extern int git_env_bool(const char *, int);\n extern int git_config_system(void);\ndiff --git a/config.c b/config.c\nindex aefd80b..8b3e473 100644\n--- a/config.c\n+++ b/config.c\n@@ -935,6 +935,29 @@ const char *git_etc_gitconfig(void)\n \treturn system_wide;\n }\n \n+const char *git_user_config(void)\n+{\n+\tchar *user_config = NULL;\n+\tchar *xdg_config = NULL;\n+\n+\thome_config_paths(&user_config, &xdg_config, \"config\");\n+\n+\tif (!user_config)\n+\t\t/*\n+\t\t * It is unknown if HOME/.gitconfig exists, so\n+\t\t * we do not know if we should write to XDG\n+\t\t * location; error out even if XDG_CONFIG_HOME\n+\t\t * is set and points at a sane location.\n+\t\t */\n+\t\tdie(\"$HOME not set\");\n+\n+\tif (access_or_warn(user_config, R_OK) &&\n+\t\t\txdg_config && !access_or_warn(xdg_config, R_OK))\n+\t\treturn xdg_config;\n+\telse\n+\t\treturn user_config;\n+}\n+\n int git_env_bool(const char *k, int def)\n {\n \tconst char *v = getenv(k);\ndiff --git a/contrib/completion/git-prompt.sh b/contrib/completion/git-prompt.sh\nindex eaf5c36..a455d72 100644\n--- a/contrib/completion/git-prompt.sh\n+++ b/contrib/completion/git-prompt.sh\n@@ -241,6 +241,7 @@ __git_ps1 ()\n \tlocal ps1pc_start='\\u@\\h:\\w '\n \tlocal ps1pc_end='\\$ '\n \tlocal printf_format=' (%s)'\n+\texport GIT_POLITENESS_CHECK_PASSED=\"Yes\"\n \n \tcase \"$#\" in\n \t\t2|3)\tpcmode=yes\n@@ -250,7 +251,8 @@ __git_ps1 ()\n \t\t;;\n \t\t0|1)\tprintf_format=\"${1:-$printf_format}\"\n \t\t;;\n-\t\t*)\treturn\n+\t\t*) unset GIT_POLITENESS_CHECK_PASSED\n+\t\t\treturn\n \t\t;;\n \tesac\n \n@@ -409,4 +411,5 @@ __git_ps1 ()\n \t\t\tprintf -- \"$printf_format\" \"$c${b##refs/heads/}${f:+ $f}$r$p\"\n \t\tfi\n \tfi\n+\tunset GIT_POLITENESS_CHECK_PASSED\n }\ndiff --git a/git.c b/git.c\nindex 1ada169..6c67cef 100644\n--- a/git.c\n+++ b/git.c\n@@ -19,6 +19,8 @@ const char git_more_info_string[] =\n \n static struct startup_info git_startup_info;\n static int use_pager = -1;\n+static int impolite_counter;\n+static int polite_counter;\n \n static void commit_pager_choice(void) {\n \tswitch (use_pager) {\n@@ -302,6 +304,48 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv)\n \treturn 0;\n }\n \n+static int read_polite_counter(const char *key, const char *value, void *data)\n+{\n+\tif (!strcmp(key, \"user.impolite\"))\n+\t\timpolite_counter = git_config_int(key, value);\n+\telse if (!strcmp(key, \"user.polite\"))\n+\t\tpolite_counter = git_config_int(key, value);\n+\treturn 0;\n+}\n+\n+static void check_politeness(const char *cmd)\n+{\n+\tconst char *user_config;\n+\tstruct strbuf buf = STRBUF_INIT;\n+\n+\tif (getenv(\"GIT_POLITENESS_CHECK_PASSED\"))\n+\t\treturn;\n+\n+\tsetenv(\"GIT_POLITENESS_CHECK_PASSED\", \"Yes\", 1);\n+\n+\tgit_config_early(read_polite_counter, NULL, NULL);\n+\tif (!strcmp(cmd, \"please\")) {\n+\t\timpolite_counter = 0;\n+\t\tpolite_counter++;\n+\t} else {\n+\t\timpolite_counter++;\n+\t\tpolite_counter = 0;\n+\t}\n+\n+\tif (impolite_counter > 10)\n+\t\tdie(\"Error: Learn some manners, say please some time!\");\n+\tif (polite_counter > 10)\n+\t\tdie(\"Error: Too many please! I don't believe you.\");\n+\n+\tuser_config = git_user_config();\n+\tstrbuf_addf(&buf, \"%d\", polite_counter);\n+\tgit_config_set_in_file(user_config, \"user.polite\", buf.buf);\n+\tstrbuf_reset(&buf);\n+\tstrbuf_addf(&buf, \"%d\", impolite_counter);\n+\tgit_config_set_in_file(user_config, \"user.impolite\", buf.buf);\n+\tstrbuf_release(&buf);\n+}\n+\n static void handle_internal_command(int argc, const char **argv)\n {\n \tconst char *cmd = argv[0];\n@@ -379,6 +423,7 @@ static void handle_internal_command(int argc, const char **argv)\n \t\t{ \"patch-id\", cmd_patch_id },\n \t\t{ \"peek-remote\", cmd_ls_remote, RUN_SETUP_GENTLY },\n \t\t{ \"pickaxe\", cmd_blame, RUN_SETUP },\n+\t\t{ \"please\", cmd_please, RUN_SETUP_GENTLY },\n \t\t{ \"prune\", cmd_prune, RUN_SETUP },\n \t\t{ \"prune-packed\", cmd_prune_packed, RUN_SETUP },\n \t\t{ \"push\", cmd_push, RUN_SETUP },\n@@ -441,8 +486,11 @@ static void handle_internal_command(int argc, const char **argv)\n \n \tfor (i = 0; i < ARRAY_SIZE(commands); i++) {\n \t\tstruct cmd_struct *p = commands+i;\n+\n \t\tif (strcmp(p->cmd, cmd))\n \t\t\tcontinue;\n+\n+\t\tcheck_politeness(cmd);\n \t\texit(run_builtin(p, argc, argv));\n \t}\n }\n-- \n1.8.3.rc1.44.gb387c77\n"},{"id":"217064","messageId":"CALkWK0knyTbK5sLXvqB60BHXXQ0T8-yF9wtaQvukAu1kW8bkDg@mail.gmail.com","threadId":"33800","inReplyTo":"20130511201928.GA22938@book.hvoigt.net","subject":"Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-05-12T10:07:04Z","receivedAt":"2013-05-12T10:07:04Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Heiko Voigt wrote:\n> Since ages we do not care about our program enough. Lets not treat them\n> as slaves anymore and say please.\n\n> 9 files changed, 90 insertions(+), 23 deletions(-)\n\nUm, why such an elaborate joke?\n"},{"id":"217065","messageId":"CACsJy8A+vjtwnB0LStVS3Q9v2JaKcMDa0sATr9H==X3EhQt6Jg@mail.gmail.com","threadId":"33800","inReplyTo":"20130511201928.GA22938@book.hvoigt.net","subject":"Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2013-05-12T10:23:15Z","receivedAt":"2013-05-12T10:23:15Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Sun, May 12, 2013 at 3:20 AM, Heiko Voigt wrote:\n> Since ages we do not care about our program enough. Lets not treat them\n> as slaves anymore and say please.\n>\n> Signed-off-by: Heiko Voigt \n> Signed-off-by: Jonathan Nieder \n> Signed-off-by: Jens Lehmann \n> Signed-off-by: Thomas Rast \n> Signed-off-by: Johan Herland \n\nA product of Git Berlin Meetup?\n\n> +static void check_politeness(const char *cmd)\n> +{\n> + const char *user_config;\n> + struct strbuf buf = STRBUF_INIT;\n> +\n> + if (getenv(\"GIT_POLITENESS_CHECK_PASSED\"))\n> + return;\n> +\n> + setenv(\"GIT_POLITENESS_CHECK_PASSED\", \"Yes\", 1);\n> +\n> + git_config_early(read_polite_counter, NULL, NULL);\n> + if (!strcmp(cmd, \"please\")) {\n> + impolite_counter = 0;\n> + polite_counter++;\n> + } else {\n> + impolite_counter++;\n> + polite_counter = 0;\n> + }\n> +\n> + if (impolite_counter > 10)\n> + die(\"Error: Learn some manners, say please some time!\");\n> + if (polite_counter > 10)\n> + die(\"Error: Too many please! I don't believe you.\");\n\nNAK. If we truly care, we need better AI here!\n\n> +\n> + user_config = git_user_config();\n> + strbuf_addf(&buf, \"%d\", polite_counter);\n> + git_config_set_in_file(user_config, \"user.polite\", buf.buf);\n> + strbuf_reset(&buf);\n> + strbuf_addf(&buf, \"%d\", impolite_counter);\n> + git_config_set_in_file(user_config, \"user.impolite\", buf.buf);\n> + strbuf_release(&buf);\n> +}\n--\nDuy\n"},{"id":"217093","messageId":"7vobcfvqu1.fsf@alter.siamese.dyndns.org","threadId":"33800","inReplyTo":"20130511201928.GA22938@book.hvoigt.net","subject":"Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-12T21:19:34Z","receivedAt":"2013-05-12T21:19:34Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Heiko Voigt writes:\n\n> Since ages we do not care about our program enough. Lets not treat them\n> as slaves anymore and say please.\n>\n> Signed-off-by: Heiko Voigt \n> Signed-off-by: Jonathan Nieder \n> Signed-off-by: Jens Lehmann \n> Signed-off-by: Thomas Rast \n> Signed-off-by: Johan Herland \n\nSo these were the ones present on the dev-day?\n\nI actually would have expected, from the \"please\" title, the\nopposite, us saying \"please\" to the user, either once in a while in\nthe advice messages we give to them, or perhaps in the en_POLITE\nlocale ;-)\n\n> .gitignore | 1 +\n> Makefile | 1 +\n> builtin.h | 1 +\n> builtin/config.c | 23 ++-----------------\n> builtin/please.c | 9 ++++++++\n> cache.h | 1 +\n> config.c | 23 +++++++++++++++++++\n> contrib/completion/git-prompt.sh | 5 +++-\n> git.c | 49 +++++++++++++++++++++++++++++++++++++++-\n\nThere is no test to protect this feature from future breakages?\n"},{"id":"217162","messageId":"20130513133035.GA3561@book-mint","threadId":"33800","inReplyTo":"CACsJy8A+vjtwnB0LStVS3Q9v2JaKcMDa0sATr9H==X3EhQt6Jg@mail.gmail.com","subject":"Re: Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2013-05-13T13:30:35Z","receivedAt":"2013-05-13T13:30:35Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"On Sun, May 12, 2013 at 05:23:15PM +0700, Duy Nguyen wrote:\n> On Sun, May 12, 2013 at 3:20 AM, Heiko Voigt wrote:\n> > Since ages we do not care about our program enough. Lets not treat them\n> > as slaves anymore and say please.\n> >\n> > Signed-off-by: Heiko Voigt \n> > Signed-off-by: Jonathan Nieder \n> > Signed-off-by: Jens Lehmann \n> > Signed-off-by: Thomas Rast \n> > Signed-off-by: Johan Herland \n> \n> A product of Git Berlin Meetup?\n\nYep :-)\n\n> > +static void check_politeness(const char *cmd)\n> > +{\n> > + const char *user_config;\n> > + struct strbuf buf = STRBUF_INIT;\n> > +\n> > + if (getenv(\"GIT_POLITENESS_CHECK_PASSED\"))\n> > + return;\n> > +\n> > + setenv(\"GIT_POLITENESS_CHECK_PASSED\", \"Yes\", 1);\n> > +\n> > + git_config_early(read_polite_counter, NULL, NULL);\n> > + if (!strcmp(cmd, \"please\")) {\n> > + impolite_counter = 0;\n> > + polite_counter++;\n> > + } else {\n> > + impolite_counter++;\n> > + polite_counter = 0;\n> > + }\n> > +\n> > + if (impolite_counter > 10)\n> > + die(\"Error: Learn some manners, say please some time!\");\n> > + if (polite_counter > 10)\n> > + die(\"Error: Too many please! I don't believe you.\");\n> \n> NAK. If we truly care, we need better AI here!\n\nI agree but this patches goal was to implement the basic politeness\ninfrastructure. We planned to add more features, like inter-repository\njealousy, later. For inter-repository jealousy git would complain if you\nworked more with one repository than others you cloned and you'd for\nexample sometimes need a double please to satisfy it.\n\nCheers Heiko\n"},{"id":"217164","messageId":"20130513134415.GB3561@book-mint","threadId":"33800","inReplyTo":"7vobcfvqu1.fsf@alter.siamese.dyndns.org","subject":"Re: Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Heiko Voigt","fromEmail":"hvoigt@hvoigt.net","sentAt":"2013-05-13T13:44:15Z","receivedAt":"2013-05-13T13:44:15Z","isPatch":true,"sender":{"key":"hvoigt@hvoigt.net","avatar":"https://avatars.githubusercontent.com/u/184958?v=4"},"body":"Hi,\n\nOn Sun, May 12, 2013 at 02:19:34PM -0700, Junio C Hamano wrote:\n> Heiko Voigt writes:\n> \n> > Since ages we do not care about our program enough. Lets not treat them\n> > as slaves anymore and say please.\n> >\n> > Signed-off-by: Heiko Voigt \n> > Signed-off-by: Jonathan Nieder \n> > Signed-off-by: Jens Lehmann \n> > Signed-off-by: Thomas Rast \n> > Signed-off-by: Johan Herland \n> \n> So these were the ones present on the dev-day?\n\nNo this was just a random sample of the ones sitting at the same\nbeer garden table that this feature was implemented on.\n\n> I actually would have expected, from the \"please\" title, the\n> opposite, us saying \"please\" to the user, either once in a while in\n> the advice messages we give to them, or perhaps in the en_POLITE\n> locale ;-)\n\nThe en_POLITE is also a nice idea :-) We could split up the work on the\ntranslations amongst all people joining a git meetup.\n\n> > .gitignore | 1 +\n> > Makefile | 1 +\n> > builtin.h | 1 +\n> > builtin/config.c | 23 ++-----------------\n> > builtin/please.c | 9 ++++++++\n> > cache.h | 1 +\n> > config.c | 23 +++++++++++++++++++\n> > contrib/completion/git-prompt.sh | 5 +++-\n> > git.c | 49 +++++++++++++++++++++++++++++++++++++++-\n> \n> There is no test to protect this feature from future breakages?\n\nIn fact the whole testsuite should fail after the first 10 tests if you said\nplease right before running it. So since battery life is short and this\nfeature so important we did not bother to fix that. We already had\nenough please complaints during intermediate commits and entering the\nsigned-off messages. It is really annoying, you should try this patch! ;-)\nAnd it is especially unuseful when you are committing using git gui.\n\nCheers Heiko\n"},{"id":"217174","messageId":"CACsJy8Cj1pf1YqWLq1Hbgx9cDL96Kst9JkrcwwF8ELXU5BASLg@mail.gmail.com","threadId":"33800","inReplyTo":"20130513133035.GA3561@book-mint","subject":"Re: Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2013-05-13T13:58:47Z","receivedAt":"2013-05-13T13:58:47Z","isPatch":true,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"On Mon, May 13, 2013 at 8:30 PM, Heiko Voigt wrote:\n>> > + if (impolite_counter > 10)\n>> > + die(\"Error: Learn some manners, say please some time!\");\n>> > + if (polite_counter > 10)\n>> > + die(\"Error: Too many please! I don't believe you.\");\n>>\n>> NAK. If we truly care, we need better AI here!\n>\n> I agree but this patches goal was to implement the basic politeness\n> infrastructure. We planned to add more features, like inter-repository\n> jealousy, later. For inter-repository jealousy git would complain if you\n> worked more with one repository than others you cloned and you'd for\n> example sometimes need a double please to satisfy it.\n\nI'm still not happy with this direction. I propose we rewrite C Git in\nLisp first as a preparation step for git-please improvements. We could\ndrop support for all platforms but Lisp Machine along the way. That\nwould make all other Git implementations jealous.\n--\nDuy\n"},{"id":"217229","messageId":"87ppwur4tq.fsf@hexa.v.cablecom.net","threadId":"33800","inReplyTo":"20130513134415.GB3561@book-mint","subject":"Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Thomas Rast","fromEmail":"trast@inf.ethz.ch","sentAt":"2013-05-13T20:40:49Z","receivedAt":"2013-05-13T20:40:49Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"Heiko Voigt writes:\n\n> On Sun, May 12, 2013 at 02:19:34PM -0700, Junio C Hamano wrote:\n>> Heiko Voigt writes:\n>> \n>> > Signed-off-by: Heiko Voigt \n>> > Signed-off-by: Jonathan Nieder \n>> > Signed-off-by: Jens Lehmann \n>> > Signed-off-by: Thomas Rast \n>> > Signed-off-by: Johan Herland \n>> \n>> So these were the ones present on the dev-day?\n>\n> No this was just a random sample of the ones sitting at the same\n> beer garden table that this feature was implemented on.\n\nAlso see\n\n http://thomasrast.ch/pix/foss/20130509_gitmerge/DSC_7078.jpg.php\n\nfor an illustration of the history of this patch.\n\n\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"},{"id":"217230","messageId":"7vsj1qli8l.fsf@alter.siamese.dyndns.org","threadId":"33800","inReplyTo":"87ppwur4tq.fsf@hexa.v.cablecom.net","subject":"Re: [PATCH] teach the user to be nice to git and let him say please sometimes","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-13T20:47:38Z","receivedAt":"2013-05-13T20:47:38Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Thomas Rast writes:\n\n> Heiko Voigt writes:\n>\n>> On Sun, May 12, 2013 at 02:19:34PM -0700, Junio C Hamano wrote:\n>>> Heiko Voigt writes:\n>>> \n>>> > Signed-off-by: Heiko Voigt \n>>> > Signed-off-by: Jonathan Nieder \n>>> > Signed-off-by: Jens Lehmann \n>>> > Signed-off-by: Thomas Rast \n>>> > Signed-off-by: Johan Herland \n>>> \n>>> So these were the ones present on the dev-day?\n>>\n>> No this was just a random sample of the ones sitting at the same\n>> beer garden table that this feature was implemented on.\n>\n> Also see\n>\n> http://thomasrast.ch/pix/foss/20130509_gitmerge/DSC_7078.jpg.php\n>\n> for an illustration of the history of this patch.\n>\n> \n\nThanks for sharing. I see some familiar faces. Envy, envy...\n"}]}