{"thread":{"id":"33785","subject":"[PATCH] Makefile: fix default regex settings on Darwin","startedAt":"2013-05-11T05:08:33Z","lastAt":"2013-05-11T07:55:19Z","messageCount":5,"participants":["David Aguilar","Jonathan Nieder"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"216960","messageId":"1368248913-95188-1-git-send-email-davvid@gmail.com","threadId":"33785","inReplyTo":null,"subject":"[PATCH] Makefile: fix default regex settings on Darwin","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2013-05-11T05:08:33Z","receivedAt":"2013-05-11T05:08:33Z","isPatch":true,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"t0070-fundamental.sh fails on Mac OS X 10.8 by default.\nFix it by using Git's regex library.\n\nSigned-off-by: David Aguilar \n---\n\"make test\" fails right now; this fixes it.\nt0070-fundamental is how far it got last time.\nIt's still running now.. :-)\n\n Makefile | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Makefile b/Makefile\nindex 7e12999..4a462c0 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1057,6 +1057,7 @@ ifeq ($(uname_S),Darwin)\n \tCOMMON_DIGEST_SHA1 = YesPlease\n \tCOMMON_DIGEST_HMAC = YesPlease\n \tPTHREAD_LIBS =\n+\tNO_REGEX = YesPlease\n endif\n \n ifndef CC_LD_DYNPATH\n-- \n1.8.3.rc1.47.g6e51a5f\n"},{"id":"216966","messageId":"20130511063132.GF3394@elie","threadId":"33785","inReplyTo":"1368248913-95188-1-git-send-email-davvid@gmail.com","subject":"Re: [PATCH] Makefile: fix default regex settings on Darwin","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-05-11T06:31:32Z","receivedAt":"2013-05-11T06:31:32Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"David Aguilar wrote:\n\n> t0070-fundamental.sh fails on Mac OS X 10.8 by default.\n> Fix it by using Git's regex library.\n\nCan you say more about the failure? What does\n\n\t./t0070-fundamental.sh -v\n\nsay?\n\nCurious,\nJonathan\n"},{"id":"216967","messageId":"CAJDDKr5StD_bDr7+29qEYc4Lza+q8w=ZrHuwdSLwvCSru3YYWQ@mail.gmail.com","threadId":"33785","inReplyTo":"20130511063132.GF3394@elie","subject":"Re: [PATCH] Makefile: fix default regex settings on Darwin","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2013-05-11T06:44:11Z","receivedAt":"2013-05-11T06:44:11Z","isPatch":true,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"On Fri, May 10, 2013 at 11:31 PM, Jonathan Nieder wrote:\n> David Aguilar wrote:\n>\n>> t0070-fundamental.sh fails on Mac OS X 10.8 by default.\n>> Fix it by using Git's regex library.\n>\n> Can you say more about the failure? What does\n>\n> ./t0070-fundamental.sh -v\n>\n> say?\n\n[..snip...]\n\nexpecting success:\n# if this test fails, re-build git with NO_REGEX=1\ntest-regex\n\nfatal: regex bug confirmed: re-build git with NO_REGEX=1\nnot ok 4 - check for a bug in the regex routines\n#\n# # if this test fails, re-build git with NO_REGEX=1\n# test-regex\n#\n\n# failed 1 among 4 test(s)\n1..4\n--\nDavid\n"},{"id":"216968","messageId":"20130511070423.GG3394@elie","threadId":"33785","inReplyTo":"CAJDDKr5StD_bDr7+29qEYc4Lza+q8w=ZrHuwdSLwvCSru3YYWQ@mail.gmail.com","subject":"Re: [PATCH] Makefile: fix default regex settings on Darwin","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-05-11T07:04:23Z","receivedAt":"2013-05-11T07:04:23Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"David Aguilar wrote:\n\n> expecting success:\n> # if this test fails, re-build git with NO_REGEX=1\n> test-regex\n>\n> fatal: regex bug confirmed: re-build git with NO_REGEX=1\n\nThanks. Gah. That means that regcomp() with REG_NEWLINE is letting\n\n\t[^={} \\t]+\n\nmatch the newline in\n\n\t={}\\nfred\n\ndespite the POSIX requirement\n\n\tA in string shall not be matched by a period outside\n\ta bracket expression or by any form of a non-matching list\n\nwhere\n\n\tA non-matching list expression begins with a ('^')\n\tand specifies a list that shall match any single-character\n\tcollating element except for the expressions represented in\n\tthe list after the leading .\n\nand if I understand you correctly, this is a regression in Apple\nlibc. :(\n\nWith the commit message modified to mention the \"fatal: regex bug\nconfirmed: re-build git with NO_REGEX=1\" and uname -a output,\n\nReviewed-by: Jonathan Nieder \n\nDo you know if this has been reported to Apple and\nopenradar.appspot.com?\n"},{"id":"216971","messageId":"CAJDDKr5t+hVE-TpNbVWmLL4VFq-NGjuVhcyPG=quaf6icz+E4Q@mail.gmail.com","threadId":"33785","inReplyTo":"20130511070423.GG3394@elie","subject":"Re: [PATCH] Makefile: fix default regex settings on Darwin","fromName":"David Aguilar","fromEmail":"davvid@gmail.com","sentAt":"2013-05-11T07:55:19Z","receivedAt":"2013-05-11T07:55:19Z","isPatch":true,"sender":{"key":"davvid@gmail.com","avatar":"https://avatars.githubusercontent.com/u/13196?v=4"},"body":"On Sat, May 11, 2013 at 12:04 AM, Jonathan Nieder wrote:\n> David Aguilar wrote:\n>\n>> expecting success:\n>> # if this test fails, re-build git with NO_REGEX=1\n>> test-regex\n>>\n>> fatal: regex bug confirmed: re-build git with NO_REGEX=1\n>\n> Thanks. Gah. That means that regcomp() with REG_NEWLINE is letting\n>\n> [^={} \\t]+\n>\n> match the newline in\n>\n> ={}\\nfred\n>\n> despite the POSIX requirement\n>\n> A in string shall not be matched by a period outside\n> a bracket expression or by any form of a non-matching list\n>\n> where\n>\n> A non-matching list expression begins with a ('^')\n> and specifies a list that shall match any single-character\n> collating element except for the expressions represented in\n> the list after the leading .\n>\n> and if I understand you correctly, this is a regression in Apple\n> libc. :(\n>\n> With the commit message modified to mention the \"fatal: regex bug\n> confirmed: re-build git with NO_REGEX=1\" and uname -a output,\n>\n> Reviewed-by: Jonathan Nieder \n\nThanks. I can adjust the commit message and re-roll to make this patch 1/3.\n\n> Do you know if this has been reported to Apple and\n> openradar.appspot.com?\n\nI checked and nope, there are no bug reports. I tried to submit one\nby creating a \"new radar\" but that page said to go to\nbugreport.apple.com.\n\nI tried to login there but after entering my credentials I got, \"An\nerror has occurred. Please report the error to Apple Inc. by emailing\nthe error detail to devbugs@apple.com.\" Oh bother ;-)\n\nI refreshed the page and finally got in. I submitted a bug.. Problem # 13868200\n\nI hop on this laptop to test for cross-platform issues (I'm a Linux\nuser myself ;-) and it's been pretty good at finding 'em.\n--\nDavid\n"}]}