{"thread":{"id":"33732","subject":"[PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively","startedAt":"2013-05-06T12:35:46Z","lastAt":"2013-05-06T15:20:48Z","messageCount":2,"participants":["John Keeping","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"216492","messageId":"6bb37f45280373b96c2ae581db9bd87007dc0fb7.1367843730.git.john@keeping.me.uk","threadId":"33732","inReplyTo":null,"subject":"[PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-05-06T12:35:46Z","receivedAt":"2013-05-06T12:35:46Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"Commit 54bb901 (t/Makefile: fix result handling with\nTEST_OUTPUT_DIRECTORY - 2013-04-26) incorrectly defined\nTEST_RESULTS_DIRECTORY relative to itself, when it should be relative to\nTEST_OUTPUT_DIRECTORY.  Fix this.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n t/Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex 11de5da..ebb7371 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -16,7 +16,7 @@ DEFAULT_TEST_TARGET ?= test\n TEST_LINT ?= test-lint-duplicates test-lint-executable\n \n ifdef TEST_OUTPUT_DIRECTORY\n-TEST_RESULTS_DIRECTORY = $(TEST_RESULTS_DIRECTORY)/test-results\n+TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results\n else\n TEST_RESULTS_DIRECTORY = test-results\n endif\n-- \n1.8.3.rc0.149.g98a72f2.dirty\n"},{"id":"216505","messageId":"7vy5bsrv73.fsf@alter.siamese.dyndns.org","threadId":"33732","inReplyTo":"6bb37f45280373b96c2ae581db9bd87007dc0fb7.1367843730.git.john@keeping.me.uk","subject":"Re: [PATCH] t/Makefile: don't define TEST_RESULTS_DIRECTORY recursively","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-06T15:20:48Z","receivedAt":"2013-05-06T15:20:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"John Keeping <john@keeping.me.uk> writes:\n\n> Commit 54bb901 (t/Makefile: fix result handling with\n> TEST_OUTPUT_DIRECTORY - 2013-04-26) incorrectly defined\n> TEST_RESULTS_DIRECTORY relative to itself, when it should be relative to\n> TEST_OUTPUT_DIRECTORY.  Fix this.\n>\n> Signed-off-by: John Keeping <john@keeping.me.uk>\n> ---\n>  t/Makefile | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nThanks, I missed this one.\n\n> diff --git a/t/Makefile b/t/Makefile\n> index 11de5da..ebb7371 100644\n> --- a/t/Makefile\n> +++ b/t/Makefile\n> @@ -16,7 +16,7 @@ DEFAULT_TEST_TARGET ?= test\n>  TEST_LINT ?= test-lint-duplicates test-lint-executable\n>  \n>  ifdef TEST_OUTPUT_DIRECTORY\n> -TEST_RESULTS_DIRECTORY = $(TEST_RESULTS_DIRECTORY)/test-results\n> +TEST_RESULTS_DIRECTORY = $(TEST_OUTPUT_DIRECTORY)/test-results\n>  else\n>  TEST_RESULTS_DIRECTORY = test-results\n>  endif\n"}]}