{"thread":{"id":"33728","subject":"[PATCH] Git::SVN::*: add missing \"NAME\" section to perldoc","startedAt":"2013-05-05T07:50:33Z","lastAt":"2013-05-09T01:08:56Z","messageCount":2,"participants":["Jonathan Nieder","Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"216440","messageId":"20130505075033.GA27215@elie.Belkin","threadId":"33728","inReplyTo":null,"subject":"[PATCH] Git::SVN::*: add missing \"NAME\" section to perldoc","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2013-05-05T07:50:33Z","receivedAt":"2013-05-05T07:50:33Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"lexgrog(1) relies on the NAME section to find a manpage's subject's\nname and description for easy access later using \"man -k\".  Add the\nsection it expects.\n\nNoticed using lintian.\n\nSigned-off-by: Jonathan Nieder <jrnieder@gmail.com>\n---\nHi Eric,\n\nJust noticed this by running a tool to sanity-check my build result.\nI hadn't noticed before because I hadn't been installing the manpages.\nAnyway, perhaps the patch can be useful.\n\n perl/Git/SVN/Editor.pm  | 2 ++\n perl/Git/SVN/Fetcher.pm | 2 ++\n perl/Git/SVN/Prompt.pm  | 2 ++\n perl/Git/SVN/Ra.pm      | 2 ++\n 4 files changed, 8 insertions(+)\n\ndiff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm\nindex fa0d3c6c..b3bcd476 100644\n--- a/perl/Git/SVN/Editor.pm\n+++ b/perl/Git/SVN/Editor.pm\n@@ -499,6 +499,8 @@ sub apply_diff {\n 1;\n __END__\n \n+=head1 NAME\n+\n Git::SVN::Editor - commit driver for \"git svn set-tree\" and dcommit\n \n =head1 SYNOPSIS\ndiff --git a/perl/Git/SVN/Fetcher.pm b/perl/Git/SVN/Fetcher.pm\nindex 046a7a2f..72150af6 100644\n--- a/perl/Git/SVN/Fetcher.pm\n+++ b/perl/Git/SVN/Fetcher.pm\n@@ -512,6 +512,8 @@ sub stash_placeholder_list {\n 1;\n __END__\n \n+=head1 NAME\n+\n Git::SVN::Fetcher - tree delta consumer for \"git svn fetch\"\n \n =head1 SYNOPSIS\ndiff --git a/perl/Git/SVN/Prompt.pm b/perl/Git/SVN/Prompt.pm\nindex 74daa7a5..e940b085 100644\n--- a/perl/Git/SVN/Prompt.pm\n+++ b/perl/Git/SVN/Prompt.pm\n@@ -125,6 +125,8 @@ sub _read_password {\n 1;\n __END__\n \n+=head1 NAME\n+\n Git::SVN::Prompt - authentication callbacks for git-svn\n \n =head1 SYNOPSIS\ndiff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm\nindex 6a212eb7..75ecc425 100644\n--- a/perl/Git/SVN/Ra.pm\n+++ b/perl/Git/SVN/Ra.pm\n@@ -627,6 +627,8 @@ sub skip_unknown_revs {\n 1;\n __END__\n \n+=head1 NAME\n+\n Git::SVN::Ra - Subversion remote access functions for git-svn\n \n =head1 SYNOPSIS\n-- \n1.8.3.rc1\n"},{"id":"216733","messageId":"20130509010856.GA26479@dcvr.yhbt.net","threadId":"33728","inReplyTo":"20130505075033.GA27215@elie.Belkin","subject":"Re: [PATCH] Git::SVN::*: add missing \"NAME\" section to perldoc","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2013-05-09T01:08:56Z","receivedAt":"2013-05-09T01:08:56Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Jonathan Nieder <jrnieder@gmail.com> wrote:\n> Just noticed this by running a tool to sanity-check my build result.\n> I hadn't noticed before because I hadn't been installing the manpages.\n> Anyway, perhaps the patch can be useful.\n\nThanks, signed-off and applied, will push.\n"}]}