{"thread":{"id":"33725","subject":"[PATCH] revision.c: Fix a sparse warning","startedAt":"2013-05-04T17:25:56Z","lastAt":"2013-05-07T01:21:06Z","messageCount":3,"participants":["Ramsay Jones","Kevin Bracey","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"216415","messageId":"518544A4.4080202@ramsay1.demon.co.uk","threadId":"33725","inReplyTo":null,"subject":"[PATCH] revision.c: Fix a sparse warning","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2013-05-04T17:25:56Z","receivedAt":"2013-05-04T17:25:56Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSparse issues an \"'sole_interesting' not declared. Should it be static?\"\nwarning. In order to suppress the warning, since this symbol does not\nneed more than file visibility, we simply add the static modifier to\nits declaration.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>\n---\n\nHi Kevin,\n\nIf you need to re-roll your 'kb/full-history-compute-treesame-carefully'\nbranch, could you please squash this into commit 039bdad1 (\"revision.c:\ndiscount UNINTERESTING parents\", 30-04-2013).\n\nThanks!\n\nATB,\nRamsay Jones\n\n revision.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/revision.c b/revision.c\nindex dd48c55..60c8d8c 100644\n--- a/revision.c\n+++ b/revision.c\n@@ -349,7 +349,7 @@ static int everybody_uninteresting(struct commit_list *orig)\n  * (and multiple UNINTERESTING ones), then we can't choose a parent to follow,\n  * and we should not be simplified.\n  */\n-struct commit *sole_interesting(struct rev_info *revs, struct commit_list *orig)\n+static struct commit *sole_interesting(struct rev_info *revs, struct commit_list *orig)\n {\n \tstruct commit_list *list = orig;\n \tstruct commit *interesting = NULL;\n-- \n1.8.2\n"},{"id":"216416","messageId":"51854FE5.4050907@bracey.fi","threadId":"33725","inReplyTo":"518544A4.4080202@ramsay1.demon.co.uk","subject":"Re: [PATCH] revision.c: Fix a sparse warning","fromName":"Kevin Bracey","fromEmail":"kevin@bracey.fi","sentAt":"2013-05-04T18:13:57Z","receivedAt":"2013-05-04T18:13:57Z","isPatch":true,"sender":{"key":"kevin@bracey.fi","avatar":"https://avatars.githubusercontent.com/u/96079793?v=4"},"body":"On 04/05/2013 20:25, Ramsay Jones wrote:\n> Sparse issues an \"'sole_interesting' not declared. Should it be static?\"\n> warning. In order to suppress the warning, since this symbol does not\n> need more than file visibility, we simply add the static modifier to\n> its declaration.\n>\n>\nThanks! I'll include that fix.\n\nKevin\n"},{"id":"216561","messageId":"7vehdjpou5.fsf@alter.siamese.dyndns.org","threadId":"33725","inReplyTo":"51854FE5.4050907@bracey.fi","subject":"Re: [PATCH] revision.c: Fix a sparse warning","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-05-07T01:21:06Z","receivedAt":"2013-05-07T01:21:06Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Kevin Bracey <kevin@bracey.fi> writes:\n\n> On 04/05/2013 20:25, Ramsay Jones wrote:\n>> Sparse issues an \"'sole_interesting' not declared. Should it be static?\"\n>> warning. In order to suppress the warning, since this symbol does not\n>> need more than file visibility, we simply add the static modifier to\n>> its declaration.\n>>\n>>\n> Thanks! I'll include that fix.\n\nThanks.\n"}]}