{"thread":{"id":"33670","subject":"[PATCH 0/5] [RESEND] Minor additions to git-completion.bash","startedAt":"2013-04-29T12:49:36Z","lastAt":"2013-04-29T16:58:12Z","messageCount":8,"participants":["Ramkumar Ramachandra","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"215840","messageId":"1367239781-5232-1-git-send-email-artagnon@gmail.com","threadId":"33670","inReplyTo":null,"subject":"[PATCH 0/5] [RESEND] Minor additions to git-completion.bash","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-29T12:49:36Z","receivedAt":"2013-04-29T12:49:36Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Junio C Hamano wrote:\n> I do not have the original series, so a resend with Felipe's Acked-by\n> after your original Sign-off would be nice.\n\nFelipe Contreras wrote:\n> I only gave them a quick look.\n\nThis is an unmodified resend of [1] rebased onto the latest `master`.\nI have not added Felipe's Acked-by.  Please do the needful.\n\nThanks.\n\n[1]: http://article.gmane.org/gmane.comp.version-control.git/221947\n\nRamkumar Ramachandra (5):\n  git-completion.bash: lexical sorting for diff.statGraphWidth\n  git-completion.bash: add diff.submodule to config list\n  git-completion.bash: complete branch.*.rebase as boolean\n  git-completion.bash: add branch.*.pushremote to config list\n  git-completion.bash: add remote.pushdefault to config list\n\n contrib/completion/git-completion.bash | 20 +++++++++++++++++---\n 1 file changed, 17 insertions(+), 3 deletions(-)\n\n-- \n1.8.2.1.616.ga1e5536.dirty\n"},{"id":"215841","messageId":"1367239781-5232-2-git-send-email-artagnon@gmail.com","threadId":"33670","inReplyTo":"1367239781-5232-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 1/5] git-completion.bash: lexical sorting for diff.statGraphWidth","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-29T12:49:37Z","receivedAt":"2013-04-29T12:49:37Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"df44483a (diff --stat: add config option to limit graph width,\n2012-03-01) added the option diff.startGraphWidth to the list of\nconfiguration variables in git-completion.bash, but failed to notice\nthat the list is sorted alphabetically.  Move it to its rightful place\nin the list.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex bc3fc9e..61ccb19 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2051,13 +2051,13 @@ _git_config ()\n \t\tcore.whitespace\n \t\tcore.worktree\n \t\tdiff.autorefreshindex\n-\t\tdiff.statGraphWidth\n \t\tdiff.external\n \t\tdiff.ignoreSubmodules\n \t\tdiff.mnemonicprefix\n \t\tdiff.noprefix\n \t\tdiff.renameLimit\n \t\tdiff.renames\n+\t\tdiff.statGraphWidth\n \t\tdiff.suppressBlankEmpty\n \t\tdiff.tool\n \t\tdiff.wordRegex\n-- \n1.8.2.1.616.ga1e5536.dirty\n"},{"id":"215842","messageId":"1367239781-5232-3-git-send-email-artagnon@gmail.com","threadId":"33670","inReplyTo":"1367239781-5232-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 2/5] git-completion.bash: add diff.submodule to config list","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-29T12:49:38Z","receivedAt":"2013-04-29T12:49:38Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"c47ef57 (diff: introduce diff.submodule configuration variable,\n2012-11-13) introduced the diff.submodule configuration variable, but\nforgot to teach git-completion.bash about it.  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 61ccb19..ba46cd9 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1857,6 +1857,10 @@ _git_config ()\n \t\t\t\"\n \t\treturn\n \t\t;;\n+\tdiff.submodule)\n+\t\t__gitcomp \"log short\"\n+\t\treturn\n+\t\t;;\n \thelp.format)\n \t\t__gitcomp \"man info web html\"\n \t\treturn\n@@ -2058,6 +2062,7 @@ _git_config ()\n \t\tdiff.renameLimit\n \t\tdiff.renames\n \t\tdiff.statGraphWidth\n+\t\tdiff.submodule\n \t\tdiff.suppressBlankEmpty\n \t\tdiff.tool\n \t\tdiff.wordRegex\n-- \n1.8.2.1.616.ga1e5536.dirty\n"},{"id":"215843","messageId":"1367239781-5232-4-git-send-email-artagnon@gmail.com","threadId":"33670","inReplyTo":"1367239781-5232-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 3/5] git-completion.bash: complete branch.*.rebase as boolean","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-29T12:49:39Z","receivedAt":"2013-04-29T12:49:39Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"6fac1b83 (completion: add missing config variables, 2009-06-29) added\n\"rebase\" to the list of completions for \"branch.*.*\", but forgot to\nspecify completions for the values that this configuration variable\ncan take (namely \"false\" and \"true\").  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex ba46cd9..7bb11a1 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1818,6 +1818,10 @@ _git_config ()\n \t\t__gitcomp_nl \"$(__git_refs)\"\n \t\treturn\n \t\t;;\n+\tbranch.*.rebase)\n+\t\t__gitcomp \"false true\"\n+\t\treturn\n+\t\t;;\n \tremote.*.fetch)\n \t\tlocal remote=\"${prev#remote.}\"\n \t\tremote=\"${remote%.fetch}\"\n-- \n1.8.2.1.616.ga1e5536.dirty\n"},{"id":"215844","messageId":"1367239781-5232-5-git-send-email-artagnon@gmail.com","threadId":"33670","inReplyTo":"1367239781-5232-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 4/5] git-completion.bash: add branch.*.pushremote to config list","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-29T12:49:40Z","receivedAt":"2013-04-29T12:49:40Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"9f765ce (remote.c: introduce branch.<name>.pushremote, 2013-04-02)\nintroduced the configuration variable branch.*.pushremote, but forgot\nto teach git-completion.bash about it.  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 7bb11a1..af271cc 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1810,7 +1810,7 @@ __git_config_get_set_variables ()\n _git_config ()\n {\n \tcase \"$prev\" in\n-\tbranch.*.remote)\n+\tbranch.*.remote|branch.*.pushremote)\n \t\t__gitcomp_nl \"$(__git_remotes)\"\n \t\treturn\n \t\t;;\n@@ -1906,7 +1906,7 @@ _git_config ()\n \t\t;;\n \tbranch.*.*)\n \t\tlocal pfx=\"${cur%.*}.\" cur_=\"${cur##*.}\"\n-\t\t__gitcomp \"remote merge mergeoptions rebase\" \"$pfx\" \"$cur_\"\n+\t\t__gitcomp \"remote pushremote merge mergeoptions rebase\" \"$pfx\" \"$cur_\"\n \t\treturn\n \t\t;;\n \tbranch.*)\n-- \n1.8.2.1.616.ga1e5536.dirty\n"},{"id":"215845","messageId":"1367239781-5232-6-git-send-email-artagnon@gmail.com","threadId":"33670","inReplyTo":"1367239781-5232-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 5/5] git-completion.bash: add remote.pushdefault to config list","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-29T12:49:41Z","receivedAt":"2013-04-29T12:49:41Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"224c2171 (remote.c: introduce remote.pushdefault, 2013-04-02)\nintroduced the remote.pushdefault configuration variable, but forgot\nto teach git-completion.bash about it.  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex af271cc..2bbd8a3 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1822,6 +1822,10 @@ _git_config ()\n \t\t__gitcomp \"false true\"\n \t\treturn\n \t\t;;\n+\tremote.pushdefault)\n+\t\t__gitcomp_nl \"$(__git_remotes)\"\n+\t\treturn\n+\t\t;;\n \tremote.*.fetch)\n \t\tlocal remote=\"${prev#remote.}\"\n \t\tremote=\"${remote%.fetch}\"\n@@ -2201,6 +2205,7 @@ _git_config ()\n \t\treceive.fsckObjects\n \t\treceive.unpackLimit\n \t\treceive.updateserverinfo\n+\t\tremote.pushdefault\n \t\tremotes.\n \t\trepack.usedeltabaseoffset\n \t\trerere.autoupdate\n-- \n1.8.2.1.616.ga1e5536.dirty\n"},{"id":"215846","messageId":"CALkWK0koi9UwN9uRUci3ictpMy_T5TMey_t9fNNM4HpBvqEG0A@mail.gmail.com","threadId":"33670","inReplyTo":"1367239781-5232-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH 0/5] [RESEND] Minor additions to git-completion.bash","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-29T12:50:33Z","receivedAt":"2013-04-29T12:50:33Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"[Corrected Felipe's email id; sorry, I'm having a bad day]\n\nRamkumar Ramachandra wrote:\n> [...]\n"},{"id":"215869","messageId":"7vr4htjmu3.fsf@alter.siamese.dyndns.org","threadId":"33670","inReplyTo":"CALkWK0koi9UwN9uRUci3ictpMy_T5TMey_t9fNNM4HpBvqEG0A@mail.gmail.com","subject":"Re: [PATCH 0/5] [RESEND] Minor additions to git-completion.bash","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-29T16:58:12Z","receivedAt":"2013-04-29T16:58:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramkumar Ramachandra <artagnon@gmail.com> writes:\n\n> [Corrected Felipe's email id; sorry, I'm having a bad day]\n\nThey all look trivial enough, so I'll directly apply to the\nintegration branches.\n\nThanks.\n"}]}