{"thread":{"id":"33624","subject":"[PATCH v3 0/9] remote-helpers: fixes and cleanups","startedAt":"2013-04-26T21:12:30Z","lastAt":"2013-04-27T02:56:26Z","messageCount":15,"participants":["Felipe Contreras","Junio C Hamano","Ramkumar Ramachandra"],"isPatch":true,"patchVersion":3,"patchTotal":9},"messages":[{"id":"215640","messageId":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":null,"subject":"[PATCH v3 0/9] remote-helpers: fixes and cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:30Z","receivedAt":"2013-04-26T21:12:30Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Updated the commit messages, so we say Bazaar instead of Mercurial, and stuff.\n\nHere's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.\n\nFelipe Contreras (9):\n remote-helpers: trivial cleanups\n remote-hg: remove extra check\n remote-bzr: fix bad state issue\n remote-bzr: add support to push URLs\n remote-hg: use hashlib instead of hg sha1 util\n remote-bzr: store converted URL\n remote-bzr: tell bazaar to be quiet\n remote-bzr: strip extra newline\n remote-bzr: use proper push method\n\n contrib/remote-helpers/git-remote-bzr | 55 ++++++++++++++++++++++++++++-------\n contrib/remote-helpers/git-remote-hg | 10 ++-----\n 2 files changed, 48 insertions(+), 17 deletions(-)\n\n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215641","messageId":"1367010759-17928-2-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 1/9] remote-helpers: trivial cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:31Z","receivedAt":"2013-04-26T21:12:31Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"No functional changes. Typos, unused variables, redundant operations,\nand white-spaces.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 7 ++++---\n contrib/remote-helpers/git-remote-hg | 2 +-\n 2 files changed, 5 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex cc6609b..87c54bf 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -94,7 +94,7 @@ class Marks:\n return self.last_mark\n \n def is_marked(self, rev):\n- return str(rev) in self.marks\n+ return rev in self.marks\n \n def new_mark(self, rev, mark):\n self.marks[rev] = mark\n@@ -224,7 +224,7 @@ def export_files(tree, files):\n else:\n mode = '100644'\n \n- # is the blog already exported?\n+ # is the blob already exported?\n if h in filenodes:\n mark = filenodes[h]\n final.append((mode, mark, path))\n@@ -521,7 +521,7 @@ def c_style_unescape(string):\n return string\n \n def parse_commit(parser):\n- global marks, blob_marks, bmarks, parsed_refs\n+ global marks, blob_marks, parsed_refs\n global mode\n \n parents = []\n@@ -643,6 +643,7 @@ def do_export(parser):\n wt = repo.bzrdir.open_workingtree()\n wt.update()\n print \"ok %s\" % ref\n+\n print\n \n def do_capabilities(parser):\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg\nindex fda4199..cfa96c1 100755\n--- a/contrib/remote-helpers/git-remote-hg\n+++ b/contrib/remote-helpers/git-remote-hg\n@@ -12,7 +12,7 @@\n # For remote repositories a local clone is stored in\n # \"$GIT_DIR/hg/origin/clone/.hg/\".\n \n-from mercurial import hg, ui, bookmarks, context, util, encoding, node, error, extensions\n+from mercurial import hg, ui, bookmarks, context, encoding, node, error, extensions\n \n import re\n import sys\n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215643","messageId":"1367010759-17928-3-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 2/9] remote-hg: remove extra check","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:32Z","receivedAt":"2013-04-26T21:12:32Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Not needed since we use xrange ourselves.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-hg | 4 ----\n 1 file changed, 4 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg\nindex cfa96c1..80b3606 100755\n--- a/contrib/remote-helpers/git-remote-hg\n+++ b/contrib/remote-helpers/git-remote-hg\n@@ -373,10 +373,6 @@ def export_ref(repo, name, kind, head):\n ename = '%s/%s' % (kind, name)\n tip = marks.get_tip(ename)\n \n- # mercurial takes too much time checking this\n- if tip and tip == head.rev():\n- # nothing to do\n- return\n revs = xrange(tip, head.rev() + 1)\n count = 0\n \n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215642","messageId":"1367010759-17928-4-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 3/9] remote-bzr: fix bad state issue","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:33Z","receivedAt":"2013-04-26T21:12:33Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Carried from remote-hg.\n\nThe problem reportedly happened after doing a push that fails, the abort\ncauses the state of remote-hg to go bad, this happens because\nremote-hg's marks are not stored, but 'git fast-export' marks are.\n\nEnsure that the marks are _always_ stored.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 87c54bf..7b6584e 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -32,6 +32,7 @@ import os\n import json\n import re\n import StringIO\n+import atexit\n \n NAME_RE = re.compile('^([^<>]+)')\n AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')\n@@ -728,6 +729,7 @@ def main(args):\n blob_marks = {}\n parsed_refs = {}\n files_cache = {}\n+ marks = None\n \n gitdir = os.environ['GIT_DIR']\n dirname = os.path.join(gitdir, 'bzr', alias)\n@@ -754,6 +756,10 @@ def main(args):\n die('unhandled command: %s' % line)\n sys.stdout.flush()\n \n+def bye():\n+ if not marks:\n+ return\n marks.store()\n \n+atexit.register(bye)\n sys.exit(main(sys.argv))\n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215645","messageId":"1367010759-17928-5-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 4/9] remote-bzr: add support to push URLs","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:34Z","receivedAt":"2013-04-26T21:12:34Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Just like in remote-hg.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 7b6584e..f1d6d5e 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -32,7 +32,7 @@ import os\n import json\n import re\n import StringIO\n-import atexit\n+import atexit, shutil, hashlib\n \n NAME_RE = re.compile('^([^<>]+)')\n AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')\n@@ -719,11 +719,11 @@ def main(args):\n global blob_marks\n global parsed_refs\n global files_cache\n+ global is_tmp\n \n alias = args[1]\n url = args[2]\n \n- prefix = 'refs/bzr/%s' % alias\n tags = {}\n filenodes = {}\n blob_marks = {}\n@@ -731,6 +731,13 @@ def main(args):\n files_cache = {}\n marks = None\n \n+ if alias[5:] == url:\n+ is_tmp = True\n+ alias = hashlib.sha1(alias).hexdigest()\n+ else:\n+ is_tmp = False\n+\n+ prefix = 'refs/bzr/%s' % alias\n gitdir = os.environ['GIT_DIR']\n dirname = os.path.join(gitdir, 'bzr', alias)\n \n@@ -759,7 +766,10 @@ def main(args):\n def bye():\n if not marks:\n return\n- marks.store()\n+ if not is_tmp:\n+ marks.store()\n+ else:\n+ shutil.rmtree(dirname)\n \n atexit.register(bye)\n sys.exit(main(sys.argv))\n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215644","messageId":"1367010759-17928-6-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 5/9] remote-hg: use hashlib instead of hg sha1 util","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:35Z","receivedAt":"2013-04-26T21:12:35Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"To be in sync with remote-bzr.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-hg | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg\nindex 80b3606..06920f2 100755\n--- a/contrib/remote-helpers/git-remote-hg\n+++ b/contrib/remote-helpers/git-remote-hg\n@@ -22,7 +22,7 @@ import shutil\n import subprocess\n import urllib\n import atexit\n-import urlparse\n+import urlparse, hashlib\n \n #\n # If you want to switch to hg-git compatibility mode:\n@@ -933,7 +933,7 @@ def main(args):\n \n if alias[4:] == url:\n is_tmp = True\n- alias = util.sha1(alias).hexdigest()\n+ alias = hashlib.sha1(alias).hexdigest()\n else:\n is_tmp = False\n \n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215646","messageId":"1367010759-17928-7-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 6/9] remote-bzr: store converted URL","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:36Z","receivedAt":"2013-04-26T21:12:36Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Bazaar might convert the URL to something more appropriate, like an\nabsolute path. Lets store that instead of the original URL, which won't\nwork from a different working directory if it's relative.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex f1d6d5e..dda2932 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -32,7 +32,7 @@ import os\n import json\n import re\n import StringIO\n-import atexit, shutil, hashlib\n+import atexit, shutil, hashlib, urlparse, subprocess\n \n NAME_RE = re.compile('^([^<>]+)')\n AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')\n@@ -713,6 +713,14 @@ def get_repo(url, alias):\n \n return branch\n \n+def fix_path(alias, orig_url):\n+ url = urlparse.urlparse(orig_url, 'file')\n+ if url.scheme != 'file' or os.path.isabs(url.path):\n+ return\n+ abs_url = urlparse.urljoin(\"%s/\" % os.getcwd(), orig_url)\n+ cmd = ['git', 'config', 'remote.%s.url' % alias, \"bzr::%s\" % abs_url]\n+ subprocess.call(cmd)\n+\n def main(args):\n global marks, prefix, dirname\n global tags, filenodes\n@@ -741,6 +749,9 @@ def main(args):\n gitdir = os.environ['GIT_DIR']\n dirname = os.path.join(gitdir, 'bzr', alias)\n \n+ if not is_tmp:\n+ fix_path(alias, url)\n+\n if not os.path.exists(dirname):\n os.makedirs(dirname)\n \n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215647","messageId":"1367010759-17928-8-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 7/9] remote-bzr: tell bazaar to be quiet","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:37Z","receivedAt":"2013-04-26T21:12:37Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Otherwise we get notification, progress bars, and what not.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex dda2932..8617e25 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -26,6 +26,7 @@ bzrlib.plugin.load_plugins()\n import bzrlib.generate_ids\n import bzrlib.transport\n import bzrlib.errors\n+import bzrlib.ui\n \n import sys\n import os\n@@ -755,6 +756,8 @@ def main(args):\n if not os.path.exists(dirname):\n os.makedirs(dirname)\n \n+ bzrlib.ui.ui_factory.be_quiet(True)\n+\n repo = get_repo(url, alias)\n \n marks_path = os.path.join(dirname, 'marks-int')\n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215649","messageId":"1367010759-17928-9-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 8/9] remote-bzr: strip extra newline","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:38Z","receivedAt":"2013-04-26T21:12:38Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"It's added by fast-export, the user didn't type it.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 8617e25..9f56297 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -549,6 +549,10 @@ def parse_commit(parser):\n parents.append(parser.get_mark())\n parser.next()\n \n+ # fast-export adds an extra newline\n+ if data[-1] == '\\n':\n+ data = data[:-1]\n+\n files = {}\n \n for line in parser:\n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215648","messageId":"1367010759-17928-10-git-send-email-felipe.contreras@gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v3 9/9] remote-bzr: use proper push method","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T21:12:39Z","receivedAt":"2013-04-26T21:12:39Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Not just randomly synchronize the revisions with no checks at all. This\nis the way bazaar's UI does it.\n\nAlso, add a non-ff check.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 9f56297..c19ed0e 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -639,12 +639,12 @@ def do_export(parser):\n for ref, revid in parsed_refs.iteritems():\n if ref == 'refs/heads/master':\n repo.generate_revision_history(revid, marks.get_tip('master'))\n- revno, revid = repo.last_revision_info()\n if peer:\n- if hasattr(peer, \"import_last_revision_info_and_tags\"):\n- peer.import_last_revision_info_and_tags(repo, revno, revid)\n- else:\n- peer.import_last_revision_info(repo.repository, revno, revid)\n+ try:\n+ repo.push(peer, stop_revision=revid)\n+ except bzrlib.errors.DivergedBranches:\n+ print \"error %s non-fast forward\" % ref\n+ continue\n else:\n wt = repo.bzrdir.open_workingtree()\n wt.update()\n-- \n1.8.2.1.1031.g2ee5873\n"},{"id":"215654","messageId":"7vwqrpuedv.fsf@alter.siamese.dyndns.org","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH v3 0/9] remote-helpers: fixes and cleanups","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-26T22:16:12Z","receivedAt":"2013-04-26T22:16:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> Updated the commit messages, so we say Bazaar instead of Mercurial, and stuff.\n>\n> Here's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.\n\nThanks. Will queue on 'pu' without looking.\n"},{"id":"215656","messageId":"7vsj2due28.fsf@alter.siamese.dyndns.org","threadId":"33624","inReplyTo":"7vwqrpuedv.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH v3 0/9] remote-helpers: fixes and cleanups","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-26T22:23:11Z","receivedAt":"2013-04-26T22:23:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Felipe Contreras writes:\n>\n>> Updated the commit messages, so we say Bazaar instead of Mercurial, and stuff.\n>>\n>> Here's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.\n>\n> Thanks. Will queue on 'pu' without looking.\n\nActually, I was going to merge fc/remote-hg and fc/remote-bzr down\nto master anyway, so I'll just apply them directly on 'master'.\n\nBy the way, I personally do not think the quality of the changes to\nremote-bzr matters all that much at this point in its history. It's\nnot like millions of people use it heavily from the v1.8.2 release.\nA huge patch series from its original author and nobody else, either\nreviewed or unreviwed, would not hurt them more than the one in the\nv1.8.2 version anyway. And it is also not like bzr-to-git population\nwill grow significantly in the future to require us to pile a lot of\nfeatures on remote-bzr that makes the maintenance burden of it\nbecomes an issue.\n\nAm I underestimating the pain of potentially breaking existing\nremote-bzr userbase?\n"},{"id":"215658","messageId":"CAMP44s2u1iLXKQ5zuif4xKvYREVQm3B+301J=F5CpqPW6E5wWw@mail.gmail.com","threadId":"33624","inReplyTo":"7vsj2due28.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH v3 0/9] remote-helpers: fixes and cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T22:40:17Z","receivedAt":"2013-04-26T22:40:17Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Fri, Apr 26, 2013 at 5:23 PM, Junio C Hamano wrote:\n> Junio C Hamano writes:\n>\n>> Felipe Contreras writes:\n>>\n>>> Updated the commit messages, so we say Bazaar instead of Mercurial, and stuff.\n>>>\n>>> Here's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.\n>>\n>> Thanks. Will queue on 'pu' without looking.\n>\n> Actually, I was going to merge fc/remote-hg and fc/remote-bzr down\n> to master anyway, so I'll just apply them directly on 'master'.\n>\n> By the way, I personally do not think the quality of the changes to\n> remote-bzr matters all that much at this point in its history. It's\n> not like millions of people use it heavily from the v1.8.2 release.\n> A huge patch series from its original author and nobody else, either\n> reviewed or unreviwed, would not hurt them more than the one in the\n> v1.8.2 version anyway. And it is also not like bzr-to-git population\n> will grow significantly in the future to require us to pile a lot of\n> features on remote-bzr that makes the maintenance burden of it\n> becomes an issue.\n>\n> Am I underestimating the pain of potentially breaking existing\n> remote-bzr userbase?\n\nNo, I think it's reasonable. 1.8.2 was better because 1.8.1 didn't ave\nany support whatsoever, and 1.8.3 will be better, because 1.8.2 was\nbarely usable for any real-world project. Will there be any\nregressions? I doubt it, and if there are, it's unlikely that they\nwould be found in the review process, in 'pu', or in 'next', specially\nsince very few people actually use remote-bzr, in part because it\nwasn't very useful, and in part because few people use bzr in the\nfirst place.\n\nOf course, I would prefer if people reviewed the patches for the\nmassive changes, the _important_ patches, and I would gladly explain\nthe reasoning and update the commit messages if needed. But nobody is\nvolunteering to review that. The only exception was for a few\nirrelevant patches that could be easily dropped.\n\nremote-hg is a different story, and so I'm being more careful with the\nchanges there, and I actually think the current patches are more than\nenough for 1.8.3, they should be tested in an actual release, and the\nrest would have to wait. For the rest, I'm still juggling in which\norder I should send them, and I want to send first the ones that\nshould maximize the benefits for the users, with minimum possibility\nof breakage, but even then I wouldn't be confident with those landing\nin 1.8.3, so 1.8.4 it is.\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"215662","messageId":"7vd2tgvqq8.fsf@alter.siamese.dyndns.org","threadId":"33624","inReplyTo":"7vsj2due28.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH v3 0/9] remote-helpers: fixes and cleanups","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-26T23:04:15Z","receivedAt":"2013-04-26T23:04:15Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Junio C Hamano writes:\n>\n>> Felipe Contreras writes:\n>>\n>>> Updated the commit messages, so we say Bazaar instead of Mercurial, and stuff.\n>>>\n>>> Here's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.\n>>\n>> Thanks. Will queue on 'pu' without looking.\n>\n> Actually, I was going to merge fc/remote-hg and fc/remote-bzr down\n> to master anyway, so I'll just apply them directly on 'master'.\n> \n> By the way, I personally do not think the quality of the changes to\n> remote-bzr matters all that much ...\n\nJust in case anybody get the wrong impression from the above quoted\nlines...\n\nThe \"without looking\" was a plan to \"keep them on 'pu' for later\ninspection so that I do not have to go back to list archive when I\ndeclare patch review bankruptcy after the final 1.8.3 release\".\n\nI did read these patches I applied to 'master' and they all looked\nsensible.\n"},{"id":"215675","messageId":"CALkWK0kgL_kUSUc2Y8aKah85P_X5u5g0nYNOw32Di-1xWH6X_Q@mail.gmail.com","threadId":"33624","inReplyTo":"1367010759-17928-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH v3 0/9] remote-helpers: fixes and cleanups","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-27T02:56:26Z","receivedAt":"2013-04-27T02:56:26Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Felipe Contreras wrote:\n> Updated the commit messages, so we say Bazaar instead of Mercurial, and stuff.\n>\n> Here's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.\n\nLooks reasonable. Thanks.\n"}]}