{"thread":{"id":"33622","subject":"[PATCH] t/Makefile: remove smoke test targets","startedAt":"2013-04-26T17:58:24Z","lastAt":"2013-04-27T11:16:00Z","messageCount":2,"participants":["John Keeping","Thomas Rast"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"215605","messageId":"dd20490a6d7911e0e0814fbe2eee0cfea1faa4e5.1366999104.git.john@keeping.me.uk","threadId":"33622","inReplyTo":null,"subject":"[PATCH] t/Makefile: remove smoke test targets","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-04-26T17:58:24Z","receivedAt":"2013-04-26T17:58:24Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"Commit d24fbca (Remove Git's support for smoke testing - 2011-12-23)\nremoved the smoke test support from the test suite but it was re-added\nby commit 342e9ef (Introduce a performance testing framework -\n2012-02-17).  This appears to be the result of a mis-merge, since\nre-adding the smoke testing infrastructure does not relate to the\nsubject of that commit.\n\nThe current 'smoke' target is broken since the 'harness' script it\nuses no longer exists, so just reapply this section of commit d24fbca\nand remove all of the smoke testing section in the makefile.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n t/Makefile | 38 --------------------------------------\n 1 file changed, 38 deletions(-)\n\ndiff --git a/t/Makefile b/t/Makefile\nindex 1923cc1..44ca7d3 100644\n--- a/t/Makefile\n+++ b/t/Makefile\n@@ -83,42 +83,4 @@ valgrind:\n perf:\n \t$(MAKE) -C perf/ all\n \n-# Smoke testing targets\n--include ../GIT-VERSION-FILE\n-uname_S := $(shell sh -c 'uname -s 2>/dev/null || echo unknown')\n-uname_M := $(shell sh -c 'uname -m 2>/dev/null || echo unknown')\n-\n-test-results:\n-\tmkdir -p test-results\n-\n-test-results/git-smoke.tar.gz: test-results\n-\t'$(PERL_PATH_SQ)' ./harness \\\n-\t\t--archive=\"test-results/git-smoke.tar.gz\" \\\n-\t\t$(T)\n-\n-smoke: test-results/git-smoke.tar.gz\n-\n-SMOKE_UPLOAD_FLAGS =\n-ifdef SMOKE_USERNAME\n-\tSMOKE_UPLOAD_FLAGS += -F username=\"$(SMOKE_USERNAME)\" -F password=\"$(SMOKE_PASSWORD)\"\n-endif\n-ifdef SMOKE_COMMENT\n-\tSMOKE_UPLOAD_FLAGS += -F comments=\"$(SMOKE_COMMENT)\"\n-endif\n-ifdef SMOKE_TAGS\n-\tSMOKE_UPLOAD_FLAGS += -F tags=\"$(SMOKE_TAGS)\"\n-endif\n-\n-smoke_report: smoke\n-\tcurl \\\n-\t\t-H \"Expect: \" \\\n-\t\t-F project=Git \\\n-\t\t-F architecture=\"$(uname_M)\" \\\n-\t\t-F platform=\"$(uname_S)\" \\\n-\t\t-F revision=\"$(GIT_VERSION)\" \\\n-\t\t-F report_file=@test-results/git-smoke.tar.gz \\\n-\t\t$(SMOKE_UPLOAD_FLAGS) \\\n-\t\thttp://smoke.git.nix.is/app/projects/process_add_report/1 \\\n-\t| grep -v ^Redirecting\n-\n .PHONY: pre-clean $(T) aggregate-results clean valgrind perf\n-- \n1.8.2.1.715.gb260f47\n"},{"id":"215694","messageId":"8738ucgr67.fsf@hexa.v.cablecom.net","threadId":"33622","inReplyTo":"dd20490a6d7911e0e0814fbe2eee0cfea1faa4e5.1366999104.git.john@keeping.me.uk","subject":"Re: [PATCH] t/Makefile: remove smoke test targets","fromName":"Thomas Rast","fromEmail":"trast@inf.ethz.ch","sentAt":"2013-04-27T11:16:00Z","receivedAt":"2013-04-27T11:16:00Z","isPatch":true,"sender":{"key":"tr@thomasrast.ch","avatar":"https://avatars.githubusercontent.com/u/153510?v=4"},"body":"John Keeping <john@keeping.me.uk> writes:\n\n> Commit d24fbca (Remove Git's support for smoke testing - 2011-12-23)\n> removed the smoke test support from the test suite but it was re-added\n> by commit 342e9ef (Introduce a performance testing framework -\n> 2012-02-17).  This appears to be the result of a mis-merge, since\n> re-adding the smoke testing infrastructure does not relate to the\n> subject of that commit.\n>\n> The current 'smoke' target is broken since the 'harness' script it\n> uses no longer exists, so just reapply this section of commit d24fbca\n> and remove all of the smoke testing section in the makefile.\n>\n> Signed-off-by: John Keeping <john@keeping.me.uk>\n\nIndeed.  I must have mis-rebased this commit or some such.\n\nAcked-by: Thomas Rast <trast@inf.ethz.ch>\n\n-- \nThomas Rast\ntrast@{inf,student}.ethz.ch\n"}]}