{"thread":{"id":"33617","subject":"[PATCH 2/5] t9501: do not use export X=Y","startedAt":"2013-04-26T09:18:07Z","lastAt":"2013-04-26T09:18:07Z","messageCount":1,"participants":["Torsten Bögershausen"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"215579","messageId":"201304261118.07762.tboegi@web.de","threadId":"33617","inReplyTo":null,"subject":"[PATCH 2/5] t9501: do not use export X=Y","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-26T09:18:07Z","receivedAt":"2013-04-26T09:18:07Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"The shell syntax \"export X=Y\" is not understood by all shells.\nSplit the non portable line into separate lines like this:\nX=Y\nexport X\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n t/t9501-gitweb-standalone-http-status.sh | 15 ++++++++++-----\n 1 file changed, 10 insertions(+), 5 deletions(-)\n\ndiff --git a/t/t9501-gitweb-standalone-http-status.sh b/t/t9501-gitweb-standalone-http-status.sh\nindex ef86948..d3a5bac 100755\n--- a/t/t9501-gitweb-standalone-http-status.sh\n+++ b/t/t9501-gitweb-standalone-http-status.sh\n@@ -130,7 +130,8 @@ test_expect_success DATE_PARSER 'modification: feed last-modified' '\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=atom;h=master\" &&\n \tgrep \"Status: 200 OK\" gitweb.headers\n@@ -138,7 +139,8 @@ test_expect_success DATE_PARSER 'modification: feed if-modified-since (modified)\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: feed if-modified-since (unmodified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=atom;h=master\" &&\n \tgrep \"Status: 304 Not Modified\" gitweb.headers\n@@ -153,7 +155,8 @@ test_expect_success DATE_PARSER 'modification: snapshot last-modified' '\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=snapshot;h=master;sf=tgz\" &&\n \tgrep \"Status: 200 OK\" gitweb.headers\n@@ -161,7 +164,8 @@ test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (modif\n test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: snapshot if-modified-since (unmodified)' '\n-\texport HTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Thu, 7 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=snapshot;h=master;sf=tgz\" &&\n \tgrep \"Status: 304 Not Modified\" gitweb.headers\n@@ -170,7 +174,8 @@ test_debug 'cat gitweb.headers'\n \n test_expect_success DATE_PARSER 'modification: tree snapshot' '\n \tID=`git rev-parse --verify HEAD^{tree}` &&\n-\texport HTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\tHTTP_IF_MODIFIED_SINCE=\"Wed, 6 Apr 2005 22:14:13 +0000\" &&\n+\texport HTTP_IF_MODIFIED_SINCE &&\n \ttest_when_finished \"unset HTTP_IF_MODIFIED_SINCE\" &&\n \tgitweb_run \"p=.git;a=snapshot;h=$ID;sf=tgz\" &&\n \tgrep \"Status: 200 OK\" gitweb.headers &&\n-- \n1.8.2.1.614.g66d7af5\n"}]}