{"thread":{"id":"33611","subject":"[PATCH v2 0/9] remote-helpers: fixes and cleanups","startedAt":"2013-04-26T00:08:13Z","lastAt":"2013-04-26T01:12:08Z","messageCount":13,"participants":["Felipe Contreras","John Szakmeister"],"isPatch":true,"patchVersion":2,"patchTotal":9},"messages":[{"id":"215529","messageId":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":null,"subject":"[PATCH v2 0/9] remote-helpers: fixes and cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:13Z","receivedAt":"2013-04-26T00:08:13Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Hi,\n\nSame as before, minus one fix. This time they are based on 'next' so there\nshouldn't be any conflicts.\n\nHere's a bunch of cleanups mostly to synchronize remote-bzr and remote-hg.\n\nFelipe Contreras (9):\n remote-helpers: trivial cleanups\n remote-hg: remove extra check\n remote-bzr: fix bad state issue\n remote-bzr: add support to push URLs\n remote-hg: use hashlib instead of hg sha1 util\n remote-bzr: store converted URL\n remote-bzr: tell bazaar to be quiet\n remote-bzr: strip extra newline\n remote-bzr: use proper push method\n\n contrib/remote-helpers/git-remote-bzr | 55 ++++++++++++++++++++++++++++-------\n contrib/remote-helpers/git-remote-hg | 10 ++-----\n 2 files changed, 48 insertions(+), 17 deletions(-)\n\n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215530","messageId":"1366934902-18704-2-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 1/9] remote-helpers: trivial cleanups","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:14Z","receivedAt":"2013-04-26T00:08:14Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Signed-off-by: Felipe Contreras \n---\n\nDo I have to say it? If code is removed, it's because it's not used.\n\n contrib/remote-helpers/git-remote-bzr | 7 ++++---\n contrib/remote-helpers/git-remote-hg | 2 +-\n 2 files changed, 5 insertions(+), 4 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex cc6609b..87c54bf 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -94,7 +94,7 @@ class Marks:\n return self.last_mark\n \n def is_marked(self, rev):\n- return str(rev) in self.marks\n+ return rev in self.marks\n \n def new_mark(self, rev, mark):\n self.marks[rev] = mark\n@@ -224,7 +224,7 @@ def export_files(tree, files):\n else:\n mode = '100644'\n \n- # is the blog already exported?\n+ # is the blob already exported?\n if h in filenodes:\n mark = filenodes[h]\n final.append((mode, mark, path))\n@@ -521,7 +521,7 @@ def c_style_unescape(string):\n return string\n \n def parse_commit(parser):\n- global marks, blob_marks, bmarks, parsed_refs\n+ global marks, blob_marks, parsed_refs\n global mode\n \n parents = []\n@@ -643,6 +643,7 @@ def do_export(parser):\n wt = repo.bzrdir.open_workingtree()\n wt.update()\n print \"ok %s\" % ref\n+\n print\n \n def do_capabilities(parser):\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg\nindex fda4199..cfa96c1 100755\n--- a/contrib/remote-helpers/git-remote-hg\n+++ b/contrib/remote-helpers/git-remote-hg\n@@ -12,7 +12,7 @@\n # For remote repositories a local clone is stored in\n # \"$GIT_DIR/hg/origin/clone/.hg/\".\n \n-from mercurial import hg, ui, bookmarks, context, util, encoding, node, error, extensions\n+from mercurial import hg, ui, bookmarks, context, encoding, node, error, extensions\n \n import re\n import sys\n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215531","messageId":"1366934902-18704-3-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 2/9] remote-hg: remove extra check","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:15Z","receivedAt":"2013-04-26T00:08:15Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Not needed since we use xrange ourselves.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-hg | 4 ----\n 1 file changed, 4 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg\nindex cfa96c1..80b3606 100755\n--- a/contrib/remote-helpers/git-remote-hg\n+++ b/contrib/remote-helpers/git-remote-hg\n@@ -373,10 +373,6 @@ def export_ref(repo, name, kind, head):\n ename = '%s/%s' % (kind, name)\n tip = marks.get_tip(ename)\n \n- # mercurial takes too much time checking this\n- if tip and tip == head.rev():\n- # nothing to do\n- return\n revs = xrange(tip, head.rev() + 1)\n count = 0\n \n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215532","messageId":"1366934902-18704-4-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 3/9] remote-bzr: fix bad state issue","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:16Z","receivedAt":"2013-04-26T00:08:16Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Carried from remote-hg.\n\nThe problem reportedly happened after doing a push that fails, the abort\ncauses the state of remote-hg to go bad, this happens because\nremote-hg's marks are not stored, but 'git fast-export' marks are.\n\nEnsure that the marks are _always_ stored.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 6 ++++++\n 1 file changed, 6 insertions(+)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 87c54bf..7b6584e 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -32,6 +32,7 @@ import os\n import json\n import re\n import StringIO\n+import atexit\n \n NAME_RE = re.compile('^([^<>]+)')\n AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')\n@@ -728,6 +729,7 @@ def main(args):\n blob_marks = {}\n parsed_refs = {}\n files_cache = {}\n+ marks = None\n \n gitdir = os.environ['GIT_DIR']\n dirname = os.path.join(gitdir, 'bzr', alias)\n@@ -754,6 +756,10 @@ def main(args):\n die('unhandled command: %s' % line)\n sys.stdout.flush()\n \n+def bye():\n+ if not marks:\n+ return\n marks.store()\n \n+atexit.register(bye)\n sys.exit(main(sys.argv))\n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215533","messageId":"1366934902-18704-5-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 4/9] remote-bzr: add support to push URLs","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:17Z","receivedAt":"2013-04-26T00:08:17Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Just like in remote-hg.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 7b6584e..f1d6d5e 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -32,7 +32,7 @@ import os\n import json\n import re\n import StringIO\n-import atexit\n+import atexit, shutil, hashlib\n \n NAME_RE = re.compile('^([^<>]+)')\n AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')\n@@ -719,11 +719,11 @@ def main(args):\n global blob_marks\n global parsed_refs\n global files_cache\n+ global is_tmp\n \n alias = args[1]\n url = args[2]\n \n- prefix = 'refs/bzr/%s' % alias\n tags = {}\n filenodes = {}\n blob_marks = {}\n@@ -731,6 +731,13 @@ def main(args):\n files_cache = {}\n marks = None\n \n+ if alias[5:] == url:\n+ is_tmp = True\n+ alias = hashlib.sha1(alias).hexdigest()\n+ else:\n+ is_tmp = False\n+\n+ prefix = 'refs/bzr/%s' % alias\n gitdir = os.environ['GIT_DIR']\n dirname = os.path.join(gitdir, 'bzr', alias)\n \n@@ -759,7 +766,10 @@ def main(args):\n def bye():\n if not marks:\n return\n- marks.store()\n+ if not is_tmp:\n+ marks.store()\n+ else:\n+ shutil.rmtree(dirname)\n \n atexit.register(bye)\n sys.exit(main(sys.argv))\n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215534","messageId":"1366934902-18704-6-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 5/9] remote-hg: use hashlib instead of hg sha1 util","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:18Z","receivedAt":"2013-04-26T00:08:18Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"To be in sync with remote-bzr.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-hg | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg\nindex 80b3606..06920f2 100755\n--- a/contrib/remote-helpers/git-remote-hg\n+++ b/contrib/remote-helpers/git-remote-hg\n@@ -22,7 +22,7 @@ import shutil\n import subprocess\n import urllib\n import atexit\n-import urlparse\n+import urlparse, hashlib\n \n #\n # If you want to switch to hg-git compatibility mode:\n@@ -933,7 +933,7 @@ def main(args):\n \n if alias[4:] == url:\n is_tmp = True\n- alias = util.sha1(alias).hexdigest()\n+ alias = hashlib.sha1(alias).hexdigest()\n else:\n is_tmp = False\n \n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215535","messageId":"1366934902-18704-7-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 6/9] remote-bzr: store converted URL","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:19Z","receivedAt":"2013-04-26T00:08:19Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Mercurial might convert the URL to something more appropriate, like an\nabsolute path. Lets store that instead of the original URL, which won't\nwork from a different working directory if it's relative.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex f1d6d5e..dda2932 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -32,7 +32,7 @@ import os\n import json\n import re\n import StringIO\n-import atexit, shutil, hashlib\n+import atexit, shutil, hashlib, urlparse, subprocess\n \n NAME_RE = re.compile('^([^<>]+)')\n AUTHOR_RE = re.compile('^([^<>]+?)? ?<([^<>]*)>$')\n@@ -713,6 +713,14 @@ def get_repo(url, alias):\n \n return branch\n \n+def fix_path(alias, orig_url):\n+ url = urlparse.urlparse(orig_url, 'file')\n+ if url.scheme != 'file' or os.path.isabs(url.path):\n+ return\n+ abs_url = urlparse.urljoin(\"%s/\" % os.getcwd(), orig_url)\n+ cmd = ['git', 'config', 'remote.%s.url' % alias, \"bzr::%s\" % abs_url]\n+ subprocess.call(cmd)\n+\n def main(args):\n global marks, prefix, dirname\n global tags, filenodes\n@@ -741,6 +749,9 @@ def main(args):\n gitdir = os.environ['GIT_DIR']\n dirname = os.path.join(gitdir, 'bzr', alias)\n \n+ if not is_tmp:\n+ fix_path(alias, url)\n+\n if not os.path.exists(dirname):\n os.makedirs(dirname)\n \n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215536","messageId":"1366934902-18704-8-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 7/9] remote-bzr: tell bazaar to be quiet","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:20Z","receivedAt":"2013-04-26T00:08:20Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Otherwise we get notification, progress bars, and what not.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 3 +++\n 1 file changed, 3 insertions(+)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex dda2932..8617e25 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -26,6 +26,7 @@ bzrlib.plugin.load_plugins()\n import bzrlib.generate_ids\n import bzrlib.transport\n import bzrlib.errors\n+import bzrlib.ui\n \n import sys\n import os\n@@ -755,6 +756,8 @@ def main(args):\n if not os.path.exists(dirname):\n os.makedirs(dirname)\n \n+ bzrlib.ui.ui_factory.be_quiet(True)\n+\n repo = get_repo(url, alias)\n \n marks_path = os.path.join(dirname, 'marks-int')\n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215537","messageId":"1366934902-18704-9-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 8/9] remote-bzr: strip extra newline","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:21Z","receivedAt":"2013-04-26T00:08:21Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"It's added by fast-export, the user didn't type it.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 8617e25..9f56297 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -549,6 +549,10 @@ def parse_commit(parser):\n parents.append(parser.get_mark())\n parser.next()\n \n+ # fast-export adds an extra newline\n+ if data[-1] == '\\n':\n+ data = data[:-1]\n+\n files = {}\n \n for line in parser:\n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215538","messageId":"1366934902-18704-10-git-send-email-felipe.contreras@gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH v2 9/9] remote-bzr: use proper push method","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T00:08:22Z","receivedAt":"2013-04-26T00:08:22Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Do not just randomly synchronize the revisions with no checks at all.\n\nI don't have any evidence that there's anything wrong with the current code,\nwhich Bazaar seems to use, but for different purposes. Let's use the logic\nBazaar UI uses to avoid surprises.\n\nAlso, add a non-ff check.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/git-remote-bzr | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)\n\ndiff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\nindex 9f56297..c19ed0e 100755\n--- a/contrib/remote-helpers/git-remote-bzr\n+++ b/contrib/remote-helpers/git-remote-bzr\n@@ -639,12 +639,12 @@ def do_export(parser):\n for ref, revid in parsed_refs.iteritems():\n if ref == 'refs/heads/master':\n repo.generate_revision_history(revid, marks.get_tip('master'))\n- revno, revid = repo.last_revision_info()\n if peer:\n- if hasattr(peer, \"import_last_revision_info_and_tags\"):\n- peer.import_last_revision_info_and_tags(repo, revno, revid)\n- else:\n- peer.import_last_revision_info(repo.repository, revno, revid)\n+ try:\n+ repo.push(peer, stop_revision=revid)\n+ except bzrlib.errors.DivergedBranches:\n+ print \"error %s non-fast forward\" % ref\n+ continue\n else:\n wt = repo.bzrdir.open_workingtree()\n wt.update()\n-- \n1.8.2.1.884.g3532a8d\n"},{"id":"215540","messageId":"CAEBDL5XmrxV3SdtdyjJq=HxUqVcLCMz_Fcq9=POm=oaWtrO4LQ@mail.gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-7-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH v2 6/9] remote-bzr: store converted URL","fromName":"John Szakmeister","fromEmail":"john@szakmeister.net","sentAt":"2013-04-26T00:58:16Z","receivedAt":"2013-04-26T00:58:16Z","isPatch":true,"sender":{"key":"john@szakmeister.net","avatar":"https://avatars.githubusercontent.com/u/448087?v=4"},"body":"On Thu, Apr 25, 2013 at 8:08 PM, Felipe Contreras\n wrote:\n> Mercurial might convert the URL to something more appropriate, like an\n> absolute path. Lets store that instead of the original URL, which won't\n> work from a different working directory if it's relative.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n> contrib/remote-helpers/git-remote-bzr | 13 ++++++++++++-\n> 1 file changed, 12 insertions(+), 1 deletion(-)\n\n\nFWIW, it feels weird to be talking about Mercurial when you're\npatching git-remote-bzr. :-)\n\n-John\n"},{"id":"215541","messageId":"CAEBDL5Uaw6t=T1NOhRDutmH_V0dax3Pzger9Ti34Dy4tPT3K0A@mail.gmail.com","threadId":"33611","inReplyTo":"1366934902-18704-8-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH v2 7/9] remote-bzr: tell bazaar to be quiet","fromName":"John Szakmeister","fromEmail":"john@szakmeister.net","sentAt":"2013-04-26T00:59:34Z","receivedAt":"2013-04-26T00:59:34Z","isPatch":true,"sender":{"key":"john@szakmeister.net","avatar":"https://avatars.githubusercontent.com/u/448087?v=4"},"body":"On Thu, Apr 25, 2013 at 8:08 PM, Felipe Contreras\n wrote:\n> Otherwise we get notification, progress bars, and what not.\n>\n> Signed-off-by: Felipe Contreras \n> ---\n> contrib/remote-helpers/git-remote-bzr | 3 +++\n> 1 file changed, 3 insertions(+)\n>\n> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr\n> index dda2932..8617e25 100755\n> --- a/contrib/remote-helpers/git-remote-bzr\n> +++ b/contrib/remote-helpers/git-remote-bzr\n> @@ -26,6 +26,7 @@ bzrlib.plugin.load_plugins()\n> import bzrlib.generate_ids\n> import bzrlib.transport\n> import bzrlib.errors\n> +import bzrlib.ui\n>\n> import sys\n> import os\n> @@ -755,6 +756,8 @@ def main(args):\n> if not os.path.exists(dirname):\n> os.makedirs(dirname)\n>\n> + bzrlib.ui.ui_factory.be_quiet(True)\n> +\n\nNice change!\n\n-John\n"},{"id":"215563","messageId":"CAMP44s0csoD7y-YND-VyVWuZc+GxK7JPf5DLibXZxnFHNakjDw@mail.gmail.com","threadId":"33611","inReplyTo":"CAEBDL5XmrxV3SdtdyjJq=HxUqVcLCMz_Fcq9=POm=oaWtrO4LQ@mail.gmail.com","subject":"Re: [PATCH v2 6/9] remote-bzr: store converted URL","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-26T01:12:08Z","receivedAt":"2013-04-26T01:12:08Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Thu, Apr 25, 2013 at 7:58 PM, John Szakmeister wrote:\n> On Thu, Apr 25, 2013 at 8:08 PM, Felipe Contreras\n> wrote:\n>> Mercurial might convert the URL to something more appropriate, like an\n>> absolute path. Lets store that instead of the original URL, which won't\n>> work from a different working directory if it's relative.\n>>\n>> Signed-off-by: Felipe Contreras \n>> ---\n>> contrib/remote-helpers/git-remote-bzr | 13 ++++++++++++-\n>> 1 file changed, 12 insertions(+), 1 deletion(-)\n>\n>\n> FWIW, it feels weird to be talking about Mercurial when you're\n> patching git-remote-bzr. :-)\n\nYeah, it happens all the time in my local repos. I'm surprised it took\nso long to send a patch with this mistake =/\n\n-- \nFelipe Contreras\n"}]}