{"thread":{"id":"33561","subject":"[PATCH 0/5] Minor additions to git-completion.bash","startedAt":"2013-04-21T13:05:46Z","lastAt":"2013-04-29T04:58:53Z","messageCount":10,"participants":["Ramkumar Ramachandra","Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":5},"messages":[{"id":"215012","messageId":"1366549551-18763-1-git-send-email-artagnon@gmail.com","threadId":"33561","inReplyTo":null,"subject":"[PATCH 0/5] Minor additions to git-completion.bash","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-21T13:05:46Z","receivedAt":"2013-04-21T13:05:46Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Hi,\n\nI just looked at the config section, and started writing patches, and\nkept going until I got bored.  So they're pretty random.\n\nSorry about the triviality of the patches: I was just looking to kill\nsome time on a lazy Sunday afternoon.\n\nThanks.\n\nRamkumar Ramachandra (5):\n  git-completion.bash: lexical sorting for diff.statGraphWidth\n  git-completion.bash: add diff.submodule to config list\n  git-completion.bash: complete branch.*.rebase as boolean\n  git-completion.bash: add branch.*.pushremote to config list\n  git-completion.bash: add remote.pushdefault to config list\n\n contrib/completion/git-completion.bash | 20 +++++++++++++++++---\n 1 file changed, 17 insertions(+), 3 deletions(-)\n\n-- \n1.8.2.1.501.gd2949c7\n"},{"id":"215014","messageId":"1366549551-18763-2-git-send-email-artagnon@gmail.com","threadId":"33561","inReplyTo":"1366549551-18763-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 1/5] git-completion.bash: lexical sorting for diff.statGraphWidth","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-21T13:05:47Z","receivedAt":"2013-04-21T13:05:47Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"df44483a (diff --stat: add config option to limit graph width,\n2012-03-01) added the option diff.startGraphWidth to the list of\nconfiguration variables in git-completion.bash, but failed to notice\nthat the list is sorted alphabetically.  Move it to its rightful place\nin the list.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 6df62c2..6bfb9ad 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -2058,13 +2058,13 @@ _git_config ()\n \t\tcore.whitespace\n \t\tcore.worktree\n \t\tdiff.autorefreshindex\n-\t\tdiff.statGraphWidth\n \t\tdiff.external\n \t\tdiff.ignoreSubmodules\n \t\tdiff.mnemonicprefix\n \t\tdiff.noprefix\n \t\tdiff.renameLimit\n \t\tdiff.renames\n+\t\tdiff.statGraphWidth\n \t\tdiff.suppressBlankEmpty\n \t\tdiff.tool\n \t\tdiff.wordRegex\n-- \n1.8.2.1.501.gd2949c7\n"},{"id":"215013","messageId":"1366549551-18763-3-git-send-email-artagnon@gmail.com","threadId":"33561","inReplyTo":"1366549551-18763-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 2/5] git-completion.bash: add diff.submodule to config list","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-21T13:05:48Z","receivedAt":"2013-04-21T13:05:48Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"c47ef57 (diff: introduce diff.submodule configuration variable,\n2012-11-13) introduced the diff.submodule configuration variable, but\nforgot to teach git-completion.bash about it.  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 6bfb9ad..f799dc8 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1864,6 +1864,10 @@ _git_config ()\n \t\t\t\"\n \t\treturn\n \t\t;;\n+\tdiff.submodule)\n+\t\t__gitcomp \"log short\"\n+\t\treturn\n+\t\t;;\n \thelp.format)\n \t\t__gitcomp \"man info web html\"\n \t\treturn\n@@ -2065,6 +2069,7 @@ _git_config ()\n \t\tdiff.renameLimit\n \t\tdiff.renames\n \t\tdiff.statGraphWidth\n+\t\tdiff.submodule\n \t\tdiff.suppressBlankEmpty\n \t\tdiff.tool\n \t\tdiff.wordRegex\n-- \n1.8.2.1.501.gd2949c7\n"},{"id":"215015","messageId":"1366549551-18763-4-git-send-email-artagnon@gmail.com","threadId":"33561","inReplyTo":"1366549551-18763-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 3/5] git-completion.bash: complete branch.*.rebase as boolean","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-21T13:05:49Z","receivedAt":"2013-04-21T13:05:49Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"6fac1b83 (completion: add missing config variables, 2009-06-29) added\n\"rebase\" to the list of completions for \"branch.*.*\", but forgot to\nspecify completions for the values that this configuration variable\ncan take (namely \"false\" and \"true\").  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex f799dc8..843273c 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1825,6 +1825,10 @@ _git_config ()\n \t\t__gitcomp_nl \"$(__git_refs)\"\n \t\treturn\n \t\t;;\n+\tbranch.*.rebase)\n+\t\t__gitcomp \"false true\"\n+\t\treturn\n+\t\t;;\n \tremote.*.fetch)\n \t\tlocal remote=\"${prev#remote.}\"\n \t\tremote=\"${remote%.fetch}\"\n-- \n1.8.2.1.501.gd2949c7\n"},{"id":"215017","messageId":"1366549551-18763-5-git-send-email-artagnon@gmail.com","threadId":"33561","inReplyTo":"1366549551-18763-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 4/5] git-completion.bash: add branch.*.pushremote to config list","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-21T13:05:50Z","receivedAt":"2013-04-21T13:05:50Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"9f765ce (remote.c: introduce branch.<name>.pushremote, 2013-04-02)\nintroduced the configuration variable branch.*.pushremote, but forgot\nto teach git-completion.bash about it.  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex 843273c..fa0d604 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1817,7 +1817,7 @@ __git_config_get_set_variables ()\n _git_config ()\n {\n \tcase \"$prev\" in\n-\tbranch.*.remote)\n+\tbranch.*.remote|branch.*.pushremote)\n \t\t__gitcomp_nl \"$(__git_remotes)\"\n \t\treturn\n \t\t;;\n@@ -1913,7 +1913,7 @@ _git_config ()\n \t\t;;\n \tbranch.*.*)\n \t\tlocal pfx=\"${cur%.*}.\" cur_=\"${cur##*.}\"\n-\t\t__gitcomp \"remote merge mergeoptions rebase\" \"$pfx\" \"$cur_\"\n+\t\t__gitcomp \"remote pushremote merge mergeoptions rebase\" \"$pfx\" \"$cur_\"\n \t\treturn\n \t\t;;\n \tbranch.*)\n-- \n1.8.2.1.501.gd2949c7\n"},{"id":"215016","messageId":"1366549551-18763-6-git-send-email-artagnon@gmail.com","threadId":"33561","inReplyTo":"1366549551-18763-1-git-send-email-artagnon@gmail.com","subject":"[PATCH 5/5] git-completion.bash: add remote.pushdefault to config list","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-21T13:05:51Z","receivedAt":"2013-04-21T13:05:51Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"224c2171 (remote.c: introduce remote.pushdefault, 2013-04-02)\nintroduced the remote.pushdefault configuration variable, but forgot\nto teach git-completion.bash about it.  Fix this.\n\nSigned-off-by: Ramkumar Ramachandra <artagnon@gmail.com>\n---\n contrib/completion/git-completion.bash | 5 +++++\n 1 file changed, 5 insertions(+)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex fa0d604..d0cb4f1 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -1829,6 +1829,10 @@ _git_config ()\n \t\t__gitcomp \"false true\"\n \t\treturn\n \t\t;;\n+\tremote.pushdefault)\n+\t\t__gitcomp_nl \"$(__git_remotes)\"\n+\t\treturn\n+\t\t;;\n \tremote.*.fetch)\n \t\tlocal remote=\"${prev#remote.}\"\n \t\tremote=\"${remote%.fetch}\"\n@@ -2208,6 +2212,7 @@ _git_config ()\n \t\treceive.fsckObjects\n \t\treceive.unpackLimit\n \t\treceive.updateserverinfo\n+\t\tremote.pushdefault\n \t\tremotes.\n \t\trepack.usedeltabaseoffset\n \t\trerere.autoupdate\n-- \n1.8.2.1.501.gd2949c7\n"},{"id":"215372","messageId":"CALkWK0mgfVNqOxaVY-JgKrzQe3rCJvaQuvp7frZKh7orRwdtig@mail.gmail.com","threadId":"33561","inReplyTo":"1366549551-18763-1-git-send-email-artagnon@gmail.com","subject":"Re: [PATCH 0/5] Minor additions to git-completion.bash","fromName":"Ramkumar Ramachandra","fromEmail":"artagnon@gmail.com","sentAt":"2013-04-24T19:49:09Z","receivedAt":"2013-04-24T19:49:09Z","isPatch":true,"sender":{"key":"r@artagnon.com","avatar":"https://avatars.githubusercontent.com/u/37226?v=4"},"body":"Ramkumar Ramachandra wrote:\n> [...]\n\nAny updates on this?\n"},{"id":"215671","messageId":"CAMP44s1K9VYNbGFkec6mJ-xBZBafKvZqvu949DcVae12fuG9xA@mail.gmail.com","threadId":"33561","inReplyTo":"CALkWK0mgfVNqOxaVY-JgKrzQe3rCJvaQuvp7frZKh7orRwdtig@mail.gmail.com","subject":"Re: [PATCH 0/5] Minor additions to git-completion.bash","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-27T01:57:11Z","receivedAt":"2013-04-27T01:57:11Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Wed, Apr 24, 2013 at 2:49 PM, Ramkumar Ramachandra\n<artagnon@gmail.com> wrote:\n> Ramkumar Ramachandra wrote:\n>> [...]\n>\n> Any updates on this?\n\nFWIW they all look OK to me.\n\n-- \nFelipe Contreras\n"},{"id":"215797","messageId":"7vvc76qyo4.fsf@alter.siamese.dyndns.org","threadId":"33561","inReplyTo":"CAMP44s1K9VYNbGFkec6mJ-xBZBafKvZqvu949DcVae12fuG9xA@mail.gmail.com","subject":"Re: [PATCH 0/5] Minor additions to git-completion.bash","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-28T18:48:27Z","receivedAt":"2013-04-28T18:48:27Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras <felipe.contreras@gmail.com> writes:\n\n> On Wed, Apr 24, 2013 at 2:49 PM, Ramkumar Ramachandra\n> <artagnon@gmail.com> wrote:\n>> Ramkumar Ramachandra wrote:\n>>> [...]\n>>\n>> Any updates on this?\n>\n> FWIW they all look OK to me.\n\nI do not have the original series, so a resend with Felipe's Acked-by\nafter your original Sign-off would be nice.\n\nThanks.\n"},{"id":"215821","messageId":"CAMP44s0Rp2mJ67f+=sq_g78hNCQSiStkeBMtcfK+kS30S=cXVg@mail.gmail.com","threadId":"33561","inReplyTo":"7vvc76qyo4.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH 0/5] Minor additions to git-completion.bash","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-29T04:58:53Z","receivedAt":"2013-04-29T04:58:53Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Apr 28, 2013 at 1:48 PM, Junio C Hamano <gitster@pobox.com> wrote:\n> Felipe Contreras <felipe.contreras@gmail.com> writes:\n>\n>> On Wed, Apr 24, 2013 at 2:49 PM, Ramkumar Ramachandra\n>> <artagnon@gmail.com> wrote:\n>>> Ramkumar Ramachandra wrote:\n>>>> [...]\n>>>\n>>> Any updates on this?\n>>\n>> FWIW they all look OK to me.\n>\n> I do not have the original series, so a resend with Felipe's Acked-by\n> after your original Sign-off would be nice.\n\nI only gave them a quick look.\n\n-- \nFelipe Contreras\n"}]}