{"thread":{"id":"33489","subject":"[PATCH] fast-export: fix argument name in error messages","startedAt":"2013-04-12T14:05:55Z","lastAt":"2013-04-12T16:50:11Z","messageCount":2,"participants":["Paul Price","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"214058","messageId":"43FA6C2A-A2C3-474F-889A-8059CE24175A@astro.princeton.edu","threadId":"33489","inReplyTo":null,"subject":"[PATCH] fast-export: fix argument name in error messages","fromName":"Paul Price","fromEmail":"price@astro.princeton.edu","sentAt":"2013-04-12T14:05:55Z","receivedAt":"2013-04-12T14:05:55Z","isPatch":true,"sender":{"key":"price@astro.princeton.edu","avatar":null},"body":"The --signed-tags argument is plural, while error messages referred\nto --signed-tag (singular).  Tweak error messages to correspond to the\nargument.\n\nSigned-off-by: Paul Price <price@astro.princeton.edu>\n---\nFirst submission; please report any formatting or style errors privately.\n\nbuiltin/fast-export.c | 4 ++--\n1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/builtin/fast-export.c b/builtin/fast-export.c\nindex 77dffd1..ad9d0c4 100644\n--- a/builtin/fast-export.c\n+++ b/builtin/fast-export.c\n@@ -43,7 +43,7 @@ static int parse_opt_signed_tag_mode(const struct option *opt,\n\telse if (!strcmp(arg, \"strip\"))\n\t\tsigned_tag_mode = STRIP;\n\telse\n-\t\treturn error(\"Unknown signed-tag mode: %s\", arg);\n+\t\treturn error(\"Unknown signed-tags mode: %s\", arg);\n\treturn 0;\n}\n\n@@ -416,7 +416,7 @@ static void handle_tag(const char *name, struct tag *tag)\n\t\t\tswitch(signed_tag_mode) {\n\t\t\tcase ABORT:\n\t\t\t\tdie (\"Encountered signed tag %s; use \"\n-\t\t\t\t     \"--signed-tag=<mode> to handle it.\",\n+\t\t\t\t     \"--signed-tags=<mode> to handle it.\",\n\t\t\t\t     sha1_to_hex(tag->object.sha1));\n\t\t\tcase WARN:\n\t\t\t\twarning (\"Exporting signed tag %s\",\n-- \n1.8.1.1\n"},{"id":"214076","messageId":"7vy5cnelrw.fsf@alter.siamese.dyndns.org","threadId":"33489","inReplyTo":"43FA6C2A-A2C3-474F-889A-8059CE24175A@astro.princeton.edu","subject":"Re: [PATCH] fast-export: fix argument name in error messages","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-12T16:50:11Z","receivedAt":"2013-04-12T16:50:11Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Paul Price <price@astro.princeton.edu> writes:\n\n> The --signed-tags argument is plural, while error messages referred\n> to --signed-tag (singular).  Tweak error messages to correspond to the\n> argument.\n>\n> Signed-off-by: Paul Price <price@astro.princeton.edu>\n> ---\n> First submission; please report any formatting or style errors privately.\n\nThe patch is trivially whitespace-damaged but was easy enough to\ncorrect locally here.\n\nApplied; thanks.\n\n>\n> builtin/fast-export.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/builtin/fast-export.c b/builtin/fast-export.c\n> index 77dffd1..ad9d0c4 100644\n> --- a/builtin/fast-export.c\n> +++ b/builtin/fast-export.c\n> @@ -43,7 +43,7 @@ static int parse_opt_signed_tag_mode(const struct option *opt,\n> \telse if (!strcmp(arg, \"strip\"))\n> \t\tsigned_tag_mode = STRIP;\n> \telse\n> -\t\treturn error(\"Unknown signed-tag mode: %s\", arg);\n> +\t\treturn error(\"Unknown signed-tags mode: %s\", arg);\n> \treturn 0;\n> }\n>\n> @@ -416,7 +416,7 @@ static void handle_tag(const char *name, struct tag *tag)\n> \t\t\tswitch(signed_tag_mode) {\n> \t\t\tcase ABORT:\n> \t\t\t\tdie (\"Encountered signed tag %s; use \"\n> -\t\t\t\t     \"--signed-tag=<mode> to handle it.\",\n> +\t\t\t\t     \"--signed-tags=<mode> to handle it.\",\n> \t\t\t\t     sha1_to_hex(tag->object.sha1));\n> \t\t\tcase WARN:\n> \t\t\t\twarning (\"Exporting signed tag %s\",\n"}]}