{"thread":{"id":"33414","subject":"[PATCH] remote-helpers/test-bzr.sh: do not use grep \\s","startedAt":"2013-04-07T08:48:30Z","lastAt":"2013-04-07T09:04:05Z","messageCount":3,"participants":["Torsten Bögershausen","Felipe Contreras","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"213394","messageId":"201304071048.31790.tboegi@web.de","threadId":"33414","inReplyTo":null,"subject":"[PATCH] remote-helpers/test-bzr.sh: do not use grep \\s","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-07T08:48:30Z","receivedAt":"2013-04-07T08:48:30Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"Using grep \"devel\\s\\+3:\" to find at least one whitspace\nis not portable on all grep versions:\nNot all grep versions understand \"\\s\" as a \"whitespace\".\n\nUse a literal TAB followed by SPACE like this [\t ] instead.\nThe + as a qualifier for \"one or more\" is not a basic regular expression:\nuse egrep instead of grep.\n\nSigned-off-by: Torsten Bögershausen <tboegi@web.de>\n---\n contrib/remote-helpers/test-hg.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh\nindex 5f81dfa..7bb81f2 100755\n--- a/contrib/remote-helpers/test-hg.sh\n+++ b/contrib/remote-helpers/test-hg.sh\n@@ -115,7 +115,7 @@ test_expect_success 'update bookmark' '\n   git push\n   ) &&\n \n-  hg -R hgrepo bookmarks | grep \"devel\\s\\+3:\"\n+  hg -R hgrepo bookmarks | egrep \"devel[\t ]+3:\"\n '\n \n test_done\n-- \n1.8.2.341.g543621f\n"},{"id":"213396","messageId":"CAMP44s06=KCDfQuK1t2ZURoOzmF69pDXF0G6eji6EsiMAoBLbQ@mail.gmail.com","threadId":"33414","inReplyTo":"201304071048.31790.tboegi@web.de","subject":"Re: [PATCH] remote-helpers/test-bzr.sh: do not use grep \\s","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-07T09:02:54Z","receivedAt":"2013-04-07T09:02:54Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sun, Apr 7, 2013 at 3:48 AM, Torsten Bögershausen <tboegi@web.de> wrote:\n> Using grep \"devel\\s\\+3:\" to find at least one whitspace\n> is not portable on all grep versions:\n> Not all grep versions understand \"\\s\" as a \"whitespace\".\n>\n> Use a literal TAB followed by SPACE like this [  ] instead.\n> The + as a qualifier for \"one or more\" is not a basic regular expression:\n> use egrep instead of grep.\n\nIf \"\\t\" is not possible, I would rather use [:space:].\n\nCheers.\n\n-- \nFelipe Contreras\n"},{"id":"213398","messageId":"CAPig+cQVcD_Ba2ZPvi0=GcBVhn_eHQeeAukm427kK=AnDSpMow@mail.gmail.com","threadId":"33414","inReplyTo":"201304071048.31790.tboegi@web.de","subject":"Re: [PATCH] remote-helpers/test-bzr.sh: do not use grep \\s","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2013-04-07T09:04:05Z","receivedAt":"2013-04-07T09:04:05Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Apr 7, 2013 at 4:48 AM, Torsten Bögershausen <tboegi@web.de> wrote:\n> Using grep \"devel\\s\\+3:\" to find at least one whitspace\n\ns/whitspace/whitespace/\n\n> is not portable on all grep versions:\n> Not all grep versions understand \"\\s\" as a \"whitespace\".\n>\n> Use a literal TAB followed by SPACE like this [  ] instead.\n> The + as a qualifier for \"one or more\" is not a basic regular expression:\n> use egrep instead of grep.\n>\n> Signed-off-by: Torsten Bögershausen <tboegi@web.de>\n"}]}