{"thread":{"id":"33412","subject":"[PATCH] format-patch: trivial cleanup","startedAt":"2013-04-07T07:18:59Z","lastAt":"2013-04-07T08:16:00Z","messageCount":2,"participants":["Felipe Contreras","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"213383","messageId":"1365319139-12362-1-git-send-email-felipe.contreras@gmail.com","threadId":"33412","inReplyTo":null,"subject":"[PATCH] format-patch: trivial cleanup","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-07T07:18:59Z","receivedAt":"2013-04-07T07:18:59Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n---\n\nActually, now that we are on it. After applying my latest patch series, this makes sense.\n\n builtin/log.c | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)\n\ndiff --git a/builtin/log.c b/builtin/log.c\nindex fab7998..7cf9277 100644\n--- a/builtin/log.c\n+++ b/builtin/log.c\n@@ -1058,12 +1058,10 @@ static char *find_branch_name(struct rev_info *rev)\n \t\telse\n \t\t\treturn NULL;\n \t}\n-\tif (0 <= positive) {\n-\t\tref = rev->cmdline.rev[positive].name;\n-\t\ttip_sha1 = rev->cmdline.rev[positive].item->sha1;\n-\t} else {\n+\tif (positive < 0)\n \t\treturn NULL;\n-\t}\n+\tref = rev->cmdline.rev[positive].name;\n+\ttip_sha1 = rev->cmdline.rev[positive].item->sha1;\n \tif (dwim_ref(ref, strlen(ref), branch_sha1, &full_ref) &&\n \t    !prefixcmp(full_ref, \"refs/heads/\") &&\n \t    !hashcmp(tip_sha1, branch_sha1))\n-- \n1.8.2\n"},{"id":"213391","messageId":"7vzjxa7o3j.fsf@alter.siamese.dyndns.org","threadId":"33412","inReplyTo":"1365319139-12362-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH] format-patch: trivial cleanup","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-07T08:16:00Z","receivedAt":"2013-04-07T08:16:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras <felipe.contreras@gmail.com> writes:\n\n> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>\n> ---\n>\n> Actually, now that we are on it. After applying my latest patch series, this makes sense.\n\nYes, this is way easier to read.\n\n>\n>  builtin/log.c | 8 +++-----\n>  1 file changed, 3 insertions(+), 5 deletions(-)\n>\n> diff --git a/builtin/log.c b/builtin/log.c\n> index fab7998..7cf9277 100644\n> --- a/builtin/log.c\n> +++ b/builtin/log.c\n> @@ -1058,12 +1058,10 @@ static char *find_branch_name(struct rev_info *rev)\n>  \t\telse\n>  \t\t\treturn NULL;\n>  \t}\n> -\tif (0 <= positive) {\n> -\t\tref = rev->cmdline.rev[positive].name;\n> -\t\ttip_sha1 = rev->cmdline.rev[positive].item->sha1;\n> -\t} else {\n> +\tif (positive < 0)\n>  \t\treturn NULL;\n> -\t}\n> +\tref = rev->cmdline.rev[positive].name;\n> +\ttip_sha1 = rev->cmdline.rev[positive].item->sha1;\n>  \tif (dwim_ref(ref, strlen(ref), branch_sha1, &full_ref) &&\n>  \t    !prefixcmp(full_ref, \"refs/heads/\") &&\n>  \t    !hashcmp(tip_sha1, branch_sha1))\n"}]}