{"thread":{"id":"33407","subject":"[PATCH] gitremote-helpers(1): clarify refspec behaviour","startedAt":"2013-04-06T18:13:41Z","lastAt":"2013-04-17T22:30:33Z","messageCount":3,"participants":["John Keeping","Sverre Rabbelier","Felipe Contreras"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"213354","messageId":"505914600ac7f4afc26f8b29fbece26156c87519.1365272021.git.john@keeping.me.uk","threadId":"33407","inReplyTo":null,"subject":"[PATCH] gitremote-helpers(1): clarify refspec behaviour","fromName":"John Keeping","fromEmail":"john@keeping.me.uk","sentAt":"2013-04-06T18:13:41Z","receivedAt":"2013-04-06T18:13:41Z","isPatch":true,"sender":{"key":"john@keeping.me.uk","avatar":"https://avatars.githubusercontent.com/u/1702081?v=4"},"body":"The documentation says that \"If no 'refspec' capability is advertised,\nthere is an implied `refspec *:*`\" but this is only the case for the\n\"import\" command.\n\nSince there is a comment in transport-helper.c indicating that this\ndefault is for historical reasons, change the documentation to clarify\nthat a refspec should always be specified.\n\nSigned-off-by: John Keeping <john@keeping.me.uk>\n---\n Documentation/gitremote-helpers.txt | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt\nindex 0c91aba..f506031 100644\n--- a/Documentation/gitremote-helpers.txt\n+++ b/Documentation/gitremote-helpers.txt\n@@ -174,8 +174,8 @@ ref.\n This capability can be advertised multiple times.  The first\n applicable refspec takes precedence.  The left-hand of refspecs\n advertised with this capability must cover all refs reported by\n-the list command.  If no 'refspec' capability is advertised,\n-there is an implied `refspec *:*`.\n+the list command.  If a helper does not need a specific 'refspec'\n+capability then it should advertise `refspec *:*`.\n \n 'bidi-import'::\n \tThis modifies the 'import' capability.\n-- \n1.8.2.692.g17a9715\n"},{"id":"213361","messageId":"CAGdFq_jrYu23yyQyDEDD=72f7UrhWBL0bnmZ7XLtBM=F4Hwzug@mail.gmail.com","threadId":"33407","inReplyTo":"505914600ac7f4afc26f8b29fbece26156c87519.1365272021.git.john@keeping.me.uk","subject":"Re: [PATCH] gitremote-helpers(1): clarify refspec behaviour","fromName":"Sverre Rabbelier","fromEmail":"srabbelier@gmail.com","sentAt":"2013-04-06T18:15:14Z","receivedAt":"2013-04-06T18:15:14Z","isPatch":true,"sender":{"key":"srabbelier@gmail.com","avatar":"https://avatars.githubusercontent.com/u/3098?v=4"},"body":"In Sat, Apr 6, 2013 at 11:13 AM, John Keeping <john@keeping.me.uk> wrote:\n> The documentation says that \"If no 'refspec' capability is advertised,\n> there is an implied `refspec *:*`\" but this is only the case for the\n> \"import\" command.\n>\n> Since there is a comment in transport-helper.c indicating that this\n> default is for historical reasons, change the documentation to clarify\n> that a refspec should always be specified.\n>\n> Signed-off-by: John Keeping <john@keeping.me.uk>\n\nAcked-by: Sverre Rabbelier <srabbelier@gmail.com>\n\n--\nCheers,\n\nSverre Rabbelier\n"},{"id":"214648","messageId":"CAMP44s38Cqcr4mwDBexW4tHzv3BKffCYEn5oN0U6Wji10nmJMw@mail.gmail.com","threadId":"33407","inReplyTo":"505914600ac7f4afc26f8b29fbece26156c87519.1365272021.git.john@keeping.me.uk","subject":"Re: [PATCH] gitremote-helpers(1): clarify refspec behaviour","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-17T22:30:33Z","receivedAt":"2013-04-17T22:30:33Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Sat, Apr 6, 2013 at 12:13 PM, John Keeping <john@keeping.me.uk> wrote:\n\n> --- a/Documentation/gitremote-helpers.txt\n> +++ b/Documentation/gitremote-helpers.txt\n> @@ -174,8 +174,8 @@ ref.\n>  This capability can be advertised multiple times.  The first\n>  applicable refspec takes precedence.  The left-hand of refspecs\n>  advertised with this capability must cover all refs reported by\n> -the list command.  If no 'refspec' capability is advertised,\n> -there is an implied `refspec *:*`.\n> +the list command.  If a helper does not need a specific 'refspec'\n> +capability then it should advertise `refspec *:*`.\n\nBut if it advertises a straight 'refspec *:*', nothing would work. If\nanything, it should be 'refs/heads/*:refs/remotes/$alias/*', but then\ntags would fail. Why not just tell the remote helpers to do the right\nthing and avoid this comment altogether?\n\n-- \nFelipe Contreras\n"}]}