{"thread":{"id":"33370","subject":"[PATCH] Documentation: Strip texinfo anchors to avoid duplicates","startedAt":"2013-04-03T19:54:33Z","lastAt":"2013-04-03T21:08:34Z","messageCount":3,"participants":["Martin von Gagern","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"213060","messageId":"1365018873-22503-1-git-send-email-Martin.vGagern@gmx.net","threadId":"33370","inReplyTo":null,"subject":"[PATCH] Documentation: Strip texinfo anchors to avoid duplicates","fromName":"Martin von Gagern","fromEmail":"martin.vgagern@gmx.net","sentAt":"2013-04-03T19:54:33Z","receivedAt":"2013-04-03T19:54:33Z","isPatch":true,"sender":{"key":"martin.vgagern@gmx.net","avatar":"https://avatars.githubusercontent.com/u/190759?v=4"},"body":"This keeps texinfo 5.x happy. See https://bugs.gentoo.org/464210.\n\nSigned-off-by: Martin von Gagern <Martin.vGagern@gmx.net>\n---\n Documentation/cat-texi.perl | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Documentation/cat-texi.perl b/Documentation/cat-texi.perl\nindex dbc133c..b52660d 100755\n--- a/Documentation/cat-texi.perl\n+++ b/Documentation/cat-texi.perl\n@@ -12,6 +12,7 @@ while (<STDIN>) {\n \t\tpush @menu, $1;\n \t}\n \ts/\\(\\@pxref{\\[(URLS|REMOTES)\\]}\\)//;\n+\ts/\\@anchor\\{[^{}]*\\}//g;\n \tprint TMP;\n }\n close TMP;\n-- \n1.8.1.5\n"},{"id":"213066","messageId":"7vppyb4bu3.fsf@alter.siamese.dyndns.org","threadId":"33370","inReplyTo":"1365018873-22503-1-git-send-email-Martin.vGagern@gmx.net","subject":"Re: [PATCH] Documentation: Strip texinfo anchors to avoid duplicates","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-03T20:07:48Z","receivedAt":"2013-04-03T20:07:48Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin von Gagern <Martin.vGagern@gmx.net> writes:\n\n> This keeps texinfo 5.x happy. See https://bugs.gentoo.org/464210.\n\nI see why duplicates are bad, but does that mean not having any is\nbetter?\n\n>\n> Signed-off-by: Martin von Gagern <Martin.vGagern@gmx.net>\n> ---\n>  Documentation/cat-texi.perl | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/Documentation/cat-texi.perl b/Documentation/cat-texi.perl\n> index dbc133c..b52660d 100755\n> --- a/Documentation/cat-texi.perl\n> +++ b/Documentation/cat-texi.perl\n> @@ -12,6 +12,7 @@ while (<STDIN>) {\n>  \t\tpush @menu, $1;\n>  \t}\n>  \ts/\\(\\@pxref{\\[(URLS|REMOTES)\\]}\\)//;\n> +\ts/\\@anchor\\{[^{}]*\\}//g;\n>  \tprint TMP;\n>  }\n>  close TMP;\n"},{"id":"213070","messageId":"515C9A52.7020203@gmx.net","threadId":"33370","inReplyTo":"7vppyb4bu3.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] Documentation: Strip texinfo anchors to avoid duplicates","fromName":"Martin von Gagern","fromEmail":"martin.vgagern@gmx.net","sentAt":"2013-04-03T21:08:34Z","receivedAt":"2013-04-03T21:08:34Z","isPatch":true,"sender":{"key":"martin.vgagern@gmx.net","avatar":"https://avatars.githubusercontent.com/u/190759?v=4"},"body":"On 03.04.2013 22:07, Junio C Hamano wrote:\n> I see why duplicates are bad, but does that mean not having any is\n> better?\n\nI'd say yes: duplicate anchors cause current versions of texinfo to\nreject the document outright, and older versions will likely cause a\nbroken interpretation of any anchor names.\n\nWhat are possible scenarios where anchors could be useful?\na) Internal cross reference. I'm not sure whether texinfo checks for\n   broken internal links. If it does, it did not report any.\nb) Goto command issued by the user. I suppose most users would be happy\n   with node-level navigation, and not use it for navigation to\n   sub-node sections.\nc) URLs in bookmarks or mails. I suppose people are more likely to use\n   the html documents built by asciidoc, instead of a version\n   constructed from the texinfo document. So not our issue.\nDid I miss a relevant use case?\n\nAutomatically (or even manually?) generated unique names might be better\nthan none. But I'm not sure they are worth the trouble.\n\nMartin von Gagern\n\n"}]}