{"thread":{"id":"33344","subject":"[PATCH 1/3] remote-helpers: fix the run of all tests","startedAt":"2013-04-01T21:14:29Z","lastAt":"2013-04-04T15:36:50Z","messageCount":15,"participants":["Felipe Contreras","Antoine Pelisse","Junio C Hamano","Jeff King","Torsten Bögershausen"],"isPatch":true,"patchVersion":1,"patchTotal":3},"messages":[{"id":"212819","messageId":"1364850872-21135-1-git-send-email-felipe.contreras@gmail.com","threadId":"33344","inReplyTo":null,"subject":"[PATCH 0/3] remote-helpers: trivial test fixes","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-01T21:14:29Z","receivedAt":"2013-04-01T21:14:29Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Hi,\n\nHere are a few fixes for the test framework on the remote-helpers.\n\nFelipe Contreras (3):\n remote-helpers: fix the run of all tests\n remote-bzr: remove stale check code for tests\n remote-hg: fix hg-git test-case\n\n contrib/remote-helpers/Makefile | 1 +\n contrib/remote-helpers/test-bzr.sh | 14 --------------\n contrib/remote-helpers/test-hg-hg-git.sh | 1 -\n 3 files changed, 1 insertion(+), 15 deletions(-)\n\n-- \n1.8.2\n"},{"id":"212816","messageId":"1364850872-21135-2-git-send-email-felipe.contreras@gmail.com","threadId":"33344","inReplyTo":"1364850872-21135-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-01T21:14:30Z","receivedAt":"2013-04-01T21:14:30Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Since test-lint doesn't seem to work here, lets disable it. It wouldn't\nhelp either way.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/Makefile | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/contrib/remote-helpers/Makefile b/contrib/remote-helpers/Makefile\nindex 9a76575..9c18ed8 100644\n--- a/contrib/remote-helpers/Makefile\n+++ b/contrib/remote-helpers/Makefile\n@@ -3,6 +3,7 @@ TESTS := $(wildcard test*.sh)\n export T := $(addprefix $(CURDIR)/,$(TESTS))\n export MAKE := $(MAKE) -e\n export PATH := $(CURDIR):$(PATH)\n+export TEST_LINT :=\n \n test:\n \t$(MAKE) -C ../../t $@\n-- \n1.8.2\n"},{"id":"212817","messageId":"1364850872-21135-3-git-send-email-felipe.contreras@gmail.com","threadId":"33344","inReplyTo":"1364850872-21135-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 2/3] remote-bzr: remove stale check code for tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-01T21:14:31Z","receivedAt":"2013-04-01T21:14:31Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"The fastimport plugin was only required in the early stage of\ndevelopment.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/test-bzr.sh | 14 --------------\n 1 file changed, 14 deletions(-)\n\ndiff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh\nindex 70aa8a0..5dac171 100755\n--- a/contrib/remote-helpers/test-bzr.sh\n+++ b/contrib/remote-helpers/test-bzr.sh\n@@ -17,20 +17,6 @@ if ! \"$PYTHON_PATH\" -c 'import bzrlib'; then\n \ttest_done\n fi\n \n-cmd='\n-import bzrlib\n-bzrlib.initialize()\n-import bzrlib.plugin\n-bzrlib.plugin.load_plugins()\n-import bzrlib.plugins.fastimport\n-'\n-\n-if ! \"$PYTHON_PATH\" -c \"$cmd\"; then\n-\techo \"consider setting BZR_PLUGIN_PATH=$HOME/.bazaar/plugins\" 1>&2\n-\tskip_all='skipping remote-bzr tests; bzr-fastimport not available'\n-\ttest_done\n-fi\n-\n check () {\n \t(cd $1 &&\n \tgit log --format='%s' -1 &&\n-- \n1.8.2\n"},{"id":"212818","messageId":"1364850872-21135-4-git-send-email-felipe.contreras@gmail.com","threadId":"33344","inReplyTo":"1364850872-21135-1-git-send-email-felipe.contreras@gmail.com","subject":"[PATCH 3/3] remote-hg: fix hg-git test-case","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-01T21:14:32Z","receivedAt":"2013-04-01T21:14:32Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"There was some lingering code that shouldn't have been there in the\nfirst place.\n\nSigned-off-by: Felipe Contreras \n---\n contrib/remote-helpers/test-hg-hg-git.sh | 1 -\n 1 file changed, 1 deletion(-)\n\ndiff --git a/contrib/remote-helpers/test-hg-hg-git.sh b/contrib/remote-helpers/test-hg-hg-git.sh\nindex 7e3967f..3f253b7 100755\n--- a/contrib/remote-helpers/test-hg-hg-git.sh\n+++ b/contrib/remote-helpers/test-hg-hg-git.sh\n@@ -140,7 +140,6 @@ test_expect_success 'executable bit' '\n \t\tgit_clone_$x hgrepo-$x gitrepo2-$x &&\n \t\tgit_log gitrepo2-$x > log-$x\n \tdone &&\n-\tcp -r log-* output-* /tmp/foo/ &&\n \n \ttest_cmp output-hg output-git &&\n \ttest_cmp log-hg log-git\n-- \n1.8.2\n"},{"id":"212821","messageId":"CALWbr2wAqudzbfiSHmD1uAVQX3mtbf5vgr2JXbXEg7yzaKXJcw@mail.gmail.com","threadId":"33344","inReplyTo":"1364850872-21135-2-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Antoine Pelisse","fromEmail":"apelisse@gmail.com","sentAt":"2013-04-01T21:46:00Z","receivedAt":"2013-04-01T21:46:00Z","isPatch":true,"sender":{"key":"apelisse@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1929644?v=4"},"body":"Hey Felipe,\n\nOn Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras\n wrote:\n> +export TEST_LINT :=\n\nI think \"test-lint-executable\" still makes sense here.\n"},{"id":"212825","messageId":"CALWbr2wAJGemYziPsOkArJveK0F+4Pv80gdR1SGUxchb0ci-sg@mail.gmail.com","threadId":"33344","inReplyTo":"1364850872-21135-1-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH 0/3] remote-helpers: trivial test fixes","fromName":"Antoine Pelisse","fromEmail":"apelisse@gmail.com","sentAt":"2013-04-01T21:48:29Z","receivedAt":"2013-04-01T21:48:29Z","isPatch":true,"sender":{"key":"apelisse@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1929644?v=4"},"body":"I'm having an error in \"contrib/remote-helpers/test-hg.sh\" and it\nreproduces on every version I tested since you implemented it. Is it\nsomething in my environment that would make it wrong ?\n\nCheers,\nAntoine\n\n---\nexpecting success:\n test_when_finished \"rm -rf gitrepo*\" &&\n\n (\n cd hgrepo &&\n hg update -r 0\n ) &&\n\n git clone \"hg::$PWD/hgrepo\" gitrepo &&\n check gitrepo zero master\n\n1 files updated, 0 files merged, 0 files removed, 0 files unresolved\nCloning into 'gitrepo'...\n--- expected 2013-04-01 21:46:32.086796549 +0000\n+++ actual 2013-04-01 21:46:32.086796549 +0000\n@@ -1,2 +1,2 @@\n-zero\n-refs/heads/master\n+feature-a\n+refs/heads/feature-a\nnot ok 4 - cloning with detached head\n\nOn Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras\n wrote:\n> Hi,\n>\n> Here are a few fixes for the test framework on the remote-helpers.\n>\n> Felipe Contreras (3):\n> remote-helpers: fix the run of all tests\n> remote-bzr: remove stale check code for tests\n> remote-hg: fix hg-git test-case\n>\n> contrib/remote-helpers/Makefile | 1 +\n> contrib/remote-helpers/test-bzr.sh | 14 --------------\n> contrib/remote-helpers/test-hg-hg-git.sh | 1 -\n> 3 files changed, 1 insertion(+), 15 deletions(-)\n>\n> --\n> 1.8.2\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html\n"},{"id":"212828","messageId":"CAMP44s2d-gZHsgibq2E8vZ25vciJRBh5Z0hYmx5pNa+CW5gvyg@mail.gmail.com","threadId":"33344","inReplyTo":"CALWbr2wAJGemYziPsOkArJveK0F+4Pv80gdR1SGUxchb0ci-sg@mail.gmail.com","subject":"Re: [PATCH 0/3] remote-helpers: trivial test fixes","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-01T21:56:36Z","receivedAt":"2013-04-01T21:56:36Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Hi,\n\nOn Mon, Apr 1, 2013 at 3:48 PM, Antoine Pelisse wrote:\n> I'm having an error in \"contrib/remote-helpers/test-hg.sh\" and it\n> reproduces on every version I tested since you implemented it. Is it\n> something in my environment that would make it wrong ?\n>\n> Cheers,\n> Antoine\n>\n> ---\n> expecting success:\n> test_when_finished \"rm -rf gitrepo*\" &&\n>\n> (\n> cd hgrepo &&\n> hg update -r 0\n> ) &&\n>\n> git clone \"hg::$PWD/hgrepo\" gitrepo &&\n> check gitrepo zero master\n>\n> 1 files updated, 0 files merged, 0 files removed, 0 files unresolved\n> Cloning into 'gitrepo'...\n> --- expected 2013-04-01 21:46:32.086796549 +0000\n> +++ actual 2013-04-01 21:46:32.086796549 +0000\n> @@ -1,2 +1,2 @@\n> -zero\n> -refs/heads/master\n> +feature-a\n> +refs/heads/feature-a\n> not ok 4 - cloning with detached head\n\nYou probably have a very old version of mercurial that has a bug, this\nshould workaround the issue:\nhttp://thread.gmane.org/gmane.comp.version-control.git/209491\n\nBut it shouldn't be a big deal, it's just the default branch (HEAD).\n\n--\nFelipe Contreras\n"},{"id":"212829","messageId":"7vli91j2ds.fsf@alter.siamese.dyndns.org","threadId":"33344","inReplyTo":"1364850872-21135-3-git-send-email-felipe.contreras@gmail.com","subject":"Re: [PATCH 2/3] remote-bzr: remove stale check code for tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-01T22:46:07Z","receivedAt":"2013-04-01T22:46:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Felipe Contreras writes:\n\n> The fastimport plugin was only required in the early stage of\n> development.\n\nOK, thanks, will queue.\n\n>\n> Signed-off-by: Felipe Contreras \n> ---\n> contrib/remote-helpers/test-bzr.sh | 14 --------------\n> 1 file changed, 14 deletions(-)\n>\n> diff --git a/contrib/remote-helpers/test-bzr.sh b/contrib/remote-helpers/test-bzr.sh\n> index 70aa8a0..5dac171 100755\n> --- a/contrib/remote-helpers/test-bzr.sh\n> +++ b/contrib/remote-helpers/test-bzr.sh\n> @@ -17,20 +17,6 @@ if ! \"$PYTHON_PATH\" -c 'import bzrlib'; then\n> \ttest_done\n> fi\n> \n> -cmd='\n> -import bzrlib\n> -bzrlib.initialize()\n> -import bzrlib.plugin\n> -bzrlib.plugin.load_plugins()\n> -import bzrlib.plugins.fastimport\n> -'\n> -\n> -if ! \"$PYTHON_PATH\" -c \"$cmd\"; then\n> -\techo \"consider setting BZR_PLUGIN_PATH=$HOME/.bazaar/plugins\" 1>&2\n> -\tskip_all='skipping remote-bzr tests; bzr-fastimport not available'\n> -\ttest_done\n> -fi\n> -\n> check () {\n> \t(cd $1 &&\n> \tgit log --format='%s' -1 &&\n"},{"id":"212830","messageId":"CAMP44s0cUZDuzdzR9k_UBgmKn4=dy1he8o=XuPag=LhjWMWJoA@mail.gmail.com","threadId":"33344","inReplyTo":"CAMP44s2d-gZHsgibq2E8vZ25vciJRBh5Z0hYmx5pNa+CW5gvyg@mail.gmail.com","subject":"Re: [PATCH 0/3] remote-helpers: trivial test fixes","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-01T22:46:54Z","receivedAt":"2013-04-01T22:46:54Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"On Mon, Apr 1, 2013 at 3:56 PM, Felipe Contreras\n wrote:\n\n> You probably have a very old version of mercurial that has a bug, this\n> should workaround the issue:\n> http://thread.gmane.org/gmane.comp.version-control.git/209491\n\nI meant:\nhttp://article.gmane.org/gmane.comp.version-control.git/209581\n\n\n--\nFelipe Contreras\n"},{"id":"212835","messageId":"20130401234016.GC30935@sigill.intra.peff.net","threadId":"33344","inReplyTo":"CALWbr2wAqudzbfiSHmD1uAVQX3mtbf5vgr2JXbXEg7yzaKXJcw@mail.gmail.com","subject":"Re: [PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-04-01T23:40:16Z","receivedAt":"2013-04-01T23:40:16Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote:\n\n> On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras\n> wrote:\n> > +export TEST_LINT :=\n> \n> I think \"test-lint-executable\" still makes sense here.\n\nAlso test-lint-shell-syntax, which finds a problem with the current\ncode:\n\n $ cd contrib/remote-helpers\n $ make test TEST_LINT=test-lint-shell-syntax\n make -e -C ../../t test\n make[1]: Entering directory `/home/peff/compile/git/t'\n rm -f -r test-results\n /home/peff/compile/git/contrib/remote-helpers/test-bzr.sh:139: error: echo -n is not portable (please use printf): echo -n content > expected &&\n make[1]: *** [test-lint-shell-syntax] Error 1\n make[1]: Leaving directory `/home/peff/compile/git/t'\n make: *** [test] Error 2\n\nI think the check for duplicate-numbers is the only one that does not\nmake sense. Unfortunately it is not as simple as using $(filter-out) to\nget rid of it from TEST_LINT, as that variable may not even be set until\nwe chain to the other Makefile (e.g., if it comes from loading\nconfig.mak).\n\n-Peff\n"},{"id":"212904","messageId":"515B0D08.4020405@web.de","threadId":"33344","inReplyTo":"20130401234016.GC30935@sigill.intra.peff.net","subject":"Re: [PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-02T16:53:28Z","receivedAt":"2013-04-02T16:53:28Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 02.04.13 01:40, Jeff King wrote:\n> On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote:\n> \n>> On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras\n>> wrote:\n>>> +export TEST_LINT :=\n>>\n>> I think \"test-lint-executable\" still makes sense here.\n> \n> Also test-lint-shell-syntax, which finds a problem with the current\n> code:\n> \n> $ cd contrib/remote-helpers\n> $ make test TEST_LINT=test-lint-shell-syntax\n> make -e -C ../../t test\n> make[1]: Entering directory `/home/peff/compile/git/t'\n> rm -f -r test-results\n> /home/peff/compile/git/contrib/remote-helpers/test-bzr.sh:139: error: echo -n is not portable (please use printf): echo -n content > expected &&\n> make[1]: *** [test-lint-shell-syntax] Error 1\n> make[1]: Leaving directory `/home/peff/compile/git/t'\n> make: *** [test] Error 2\n> \n> I think the check for duplicate-numbers is the only one that does not\n> make sense. \n[]\nNot sure about that, I send a suggestion of a patch in a minute.\nHighlights:\n1) - rename the contrib test cases and assigns real TC numbers\n2) - Forward the numbers into the main \"test Makefile\"\n\n1) Will probably collide with Felipe's changes, so we just can pick up the idea.\n2) Is for only review.\n If we agree on the re-numbering of TC's in contrib, we can apply\n a second round of the patch later.\n\n/Torsten\n"},{"id":"212922","messageId":"20130402173652.GC24698@sigill.intra.peff.net","threadId":"33344","inReplyTo":"515B0D08.4020405@web.de","subject":"Re: [PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2013-04-02T17:36:52Z","receivedAt":"2013-04-02T17:36:52Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Tue, Apr 02, 2013 at 06:53:28PM +0200, Torsten Bögershausen wrote:\n\n> > I think the check for duplicate-numbers is the only one that does not\n> > make sense. \n> []\n> Not sure about that, I send a suggestion of a patch in a minute.\n> Highlights:\n> 1) - rename the contrib test cases and assigns real TC numbers\n> 2) - Forward the numbers into the main \"test Makefile\"\n\nI'm not sure if this is a good idea or not. It puts the\ncontrib/remote-helpers into the same \"number namespace\" as the rest of\nthe test scripts, and enforces uniqueness with test-lint-duplicates,\nwhen \"make test\" is run from contrib/remote-helpers. But people working\non the main test scripts would not get any such check, and would happily\nbreak contrib/remote-helpers by adding duplicate test numbers.\n\nIt makes sense to me to either:\n\n 1. Have the contrib/remote-helpers test live in their own test\n namespace completely, with their own numbers and test-results, and\n pull in relevant bits from the main test harness. We do this\n already with contrib/subtree. I suggested this when the tests\n first appeared, but there was some argument, and I don't remember\n the details.\n\n 2. Just integrate contrib test scripts into the main repository, but\n leave them off by default. For example, add:\n\n if test -z \"$GIT_TEST_REMOTE_HELPERS\"; then\n skip_all=\"Remote helper tests disabled (define GIT_TEST_REMOTE_HELPERS)\"\n test_done\n fi\n\n to the top of the scripts, and then set GIT_TEST_REMOTE_HELPERS\n in contrib/remote-helpers/Makefile before chaining to the test\n Makefile.\n\n-Peff\n"},{"id":"213022","messageId":"515BC3E5.2020501@web.de","threadId":"33344","inReplyTo":"20130402173652.GC24698@sigill.intra.peff.net","subject":"Re: [PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2013-04-03T05:53:41Z","receivedAt":"2013-04-03T05:53:41Z","isPatch":true,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On 02.04.13 19:36, Jeff King wrote:\n> On Tue, Apr 02, 2013 at 06:53:28PM +0200, Torsten Bögershausen wrote:\n> \n>>> I think the check for duplicate-numbers is the only one that does not\n>>> make sense. \n>> []\n>> Not sure about that, I send a suggestion of a patch in a minute.\n>> Highlights:\n>> 1) - rename the contrib test cases and assigns real TC numbers\n>> 2) - Forward the numbers into the main \"test Makefile\"\n> \n> I'm not sure if this is a good idea or not. It puts the\n> contrib/remote-helpers into the same \"number namespace\" as the rest of\n> the test scripts, and enforces uniqueness with test-lint-duplicates,\n> when \"make test\" is run from contrib/remote-helpers. But people working\n> on the main test scripts would not get any such check, and would happily\n> break contrib/remote-helpers by adding duplicate test numbers.\n> \n> It makes sense to me to either:\n> \n> 1. Have the contrib/remote-helpers test live in their own test\n> namespace completely, with their own numbers and test-results, and\n> pull in relevant bits from the main test harness. We do this\n> already with contrib/subtree. I suggested this when the tests\n> first appeared, but there was some argument, and I don't remember\n> the details.\n> \n> 2. Just integrate contrib test scripts into the main repository, but\n> leave them off by default. For example, add:\n> \n> if test -z \"$GIT_TEST_REMOTE_HELPERS\"; then\n> skip_all=\"Remote helper tests disabled (define GIT_TEST_REMOTE_HELPERS)\"\n> test_done\n> fi\n> \n> to the top of the scripts, and then set GIT_TEST_REMOTE_HELPERS\n> in contrib/remote-helpers/Makefile before chaining to the test\n> Makefile.\n> \n> -Peff\n\nI think I do my homework, and start with 3), just check duplicates on numbered\ntest cases.\n\nhttp://comments.gmane.org/gmane.comp.version-control.git/214194\nI send a patch in a minute (thanks Eric for reading)\n"},{"id":"213039","messageId":"7v8v4z7jcv.fsf@alter.siamese.dyndns.org","threadId":"33344","inReplyTo":"20130402173652.GC24698@sigill.intra.peff.net","subject":"Re: [PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-04-03T14:57:04Z","receivedAt":"2013-04-03T14:57:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> On Tue, Apr 02, 2013 at 06:53:28PM +0200, Torsten Bögershausen wrote:\n>\n>> > I think the check for duplicate-numbers is the only one that does not\n>> > make sense. \n>> []\n>> Not sure about that, I send a suggestion of a patch in a minute.\n>> Highlights:\n>> 1) - rename the contrib test cases and assigns real TC numbers\n>> 2) - Forward the numbers into the main \"test Makefile\"\n>\n> I'm not sure if this is a good idea or not.\n\nIf that's a polite way to say that this is not a good idea, I'd\nagree for all the reasons you mentioned.\n\n> It puts the\n> contrib/remote-helpers into the same \"number namespace\" as the rest of\n> the test scripts, and enforces uniqueness with test-lint-duplicates,\n> when \"make test\" is run from contrib/remote-helpers. But people working\n> on the main test scripts would not get any such check, and would happily\n> break contrib/remote-helpers by adding duplicate test numbers.\n>\n> It makes sense to me to either:\n>\n> 1. Have the contrib/remote-helpers test live in their own test\n> namespace completely, with their own numbers and test-results, and\n> pull in relevant bits from the main test harness. We do this\n> already with contrib/subtree. I suggested this when the tests\n> first appeared, but there was some argument, and I don't remember\n> the details.\n\nThis makes more sense than the alternative, given that contrib/\nmaterial is \"optional\" from the main tree's point of view, at least\nto me.\n\nThanks.\n\n> 2. Just integrate contrib test scripts into the main repository, but\n> leave them off by default. For example, add:\n>\n> if test -z \"$GIT_TEST_REMOTE_HELPERS\"; then\n> skip_all=\"Remote helper tests disabled (define GIT_TEST_REMOTE_HELPERS)\"\n> test_done\n> fi\n>\n> to the top of the scripts, and then set GIT_TEST_REMOTE_HELPERS\n> in contrib/remote-helpers/Makefile before chaining to the test\n> Makefile.\n"},{"id":"213120","messageId":"515d9e126cd2a_69fd13fde1816811@nysa.mail","threadId":"33344","inReplyTo":"20130401234016.GC30935@sigill.intra.peff.net","subject":"Re: [PATCH 1/3] remote-helpers: fix the run of all tests","fromName":"Felipe Contreras","fromEmail":"felipe.contreras@gmail.com","sentAt":"2013-04-04T15:36:50Z","receivedAt":"2013-04-04T15:36:50Z","isPatch":true,"sender":{"key":"felipe.contreras@gmail.com","avatar":"https://avatars.githubusercontent.com/u/8358?v=4"},"body":"Jeff King wrote:\n> On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote:\n> \n> > On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras\n> > wrote:\n> > > +export TEST_LINT :=\n> > \n> > I think \"test-lint-executable\" still makes sense here.\n> \n> Also test-lint-shell-syntax, which finds a problem with the current\n> code:\n> \n> $ cd contrib/remote-helpers\n> $ make test TEST_LINT=test-lint-shell-syntax\n> make -e -C ../../t test\n> make[1]: Entering directory `/home/peff/compile/git/t'\n> rm -f -r test-results\n> /home/peff/compile/git/contrib/remote-helpers/test-bzr.sh:139: error: echo -n is not portable (please use printf): echo -n content > expected &&\n> make[1]: *** [test-lint-shell-syntax] Error 1\n> make[1]: Leaving directory `/home/peff/compile/git/t'\n> make: *** [test] Error 2\n\nIndeed. I've fixed he problem, and added the two lint checks to the new version\nof the series.\n\n-- \nFelipe Contreras\n"}]}