{"thread":{"id":"33303","subject":"Re: [PATCH] config: Consistent call style to gpg settings","startedAt":"2013-03-27T16:17:54Z","lastAt":"2013-03-27T16:17:54Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"212394","messageId":"7vehf0olzh.fsf@alter.siamese.dyndns.org","threadId":"33303","inReplyTo":"8C726954D36902459248B0627BF2E66F45D70C3E55@AUSP01VMBX10.collaborationhost.net","subject":"Re: [PATCH] config: Consistent call style to gpg settings","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-27T16:17:54Z","receivedAt":"2013-03-27T16:17:54Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Hans Brigman <hbrigman@openspan.com> writes:\n\n> From: Jacob Sarvis <jsarvis@openspan.com>\n>\n> config: Consistent call style to gpg settings\n>\n> Calling style for passing settings to git_gpg_config is inconsistent\n> between commit-tree, commit, merge, tag, and verify-tag.\n>\n> Consolidate style of calling git_gpg_config.\n>\n> Signed-off-by: Hans Brigman <hbrigman@openspan.com>\n\nExactly the same comments as the review for the other patch apply here.\n\n> ---\n> builtin/commit-tree.c |  5 ++---\n> builtin/commit.c      |  6 ++----\n> builtin/merge.c       | 12 ++++--------\n> builtin/tag.c         |  5 ++---\n> builtin/verify-tag.c  |  5 ++---\n> 5 files changed, 12 insertions(+), 21 deletions(-)\n>\n> diff --git a/builtin/commit-tree.c b/builtin/commit-tree.c\n> index eac901a..45e0152 100644\n> --- a/builtin/commit-tree.c\n> +++ b/builtin/commit-tree.c\n> @@ -28,9 +28,8 @@ static void new_parent(struct commit *parent, struct commit_list **parents_p)\n>  static int commit_tree_config(const char *var, const char *value, void *cb)\n> {\n> -              int status = git_gpg_config(var, value, NULL);\n> -              if (status)\n> -                              return status;\n> +             if (git_gpg_config(var, value, cb) < 0)\n> +                             return -1;\n>                return git_default_config(var, value, cb);\n> }\n\nEarlier, we always returned what the underlying helper returned, but\nin this version, we ignore error return values from git_gpg_config()\nbut honor error return values from git_default_config().\n\nThis is making things worse, no?\n"}]}