{"thread":{"id":"33291","subject":"[PATCH] git-svn: Support custom tunnel schemes instead of SSH only","startedAt":"2013-03-26T21:24:38Z","lastAt":"2013-03-27T18:08:18Z","messageCount":4,"participants":["Sebastian Schuberth","Eric Wong","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"212336","messageId":"51521216.2050309@gmail.com","threadId":"33291","inReplyTo":null,"subject":"[PATCH] git-svn: Support custom tunnel schemes instead of SSH only","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2013-03-26T21:24:38Z","receivedAt":"2013-03-26T21:24:38Z","isPatch":true,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"This originates from an msysgit pull request, see:\n\nhttps://github.com/msysgit/git/pull/58\n\nSigned-off-by: Eric Wieser \nSigned-off-by: Sebastian Schuberth \n---\n perl/Git/SVN/Ra.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm\nindex 049c97b..6a212eb 100644\n--- a/perl/Git/SVN/Ra.pm\n+++ b/perl/Git/SVN/Ra.pm\n@@ -295,7 +295,7 @@ sub gs_do_switch {\n \tmy $full_url = add_path_to_url( $self->url, $path );\n \tmy ($ra, $reparented);\n \n-\tif ($old_url =~ m#^svn(\\+ssh)?://# ||\n+\tif ($old_url =~ m#^svn(\\+\\w+)?://# ||\n \t ($full_url =~ m#^https?://# &&\n \t canonicalize_url($full_url) ne $full_url)) {\n \t\t$_[0] = undef;\n-- \n1.8.1.msysgit.1\n"},{"id":"212366","messageId":"20130327043255.GA3667@dcvr.yhbt.net","threadId":"33291","inReplyTo":"51521216.2050309@gmail.com","subject":"Re: [PATCH] git-svn: Support custom tunnel schemes instead of SSH only","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2013-03-27T04:32:55Z","receivedAt":"2013-03-27T04:32:55Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Sebastian Schuberth wrote:\n> This originates from an msysgit pull request, see:\n> \n> https://github.com/msysgit/git/pull/58\n> \n> Signed-off-by: Eric Wieser \n> Signed-off-by: Sebastian Schuberth \n\nThanks, looks obviously correct.\n\nSigned-off-by: Eric Wong \n\n> diff --git a/perl/Git/SVN/Ra.pm b/perl/Git/SVN/Ra.pm\n> index 049c97b..6a212eb 100644\n> --- a/perl/Git/SVN/Ra.pm\n> +++ b/perl/Git/SVN/Ra.pm\n> @@ -295,7 +295,7 @@ sub gs_do_switch {\n> \tmy $full_url = add_path_to_url( $self->url, $path );\n> \tmy ($ra, $reparented);\n> \n> -\tif ($old_url =~ m#^svn(\\+ssh)?://# ||\n> +\tif ($old_url =~ m#^svn(\\+\\w+)?://# ||\n> \t ($full_url =~ m#^https?://# &&\n> \t canonicalize_url($full_url) ne $full_url)) {\n> \t\t$_[0] = undef;\n> -- \n\nJunio:\n\nThe following changes since commit 2bba2f0e6542d541e9f27653d8c9d5fc8d0e679c:\n\n More topics from the second batch for 1.8.3 (2013-03-26 13:16:11 -0700)\n\nare available in the git repository at:\n\n git://git.bogomips.org/git-svn.git master\n\nfor you to fetch changes up to 3747c015704399dea1aa7ae6569a507e5727e20b:\n\n git-svn: Support custom tunnel schemes instead of SSH only (2013-03-27 04:28:04 +0000)\n\n----------------------------------------------------------------\nSebastian Schuberth (1):\n git-svn: Support custom tunnel schemes instead of SSH only\n\n perl/Git/SVN/Ra.pm | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n"},{"id":"212397","messageId":"7va9poolj7.fsf@alter.siamese.dyndns.org","threadId":"33291","inReplyTo":"20130327043255.GA3667@dcvr.yhbt.net","subject":"Re: [PATCH] git-svn: Support custom tunnel schemes instead of SSH only","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2013-03-27T16:27:40Z","receivedAt":"2013-03-27T16:27:40Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Sebastian Schuberth wrote:\n>> This originates from an msysgit pull request, see:\n>> \n>> https://github.com/msysgit/git/pull/58\n>> \n>> Signed-off-by: Eric Wieser \n>> Signed-off-by: Sebastian Schuberth \n>\n> Thanks, looks obviously correct.\n>\n> Signed-off-by: Eric Wong \n> ...\n>\n> Junio:\n>\n> The following changes since commit 2bba2f0e6542d541e9f27653d8c9d5fc8d0e679c:\n>\n> More topics from the second batch for 1.8.3 (2013-03-26 13:16:11 -0700)\n>\n> are available in the git repository at:\n>\n> git://git.bogomips.org/git-svn.git master\n>\n> for you to fetch changes up to 3747c015704399dea1aa7ae6569a507e5727e20b:\n>\n> git-svn: Support custom tunnel schemes instead of SSH only (2013-03-27 04:28:04 +0000)\n\nThanks. Will pull.\n\nBy the way, did nobody in the patch chain find the log message\nproblematic? It does not give any information other than a URL to\nan external site, and if you look at the URL it refers to, it only\nsays\n\n \"git svn fetch\" failed while talking to svn+xyz:// at Git/SVN/Ra.pm line 307\n\nwhich could easily have been written in the log message itself with\nfewer words.\n"},{"id":"212421","messageId":"20130327180818.GA6645@dcvr.yhbt.net","threadId":"33291","inReplyTo":"7va9poolj7.fsf@alter.siamese.dyndns.org","subject":"Re: [PATCH] git-svn: Support custom tunnel schemes instead of SSH only","fromName":"Eric Wong","fromEmail":"normalperson@yhbt.net","sentAt":"2013-03-27T18:08:18Z","receivedAt":"2013-03-27T18:08:18Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Junio C Hamano wrote:\n> Eric Wong writes:\n> >\n> > git-svn: Support custom tunnel schemes instead of SSH only (2013-03-27 04:28:04 +0000)\n> \n> Thanks. Will pull.\n> \n> By the way, did nobody in the patch chain find the log message\n> problematic? It does not give any information other than a URL to\n> an external site, and if you look at the URL it refers to, it only\n> says\n> \n> \"git svn fetch\" failed while talking to svn+xyz:// at Git/SVN/Ra.pm line 307\n> \n> which could easily have been written in the log message itself with\n> fewer words.\n\nOops, I wasn't happy with the log message, either, but remained silent\nsince I thought the subject/title for an obvious one-line change was\nsufficient. In other words, I think an empty log message (+S-o-b) would\nsuffice, too.\n"}]}