{"thread":{"id":"33288","subject":"[PATCH 0/2] Fix -Wuninitialized warnings on older gcc","startedAt":"2013-03-26T19:08:37Z","lastAt":"2013-03-26T19:08:37Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"212315","messageId":"5151F235.4080303@ramsay1.demon.co.uk","threadId":"33288","inReplyTo":null,"subject":"[PATCH 0/2] Fix -Wuninitialized warnings on older gcc","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsay1.demon.co.uk","sentAt":"2013-03-26T19:08:37Z","receivedAt":"2013-03-26T19:08:37Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"Hi Junio,\n\nI had prepared 3 patches, but I noticed this afternoon that\nthe warning in transport.c has already been fixed in maint.\nThese were built on the tip of master as of saturday evening\n(master @ 7b592fad).\n\nJust FYI, as of saturday, Jeff's patches in maint/master had\nremoved 40 warnings from the MSVC build; 34 of the warnings\nwere due to commit 25043d8a all on it's lonesome! [1]. The\nadditional patches in pu, remove an additional 14 warnings.\nThis leaves only the following:\n\n    $ grep warning msvc-pout | grep uninit\n    c:\\msysgit\\msysgit\\home\\ramsay\\git\\fast-import.c(2916) : warning C4700:\\\n    uninitialized local variable 'oe' used\n    c:\\msysgit\\msysgit\\home\\ramsay\\git\\builtin\\rev-list.c(341) : warning C4700:\\\n    uninitialized local variable 'reaches' used\n    c:\\msysgit\\msysgit\\home\\ramsay\\git\\builtin\\rev-list.c(341) : warning C4700:\\\n    uninitialized local variable 'all' used\n    c:\\msysgit\\msysgit\\home\\ramsay\\git\\merge-recursive.c(1886) : warning C4700:\\\n    uninitialized local variable 'mrtree' used\n\nATB,\nRamsay Jones\n\n[1] In case you are puzzled by this, the warning is coming from\nthe linker, since the msvc build is using link-time code-gen/optimisation.\n\n\nRamsay Allan Jones (2):\n  fast-import: Fix an gcc -Wuninitialized warning\n  cat-file: Fix an gcc -Wuninitialized warning\n\n builtin/cat-file.c | 2 +-\n fast-import.c      | 1 +\n 2 files changed, 2 insertions(+), 1 deletion(-)\n\n-- \n1.8.2\n"}]}